[issue39336] Immutable module type can't be used as package in custom loader

STINNER Victor added the comment: commit 2528a6c3d0660c03ae43d796628462ccf8e58190 Author: Dino Viehland Date: Mon Jan 27 14:04:56 2020 -0800 Add test.test_import.data.unwritable package to makefile (#18211) -- ___ Python tracker

[issue39336] Immutable module type can't be used as package in custom loader

STINNER Victor added the comment: test_unwritable_module() fails on AMD64 Fedora Stable Clang Installed 3.x: bpo-39459. -- nosy: +vstinner ___ Python tracker ___

[issue39336] Immutable module type can't be used as package in custom loader

Change by Dino Viehland : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue39336] Immutable module type can't be used as package in custom loader

Dino Viehland added the comment: New changeset 9b6fec46513006d7b06fcb645cca6e4f5bf7c7b8 by Dino Viehland in branch 'master': bpo-39336: Allow packages to not let their child modules be set on them (#18006) https://github.com/python/cpython/commit/9b6fec46513006d7b06fcb645cca6e4f5bf7c7b8

[issue39336] Immutable module type can't be used as package in custom loader

Dong-hee Na added the comment: I apologize for the noise caused by the wrong PR connection. -- nosy: +corona10 ___ Python tracker ___

[issue39336] Immutable module type can't be used as package in custom loader

Change by Dong-hee Na : -- pull_requests: -17433 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39336] Immutable module type can't be used as package in custom loader

Change by Dong-hee Na : -- pull_requests: -17431 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39336] Immutable module type can't be used as package in custom loader

Change by Dong-hee Na : -- pull_requests: +17433 pull_request: https://github.com/python/cpython/pull/18035 ___ Python tracker ___

[issue39336] Immutable module type can't be used as package in custom loader

Change by Dong-hee Na : -- pull_requests: +17431 pull_request: https://github.com/python/cpython/pull/18035 ___ Python tracker ___

[issue39336] Immutable module type can't be used as package in custom loader

Dino Viehland added the comment: I think the warning shouldn't be too bad. It looks like ImportWarnings are filtered by default already, and the extra overhead of raising a warning in this case probably is nothing compared to the actual work in loading the module. --

[issue39336] Immutable module type can't be used as package in custom loader

Change by Dino Viehland : -- keywords: +patch pull_requests: +17406 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/18006 ___ Python tracker

[issue39336] Immutable module type can't be used as package in custom loader

Brett Cannon added the comment: So I think this is way too marginal a use-case to expand the API to let loaders inject themselves into the semantics of it. I assume going with option 1 but raising an ImportWarning would be too noisy for your use-case? If not I'm totally fine with that

[issue39336] Immutable module type can't be used as package in custom loader

Change by Dino Viehland : -- nosy: +brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39336] Immutable module type can't be used as package in custom loader

New submission from Dino Viehland : I'm trying to create a custom module type for a custom loader where the returned modules are immutable. But I'm running into an issue where the immutable module type can't be used as a module for a package. That's because the import machinery calls