[issue40131] Zipapp example has parameters in the wrong order

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:

Thanks Leron for the report. Thanks Zackery for the patch.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions:  -Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40131] Zipapp example has parameters in the wrong order

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:


New changeset d19162fe5b2aba48a94278baa0f569fc42932072 by Miss Islington (bot) 
in branch '3.7':
bpo-40131: Fix source and target order in zipapp example (GH-19290) (GH-19340)
https://github.com/python/cpython/commit/d19162fe5b2aba48a94278baa0f569fc42932072


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40131] Zipapp example has parameters in the wrong order

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:


New changeset e6783981df6ae5c63f73be67cc41b1350bc0fcc6 by Miss Islington (bot) 
in branch '3.8':
bpo-40131: Fix source and target order in zipapp example (GH-19290) (GH-19339)
https://github.com/python/cpython/commit/e6783981df6ae5c63f73be67cc41b1350bc0fcc6


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40131] Zipapp example has parameters in the wrong order

[miss-islington]

Change by miss-islington :


--
pull_requests: +18704
pull_request: https://github.com/python/cpython/pull/19340

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40131] Zipapp example has parameters in the wrong order

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 4.0 -> 5.0
pull_requests: +18703
pull_request: https://github.com/python/cpython/pull/19339

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40131] Zipapp example has parameters in the wrong order

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:


New changeset bd6a4c3d72828d3d0e13922e165998539d24f8bc by Zackery Spytz in 
branch 'master':
bpo-40131: Fix source and target order in zipapp example (GH-19290)
https://github.com/python/cpython/commit/bd6a4c3d72828d3d0e13922e165998539d24f8bc


--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40131] Zipapp example has parameters in the wrong order

[Zackery Spytz]

Change by Zackery Spytz :


--
keywords: +patch
nosy: +ZackerySpytz
nosy_count: 2.0 -> 3.0
pull_requests: +18649
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/19290

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40131] Zipapp example has parameters in the wrong order

[Leron Gray]

New submission from Leron Gray :

The second example listed here for zipapp has the parameters in the wrong 
order. 

https://docs.python.org/3/library/zipapp.html?highlight=zipapp#examples

It should be create_archive("myapp", "myapp.pyz") since the parameters are 
(source, target). The documentation for the function itself is correct though.

--
assignee: docs@python
components: Documentation
messages: 365436
nosy: Leron Gray, docs@python
priority: normal
severity: normal
status: open
title: Zipapp example has parameters in the wrong order
type: enhancement
versions: Python 3.5, Python 3.6, Python 3.7, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com