[issue40173] test.support.import_fresh_module fails to correctly block submodules when fresh is specified

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue40173] test.support.import_fresh_module fails to correctly block submodules when fresh is specified

Serhiy Storchaka added the comment: _save_and_remove_module in the old code did too much and too little. It tested that the fresh module is importable, saved the current state of the fresh module and its submodules and removed the fresh module and its submodules. Since it tested

[issue40173] test.support.import_fresh_module fails to correctly block submodules when fresh is specified

Serhiy Storchaka added the comment: New changeset f7e99c98130a705f88348dde60adb98d5bfd8b98 by Serhiy Storchaka in branch '3.9': [3.9] bpo-40173: Fix test.support.import_helper.import_fresh_module() (GH-28654) (GH-28658)

[issue40173] test.support.import_fresh_module fails to correctly block submodules when fresh is specified

Serhiy Storchaka added the comment: New changeset 7873884d4730d7e637a968011b8958bd79fd3398 by Serhiy Storchaka in branch '3.10': [3.10] bpo-40173: Fix test.support.import_helper.import_fresh_module() (GH-28654) (GH-28657)

[issue40173] test.support.import_fresh_module fails to correctly block submodules when fresh is specified

Change by Serhiy Storchaka : -- pull_requests: +27024 pull_request: https://github.com/python/cpython/pull/28658 ___ Python tracker ___

[issue40173] test.support.import_fresh_module fails to correctly block submodules when fresh is specified

Change by Serhiy Storchaka : -- pull_requests: +27023 pull_request: https://github.com/python/cpython/pull/28657 ___ Python tracker ___

[issue40173] test.support.import_fresh_module fails to correctly block submodules when fresh is specified

Serhiy Storchaka added the comment: New changeset ec4d917a6a68824f1895f75d113add9410283da7 by Serhiy Storchaka in branch 'main': bpo-40173: Fix test.support.import_helper.import_fresh_module() (GH-28654) https://github.com/python/cpython/commit/ec4d917a6a68824f1895f75d113add9410283da7

[issue40173] test.support.import_fresh_module fails to correctly block submodules when fresh is specified

Change by Serhiy Storchaka : -- pull_requests: +27020 pull_request: https://github.com/python/cpython/pull/28654 ___ Python tracker ___

[issue40173] test.support.import_fresh_module fails to correctly block submodules when fresh is specified

Serhiy Storchaka added the comment: I just encountered this bug after rewriting datetime tests in issue45229. It is also the cause of issue40058. Not knowing about this issue I have wrote different patch than Hai Shi. It makes the code of import_fresh_module() clearer and fixes many other

[issue40173] test.support.import_fresh_module fails to correctly block submodules when fresh is specified

Change by Serhiy Storchaka : -- versions: +Python 3.10, Python 3.11 -Python 3.7, Python 3.8 ___ Python tracker ___ ___

[issue40173] test.support.import_fresh_module fails to correctly block submodules when fresh is specified

hai shi added the comment: > I *think* the problem is that in the step where _save_and_remove_module is > called on fresh_name (see here: > https://github.com/python/cpython/blob/76db37b1d37a9daadd9e5b320f2d5a53cd1352ec/Lib/test/support/__init__.py#L328-L329) Looks like deleting a module

[issue40173] test.support.import_fresh_module fails to correctly block submodules when fresh is specified

Change by hai shi : -- keywords: +patch pull_requests: +18754 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19390 ___ Python tracker ___

[issue40173] test.support.import_fresh_module fails to correctly block submodules when fresh is specified

Change by hai shi : -- nosy: +shihai1991 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40173] test.support.import_fresh_module fails to correctly block submodules when fresh is specified

New submission from Paul Ganssle : It seems that test.support.import_fresh_module gets tripped up with its module blocking when you attempt to get a fresh copy of a submodule of a module where you are also importing the module that you are trying to block (bit of a doozy of a sentence