[issue40174] HAVE_CLOCK_GETTIME not repected in pytime.c

Change by Irit Katriel : -- stage: patch review -> resolved status: pending -> closed ___ Python tracker ___ ___ Python-bugs-list

[issue40174] HAVE_CLOCK_GETTIME not repected in pytime.c

Irit Katriel added the comment: I'll close this in a week if there is no response. (It seems to have been abandoned by the OP after a minor code review disagreement if I understand their last comment.) -- status: open -> pending ___ Python

[issue40174] HAVE_CLOCK_GETTIME not repected in pytime.c

Irit Katriel added the comment: > For my information, is there a kind of committee or someone taking these > kinds of decisions or at least expressing rules as to the spirit in which > they should be made? You can bring this up on the python-ideas mailing list if you want to pull in

[issue40174] HAVE_CLOCK_GETTIME not repected in pytime.c

Change by pmp-p : -- nosy: +pmpp ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40174] HAVE_CLOCK_GETTIME not repected in pytime.c

Jérôme added the comment: Yes, I get your meaning, and I totally agree with it, I was wondering what was the best way to do it, stay close to the cause, which would allow to more easily go along with changes, or put it in the configure file and warn the user as soon as possible... It was

[issue40174] HAVE_CLOCK_GETTIME not repected in pytime.c

Change by Roundup Robot : -- pull_requests: +18748 pull_request: https://github.com/python/cpython/pull/19385 ___ Python tracker ___

[issue40174] HAVE_CLOCK_GETTIME not repected in pytime.c

STINNER Victor added the comment: Usually, what I did to use #error in the C code. Something like: #ifdef MS_WINDOWS ... #elif defined(...) ... #else # error "your platform doesn't support monotonic clock" #endif I dislike relying on configure for that, it's too far from the actual

[issue40174] HAVE_CLOCK_GETTIME not repected in pytime.c

Jérôme added the comment: Hi, I think it is nice to inform the user that clock_gettime is mandatory (just like pthreads, see PR). Can be nice for someone trying to port it to a new platform. "It's no particularly silly, is it?" -- ___ Python

[issue40174] HAVE_CLOCK_GETTIME not repected in pytime.c

Change by Roundup Robot : -- keywords: +patch nosy: +python-dev nosy_count: 3.0 -> 4.0 pull_requests: +18736 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19374 ___ Python tracker

[issue40174] HAVE_CLOCK_GETTIME not repected in pytime.c

STINNER Victor added the comment: Python has a long history (30 years). time.time() had multiple implementations. When I added time.monotonic() in Python 3.3, it was optional. I changed that in Python 3.5: time.monotonic() is now always available.

[issue40174] HAVE_CLOCK_GETTIME not repected in pytime.c

Jérôme added the comment: Hi, OK, I was looking at the wrong line numbers, the problem is still there and as follows. You might call me a perfectionist, but if HAVE_CLOCK_GETTIME is not defined, the function pytime_fromtimespec is taken out by the preprocessor, but still called by the

[issue40174] HAVE_CLOCK_GETTIME not repected in pytime.c

Jérôme added the comment: Hold on, this was the case with Python 3.8.2, but I just checked Github and the code is different! I'll have to check again with HEAD, and sorry if it was fixed! "Drop your panties sir William, I cannot wait till lunchtime". --

[issue40174] HAVE_CLOCK_GETTIME not repected in pytime.c

Change by STINNER Victor : -- nosy: +vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40174] HAVE_CLOCK_GETTIME not repected in pytime.c

Benjamin Peterson added the comment: Does this cause a problem? At this point, it might be preferable to just assume clock_gettime exists on POSIX systems. -- nosy: +benjamin.peterson ___ Python tracker

[issue40174] HAVE_CLOCK_GETTIME not repected in pytime.c

New submission from Jérôme : Hi, In the file Python/pytime.c (line 886 and others), functions and constants that I infer should be declared by HAVE_CLOCK_GETTIME are called without #ifdef. Best regards, Jérôme. -- components: Interpreter Core messages: 365703 nosy: jerome.hamm