[issue40334] PEP 617: new PEG-based parser

[Lysandros Nikolaou]

Lysandros Nikolaou  added the comment:

All parts of the implementation are now in. New issues should be opened for any 
potential bugs.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset a5442b26f46f1073d1eb78895d554be520105ecb by Lysandros Nikolaou in 
branch '3.9':
[3.9] bpo-40334: Produce better error messages on invalid targets (GH-20106) 
(GH-20973)
https://github.com/python/cpython/commit/a5442b26f46f1073d1eb78895d554be520105ecb


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Lysandros Nikolaou]

Change by Lysandros Nikolaou :


--
pull_requests: +20150
pull_request: https://github.com/python/cpython/pull/20973

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 01ece63d42b830df106948db0aefa6c1ba24416a by Lysandros Nikolaou in 
branch 'master':
bpo-40334: Produce better error messages on invalid targets (GH-20106)
https://github.com/python/cpython/commit/01ece63d42b830df106948db0aefa6c1ba24416a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[miss-islington]

miss-islington  added the comment:


New changeset 82c274e3ba7d011e93805f1552e90baea1752cf1 by Miss Islington (bot) 
in branch '3.9':
bpo-40334: Support suppressing of multiple optional variables in Pegen 
(GH-20367)
https://github.com/python/cpython/commit/82c274e3ba7d011e93805f1552e90baea1752cf1


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset cba503151056b448b7a3730dc36ef660ade5 by Batuhan Taskaya in 
branch 'master':
bpo-40334: Support suppressing of multiple optional variables in Pegen 
(GH-20367)
https://github.com/python/cpython/commit/cba503151056b448b7a3730dc36ef660ade5


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[miss-islington]

Change by miss-islington :


--
pull_requests: +19632
pull_request: https://github.com/python/cpython/pull/20368

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Batuhan Taskaya]

Change by Batuhan Taskaya :


--
pull_requests: +19631
pull_request: https://github.com/python/cpython/pull/20367

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[miss-islington]

miss-islington  added the comment:


New changeset 55c89235247d9dbe8a4463c9c64edc7e48826a44 by Miss Islington (bot) 
in branch '3.9':
bpo-40334: Produce better error messages for non-parenthesized genexps 
(GH-20153)
https://github.com/python/cpython/commit/55c89235247d9dbe8a4463c9c64edc7e48826a44


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 10.0 -> 11.0
pull_requests: +19578
pull_request: https://github.com/python/cpython/pull/20307

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset ae145833025b0156ee2a28219e3370f3b27b2a36 by Lysandros Nikolaou in 
branch 'master':
bpo-40334: Produce better error messages for non-parenthesized genexps 
(GH-20153)
https://github.com/python/cpython/commit/ae145833025b0156ee2a28219e3370f3b27b2a36


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset f50516e6a978ee694232512399dd1ab47aaebab1 by Batuhan Taskaya in 
branch 'master':
bpo-40334: Correctly generate C parser when assigned var is None (GH-20296)
https://github.com/python/cpython/commit/f50516e6a978ee694232512399dd1ab47aaebab1


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Batuhan Taskaya]

Change by Batuhan Taskaya :


--
pull_requests: +19571
pull_request: https://github.com/python/cpython/pull/20296

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 75b863aa97016c6813709eb620c43295f84dd51f by Lysandros Nikolaou in 
branch 'master':
bpo-40334: Reproduce error message for type comments on bare '*' in the new 
parser (GH-20151)
https://github.com/python/cpython/commit/75b863aa97016c6813709eb620c43295f84dd51f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Lysandros Nikolaou]

Lysandros Nikolaou  added the comment:

I'm not getting any compiler warnings on macOS (clang) and on Ubuntu (gcc) and 
I can't find any related warnings on the Windows Github Actions logs either. 
Could you maybe post a verbose log of test_peg_generator, Raymond?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Raymond Hettinger]

Raymond Hettinger  added the comment:

One minor nit:  We're getting a nuisance compiler warning:

test_peg_generator passed (2 min 40 sec)
/var/folders/1b/3499qp8s7xv5w0fvjcgl4510gn/T/tmp90rifd5z/parse.c:97:19: 
warning: code will never be executed [-Wunreachable-code]
p->mark = _mark;
  ^
1 warning generated.

--
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Lysandros Nikolaou]

Change by Lysandros Nikolaou :


--
pull_requests: +19456
pull_request: https://github.com/python/cpython/pull/20153

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Lysandros Nikolaou]

Change by Lysandros Nikolaou :


--
pull_requests: +19454
pull_request: https://github.com/python/cpython/pull/20151

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 2c8cd06afe8e0abb52367f85978f19b88e2df53e by Lysandros Nikolaou in 
branch 'master':
bpo-40334: Improvements to error-handling code in the PEG parser (GH-20003)
https://github.com/python/cpython/commit/2c8cd06afe8e0abb52367f85978f19b88e2df53e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Lysandros Nikolaou]

Change by Lysandros Nikolaou :


--
pull_requests: +19413
pull_request: https://github.com/python/cpython/pull/20106

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 16ab07063cb564c1937714bd39d6915172f005b5 by Pablo Galindo in 
branch 'master':
bpo-40334: Correctly identify invalid target in assignment errors (GH-20076)
https://github.com/python/cpython/commit/16ab07063cb564c1937714bd39d6915172f005b5


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
pull_requests: +19382
pull_request: https://github.com/python/cpython/pull/20076

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset a15c9b3a0524e5ca0434d2ad11076677824af941 by Lysandros Nikolaou in 
branch 'master':
bpo-40334: Always show the caret on SyntaxErrors (GH-20050)
https://github.com/python/cpython/commit/a15c9b3a0524e5ca0434d2ad11076677824af941


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Lysandros Nikolaou]

Change by Lysandros Nikolaou :


--
pull_requests: +19359
pull_request: https://github.com/python/cpython/pull/20050

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
pull_requests:  -19349

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Guido van Rossum]

Guido van Rossum  added the comment:


New changeset 27c0d9b54abaa4112d5a317b8aa78b39ad60a808 by Shantanu in branch 
'master':
bpo-40334: produce specialized errors for invalid del targets (GH-19911)
https://github.com/python/cpython/commit/27c0d9b54abaa4112d5a317b8aa78b39ad60a808


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
pull_requests: +19349
pull_request: https://github.com/python/cpython/pull/20039

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Guido van Rossum]

Guido van Rossum  added the comment:

It definitely has its reasons -- there are pernicious edge cases. Probably 
revealed by the tests.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Matthias Bussonnier]

Matthias Bussonnier  added the comment:

Seem to not be in the new parser but simply in codeop in particular `def 
_maybe_compile`

The logic seem weird (but weird logic usually have a reason), it try to compile 
thrice by appending many `\n`.

1) Why do that and not return the first successful compile directly ? I'm not 
sure. 
2) It does compare the repr of error when  compile(source + "\n") and 
compile(source+'\n\n') and only raise if both are identical (which they are not 
in the new parser, they differ by `\n`...)

SyntaxError('invalid syntax', ('', 1, 6, 'def a-b')) 
vs
SyntaxError('invalid syntax', ('', 1, 6, 'def a-b\n'))


This logic seem to go back to the 2000s.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Matthias Bussonnier]

Matthias Bussonnier  added the comment:

Thanks Pablo for replying to my tweet, a couple of other non-failing case in 
https://bugs.python.org/issue40585 that I filled concurrently to your message.

(also using this occasion to thanks all of you for your work on the new parser)

--
nosy: +mbussonn

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

There is some discrepancy with the codeop module when running with the new 
parser:

./python -c "import codeop; codeop.CommandCompiler()('raise = 2\n\n', 
symbol='exec')"

(No error)

./python -Xoldparser -c "import codeop; codeop.CommandCompiler()('raise = 
2\n\n', symbol='exec')"
...
  File "", line 1
raise = 2
  ^
SyntaxError: invalid syntax

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Guido van Rossum]

Guido van Rossum  added the comment:

FWIW I propose that we add another Misc/NEWS for the same issue summarizing 
what happened between alpha6 and beta1. (A lot!)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Guido van Rossum]

Guido van Rossum  added the comment:


New changeset ac7a92cc0a821699df48bc2e30a02c25d6338f78 by Pablo Galindo in 
branch 'master':
bpo-40334: Avoid collisions between parser variables and grammar variables 
(GH-19987)
https://github.com/python/cpython/commit/ac7a92cc0a821699df48bc2e30a02c25d6338f78


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
pull_requests: +19331
pull_request: https://github.com/python/cpython/pull/20020

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Lysandros Nikolaou]

Change by Lysandros Nikolaou :


--
pull_requests: +19315
pull_request: https://github.com/python/cpython/pull/20003

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
pull_requests: +19303
pull_request: https://github.com/python/cpython/pull/19987

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 4638c6429575bd6de26b12b2af5df74d6568b553 by Lysandros Nikolaou in 
branch 'master':
bpo-40334: Error message for invalid default args in function call (GH-19973)
https://github.com/python/cpython/commit/4638c6429575bd6de26b12b2af5df74d6568b553


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 2f37c355ab0e9ec9c1753985d27c41fa0bd719b9 by Lysandros Nikolaou in 
branch 'master':
bpo-40334: Fix error location upon parsing an invalid string literal (GH-19962)
https://github.com/python/cpython/commit/2f37c355ab0e9ec9c1753985d27c41fa0bd719b9


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Lysandros Nikolaou]

Change by Lysandros Nikolaou :


--
pull_requests: +19290
pull_request: https://github.com/python/cpython/pull/19973

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 470aac4d8e76556bd8f820f3f3928dca2b4d2849 by Pablo Galindo in 
branch 'master':
bpo-40334: Generate comments in the parser code to improve debugging (GH-19966)
https://github.com/python/cpython/commit/470aac4d8e76556bd8f820f3f3928dca2b4d2849


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 99db2a1db7a9b468a0ce8377d579f78fa03a2a34 by Pablo Galindo in 
branch 'master':
bpo-40334: Allow trailing comma in parenthesised context managers (GH-19964)
https://github.com/python/cpython/commit/99db2a1db7a9b468a0ce8377d579f78fa03a2a34


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
pull_requests: +19285
pull_request: https://github.com/python/cpython/pull/19969

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
pull_requests: +19281
pull_request: https://github.com/python/cpython/pull/19966

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 999ec9ab6af536cc2666a0847ec02331aaf00416 by Lysandros Nikolaou in 
branch 'master':
bpo-40334: Add type to the assignment rule in the grammar file (GH-19963)
https://github.com/python/cpython/commit/999ec9ab6af536cc2666a0847ec02331aaf00416


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
pull_requests: +19280
pull_request: https://github.com/python/cpython/pull/19964

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Lysandros Nikolaou]

Change by Lysandros Nikolaou :


--
pull_requests: +19279
pull_request: https://github.com/python/cpython/pull/19963

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Lysandros Nikolaou]

Change by Lysandros Nikolaou :


--
pull_requests: +19278
pull_request: https://github.com/python/cpython/pull/19962

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Shantanu]

Change by Shantanu :


--
nosy: +hauntsaninja
nosy_count: 7.0 -> 8.0
pull_requests: +19226
pull_request: https://github.com/python/cpython/pull/19911

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[STINNER Victor]

Change by STINNER Victor :


--
nosy:  -vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Miro Hrončok]

Change by Miro Hrončok :


--
nosy:  -hroncok

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Charalampos Stratakis]

Change by Charalampos Stratakis :


--
nosy:  -cstratak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset e10e7c771bf06112c4a311e0ef6b8af6423b0cca by Lysandros Nikolaou in 
branch 'master':
bpo-40334: Spacialized error message for invalid args after bare '*' (GH-19865)
https://github.com/python/cpython/commit/e10e7c771bf06112c4a311e0ef6b8af6423b0cca


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 7f06af684a1882fdb19d20650825948b1d7996e5 by Lysandros Nikolaou in 
branch 'master':
bpo-40334: Set error_indicator in _PyPegen_raise_error (GH-19887)
https://github.com/python/cpython/commit/7f06af684a1882fdb19d20650825948b1d7996e5


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Lysandros Nikolaou]

Change by Lysandros Nikolaou :


--
pull_requests: +19197
pull_request: https://github.com/python/cpython/pull/19887

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Miro Hrončok]

Miro Hrončok  added the comment:

Ah, sorry, I got it mixed up. Reported there.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Lysandros Nikolaou]

Lysandros Nikolaou  added the comment:

This isn't related to this issue, but to bpo-40246. Please report it there as 
well.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Miro Hrončok]

Miro Hrončok  added the comment:

We also get:

  File "/usr/lib/python3.9/site-packages/dnf/comps.py", line 111
return'.'.join(lcl)
 ^
SyntaxError: invalid string prefix

--
nosy: +hroncok

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Lysandros Nikolaou]

Change by Lysandros Nikolaou :


--
type: resource usage -> enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Lysandros Nikolaou]

Change by Lysandros Nikolaou :


--
pull_requests: +19179
pull_request: https://github.com/python/cpython/pull/19865

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Guido van Rossum]

Guido van Rossum  added the comment:

Easy issue: the Python.gram file still has a comment saying something like

# Simplified grammar

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset d2baff4301387e232495491f7291903cc1217d21 by Pablo Galindo in 
branch 'master':
bpo-40334: regenerate metaparser as part of regen-all (GH-19854)
https://github.com/python/cpython/commit/d2baff4301387e232495491f7291903cc1217d21


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
pull_requests: +19170
pull_request: https://github.com/python/cpython/pull/19854

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 7ba08ff7b41911f972d0750e068a2270e0dbd68f by Pablo Galindo in 
branch 'master':
bpo-40334: use the TOKENS file when checking dangling rules (GH-19849)
https://github.com/python/cpython/commit/7ba08ff7b41911f972d0750e068a2270e0dbd68f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
pull_requests: +19166
pull_request: https://github.com/python/cpython/pull/19849

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 03b7642265e65f198682f22648dbe6cf4fff9835 by Lysandros Nikolaou in 
branch 'master':
bpo-40334: Make the PyPegen* and PyParser* APIs more consistent (GH-19839)
https://github.com/python/cpython/commit/03b7642265e65f198682f22648dbe6cf4fff9835


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 3941d9700b2a272689cb8a8435b5c60a1466ef79 by Guido van Rossum in 
branch 'master':
bpo-40334: Refactor lambda_parameters similar to parameters (GH-19830)
https://github.com/python/cpython/commit/3941d9700b2a272689cb8a8435b5c60a1466ef79


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Lysandros Nikolaou]

Change by Lysandros Nikolaou :


--
pull_requests: +19157
pull_request: https://github.com/python/cpython/pull/19839

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Guido van Rossum]

Guido van Rossum  added the comment:


New changeset d955241469c18c946924dba79c18a9ef200391ad by Pablo Galindo in 
branch 'master':
bpo-40334: Correct return value of func_type_comment (GH-19833)
https://github.com/python/cpython/commit/d955241469c18c946924dba79c18a9ef200391ad


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Guido van Rossum]

Guido van Rossum  added the comment:


New changeset ea7297cf8f1aad4df8921a3d81a75118511afe77 by Pablo Galindo in 
branch 'master':
bpo-40334: unskip test_function_type in test_unparse with the new parser 
(GH-19837)
https://github.com/python/cpython/commit/ea7297cf8f1aad4df8921a3d81a75118511afe77


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
pull_requests: +19155
pull_request: https://github.com/python/cpython/pull/19837

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

> Seems there are more dependencies on wrong tokenizer. Please don't forget to 
> fix this.

Thanks, Serhiy, will submit a PR soon!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 76c1b4d5c5a610c09943e1ee7ae18f1957804730 by Batuhan Taskaya in 
branch 'master':
bpo-40334: Improve column offsets for thrown syntax errors by Pegen (GH-19782)
https://github.com/python/cpython/commit/76c1b4d5c5a610c09943e1ee7ae18f1957804730


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[STINNER Victor]

STINNER Victor  added the comment:

>  Hu, "Lib/test/test_tools/test_c_analyzer/test_parser" has nothing to do 
> with this PR. This looks like Eric Snow's c analyzer for avoiding globals and 
> other stuff for sub interpreters.

Oh sorry. I analyzed dozens of pyflakes warning. When I saw "parser", I 
expected the issue to be new and so introduced by this bpo. Sorry about that ;-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

While PR 19786 makes the PEG generator working on 3.6, it fails on 3.7. Seems 
there are more dependencies on wrong tokenizer. Please don't forget to fix this.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset b796b3fb48283412d3caf52323c69690e5818d3d by Pablo Galindo in 
branch 'master':
bpo-40334: Simplify type handling in the PEG c_generator (GH-19818)
https://github.com/python/cpython/commit/b796b3fb48283412d3caf52323c69690e5818d3d


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
pull_requests: +19152
pull_request: https://github.com/python/cpython/pull/19833

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

> Warnings found by pyflakes:

Hu, "Lib/test/test_tools/test_c_analyzer/test_parser" has nothing to do 
with this PR. This looks like Eric Snow's c analyzer for avoiding globals and 
other stuff for sub interpreters.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Guido van Rossum]

Guido van Rossum  added the comment:


New changeset 3e0a6f37dfdd595be737baae00ec0e036a912615 by Lysandros Nikolaou in 
branch 'master':
bpo-40334: Add support for feature_version in new PEG parser (GH-19827)
https://github.com/python/cpython/commit/3e0a6f37dfdd595be737baae00ec0e036a912615


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Guido van Rossum]

Change by Guido van Rossum :


--
pull_requests: +19150
pull_request: https://github.com/python/cpython/pull/19830

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Guido van Rossum]

Change by Guido van Rossum :


--
pull_requests: +19148
pull_request: https://github.com/python/cpython/pull/19828

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Lysandros Nikolaou]

Change by Lysandros Nikolaou :


--
pull_requests: +19147
pull_request: https://github.com/python/cpython/pull/19827

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[STINNER Victor]

STINNER Victor  added the comment:

Warnings found by pyflakes:

Lib/test/test_tools/test_c_analyzer/test_parser/test_declarations.py:115:31 
undefined name 'lines'
Lib/test/test_tools/test_c_analyzer/test_parser/test_declarations.py:116:25 
undefined name 'lines'
Lib/test/test_tools/test_c_analyzer/test_parser/test_declarations.py:527:42 
undefined name 'stmt'
Lib/test/test_tools/test_c_analyzer/test_parser/test_declarations.py:527:48 
undefined name 'blocks'

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Guido van Rossum]

Guido van Rossum  added the comment:


New changeset c001c09e9059ba04bc088349cd87a1374dc0754f by Guido van Rossum in 
branch 'master':
bpo-40334: Support type comments (GH-19780)
https://github.com/python/cpython/commit/c001c09e9059ba04bc088349cd87a1374dc0754f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
pull_requests: +19138
pull_request: https://github.com/python/cpython/pull/19818

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 69e802ed812e38cb68a4ab74af64b4f719b6cc78 by Lysandros Nikolaou in 
branch 'master':
bpo-40334: Fix test_peg_parser to actually use the old parser (GH-19778)
https://github.com/python/cpython/commit/69e802ed812e38cb68a4ab74af64b4f719b6cc78


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 4db245ee9ddbe6c53d375de59a35ff59dea2a8e0 by Pablo Galindo in 
branch 'master':
bpo-40334: refactor and cleanup for the PEG generators (GH-19775)
https://github.com/python/cpython/commit/4db245ee9ddbe6c53d375de59a35ff59dea2a8e0


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +19109
pull_request: https://github.com/python/cpython/pull/19786

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 6d6508765514c7c10719478a0430f5e47c9a96ac by Lysandros Nikolaou in 
branch 'master':
bpo-40334: Disallow invalid single statements in the new parser (GH-19774)
https://github.com/python/cpython/commit/6d6508765514c7c10719478a0430f5e47c9a96ac


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[STINNER Victor]

Change by STINNER Victor :


--
nosy:  -vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Batuhan Taskaya]

Change by Batuhan Taskaya :


--
pull_requests: +19104
pull_request: https://github.com/python/cpython/pull/19782

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 2208134918ee673451e4fc525bbeab71142d794a by Pablo Galindo in 
branch 'master':
bpo-40334: Explicitly cast to int in pegen.c to fix a compiler warning 
(GH-19779)
https://github.com/python/cpython/commit/2208134918ee673451e4fc525bbeab71142d794a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 37af21b667a9f41437b5b8e451497d7725016df5 by Lysandros Nikolaou in 
branch 'master':
bpo-40334: Fix shifting of nested f-strings in the new parser (GH-19771)
https://github.com/python/cpython/commit/37af21b667a9f41437b5b8e451497d7725016df5


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Guido van Rossum]

Change by Guido van Rossum :


--
pull_requests: +19100
pull_request: https://github.com/python/cpython/pull/19780

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

> The following code works on Python 3.8, but fails with SyntaxError on Python 
> 3.9.0a6 with the old and the new parser (see bpo-40431):


This is not due to the new parser but due to 
https://bugs.python.org/issue40246. Please, report it there as well (you can 
reopen that issue for further discussion).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[STINNER Victor]

STINNER Victor  added the comment:

The following code works on Python 3.8, but fails with SyntaxError on Python 
3.9.0a6 with the old and the new parser (see bpo-40431):

clear = "NORMAL"
print(dict(state=clear, bg="#d00" if clear else"#fca"))

Well, the code looks like a typo error... but it worked previously. Not sure if 
we should keep the SyntaxError or not. Fixing the code is trivial: see PR 19777 
attached to bpo-40431; replace >else"#fca"< with >else "#fca"<.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
pull_requests: +19099
pull_request: https://github.com/python/cpython/pull/19779

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[STINNER Victor]

STINNER Victor  added the comment:

It seems like building Python on Windows 64-bit emits a few warnings:

D:\a\1\s\Parser\pegen\pegen.c(610,91): warning C4267: '=': conversion from 
'size_t' to 'int', possible loss of data [D:\a\1\s\PCbuild\pythoncore.vcxproj]
D:\a\1\s\Parser\pegen\pegen.c(611,52): warning C4267: '=': conversion from 
'size_t' to 'int', possible loss of data [D:\a\1\s\PCbuild\pythoncore.vcxproj]
D:\a\1\s\Parser\pegen\pegen.c(612,103): warning C4267: '=': conversion from 
'size_t' to 'int', possible loss of data [D:\a\1\s\PCbuild\pythoncore.vcxproj]

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

> Pablo: Would you mind to increase ware-gentoo-x86 timeout? Ex: 30 min instead 
> of 15 min.


Done: https://github.com/python/buildmaster-config/pull/190

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Lysandros Nikolaou]

Change by Lysandros Nikolaou :


--
pull_requests: +19098
pull_request: https://github.com/python/cpython/pull/19778

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40334] PEP 617: new PEG-based parser

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
pull_requests: +19095
pull_request: https://github.com/python/cpython/pull/19775

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com