[issue40431] turtledemo/__main__.py: SyntaxError: invalid string prefix else"#fca"

Terry J. Reedy added the comment: I believe the file was synchronized across versions as new features have not recently been added. Backporting the fix to my typo should keep it that way. This is an example of why code review even of patches that 'work' is a good thing. -- nosy:

[issue40431] turtledemo/__main__.py: SyntaxError: invalid string prefix else"#fca"

STINNER Victor added the comment: Ok, the typo is now fixed in 3.7, 3.8 and master branches ;-) Thanks Miro for the bug reportand Kyle for the backport. -- ___ Python tracker

[issue40431] turtledemo/__main__.py: SyntaxError: invalid string prefix else"#fca"

miss-islington added the comment: New changeset adb1f853482e75e81ae0ae7307318a1051ca46b5 by Miss Islington (bot) in branch '3.7': [3.8] bpo-40431: Fix syntax typo in turtledemo (GH-19777) (GH-19784) https://github.com/python/cpython/commit/adb1f853482e75e81ae0ae7307318a1051ca46b5

[issue40431] turtledemo/__main__.py: SyntaxError: invalid string prefix else"#fca"

Change by miss-islington : -- nosy: +miss-islington nosy_count: 4.0 -> 5.0 pull_requests: +19112 pull_request: https://github.com/python/cpython/pull/19789 ___ Python tracker

[issue40431] turtledemo/__main__.py: SyntaxError: invalid string prefix else"#fca"

Change by Kyle Stanley : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue40431] turtledemo/__main__.py: SyntaxError: invalid string prefix else"#fca"

Kyle Stanley added the comment: New changeset cc011b5190b63f0be561ddec38fc4cd9e60cbf6a by Kyle Stanley in branch '3.8': [3.8] bpo-40431: Fix syntax typo in turtledemo (GH-19777) (#19784) https://github.com/python/cpython/commit/cc011b5190b63f0be561ddec38fc4cd9e60cbf6a --

[issue40431] turtledemo/__main__.py: SyntaxError: invalid string prefix else"#fca"

Change by Kyle Stanley : -- pull_requests: +19107 pull_request: https://github.com/python/cpython/pull/19784 ___ Python tracker ___

[issue40431] turtledemo/__main__.py: SyntaxError: invalid string prefix else"#fca"

Change by Kyle Stanley : -- versions: -Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40431] turtledemo/__main__.py: SyntaxError: invalid string prefix else"#fca"

Kyle Stanley added the comment: Victor Stinner wrote: > If you backport the change, please remove the NEWS entry, since it's not a > SyntaxError in 3.7 and 3.8. Good point. In that case, I'll do a manual backport of the PR just to 3.8 and skip the news entry. As mentioned above, I think

[issue40431] turtledemo/__main__.py: SyntaxError: invalid string prefix else"#fca"

STINNER Victor added the comment: If you backport the change, please remove the NEWS entry, since it's not a SyntaxError in 3.7 and 3.8. -- ___ Python tracker ___

[issue40431] turtledemo/__main__.py: SyntaxError: invalid string prefix else"#fca"

Kyle Stanley added the comment: > I don't think that it's worth it to backport the change to 3.7 and 3.8: in > Python 3.7 and 3.8, the code is accepted. > Python 3.7 and 3.8 are not broken, so there is no need to fix them :-) I think we could very reasonably change `else"#fca"` -> `else

[issue40431] turtledemo/__main__.py: SyntaxError: invalid string prefix else"#fca"

STINNER Victor added the comment: > I am OK. I don't see why not to backport it, but I don't care much. Python 3.7 and 3.8 are not broken, so there is no need to fix them :-) Thanks for the fix. I reported the issue to: https://bugs.python.org/issue40246#msg367587 -- resolution:

[issue40431] turtledemo/__main__.py: SyntaxError: invalid string prefix else"#fca"

Miro Hrončok added the comment: I am OK. I don't see why not to backport it, but I don't care much. -- ___ Python tracker ___ ___

[issue40431] turtledemo/__main__.py: SyntaxError: invalid string prefix else"#fca"

STINNER Victor added the comment: I don't think that it's worth it to backport the change to 3.7 and 3.8: in Python 3.7 and 3.8, the code is accepted. I also reported the issue to: https://bugs.python.org/issue40334#msg367580 Miro: are you ok to close the issue (not backport)? --

[issue40431] turtledemo/__main__.py: SyntaxError: invalid string prefix else"#fca"

STINNER Victor added the comment: New changeset 49f70db83e2c62ad06805927f53f6c3e8f4b798e by Miro Hrončok in branch 'master': bpo-40431: Fix syntax typo in turtledemo (GH-19777) https://github.com/python/cpython/commit/49f70db83e2c62ad06805927f53f6c3e8f4b798e --

[issue40431] turtledemo/__main__.py: SyntaxError: invalid string prefix else"#fca"

Change by Miro Hrončok : -- keywords: +patch pull_requests: +19097 stage: -> patch review pull_request: https://github.com/python/cpython/pull/19777 ___ Python tracker ___

[issue40431] turtledemo/__main__.py: SyntaxError: invalid string prefix else"#fca"

New submission from Miro Hrončok : With Python 3.9.0a6 we get the following syntax error when bytecompiling the standard library in Fedora: Compiling '/usr/lib64/python3.9/turtledemo/__main__.py'... *** File "/usr/lib64/python3.9/turtledemo/__main__.py", line 275 bg="#d00" if clear ==