[issue40432] Pegen regenerate project for Windows not working

[Steve Dower]

Change by Steve Dower :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40432] Pegen regenerate project for Windows not working

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset f65f3f0e99b27e0a4ea6bb7e30c5bdb5832a76c6 by Miss Islington (bot) 
in branch '3.9':
bpo-40432: Use python 3.8 or higher to compile CPython on Windows (GH-25389) 
(#25637)
https://github.com/python/cpython/commit/f65f3f0e99b27e0a4ea6bb7e30c5bdb5832a76c6


--
nosy: +lukasz.langa

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40432] Pegen regenerate project for Windows not working

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 8.0 -> 9.0
pull_requests: +24332
pull_request: https://github.com/python/cpython/pull/25637

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40432] Pegen regenerate project for Windows not working

[Steve Dower]

Steve Dower  added the comment:


New changeset 425434dadc30d96dc1c0c628f954f9b6f5edd2c9 by Ken Jin in branch 
'master':
bpo-40432: Use python 3.8 or higher to compile CPython on Windows (#25389)
https://github.com/python/cpython/commit/425434dadc30d96dc1c0c628f954f9b6f5edd2c9


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40432] Pegen regenerate project for Windows not working

[Steve Dower]

Steve Dower  added the comment:

Thanks for the PR, kj! Left a suggestion for you, but otherwise it should solve 
the problem nicely.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40432] Pegen regenerate project for Windows not working

[Steve Dower]

Steve Dower  added the comment:

That'll be a change to PCbuild/find_python.bat that needs to be backported 
then. It probably defaults to 3.7 in all branches right now, but since 3.9 is 
out we can update them all to that (it downloads on demand if necessary).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40432] Pegen regenerate project for Windows not working

[Jeremy Kloth]

Jeremy Kloth  added the comment:

Adding windows team to the nosy list

--
components: +Windows
nosy: +jkloth, paul.moore, steve.dower, tim.golden, zach.ware

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40432] Pegen regenerate project for Windows not working

[Ken Jin]

Change by Ken Jin :


--
nosy: +kj
nosy_count: 2.0 -> 3.0
pull_requests: +24122
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/25389

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40432] Pegen regenerate project for Windows not working

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

Seems that the regeneration script is not detecting correctly that needs 
Python3.8+ for regenerating pegen. Check for instance:

https://buildbot.python.org/all/#/builders/596/builds/2/steps/2/logs/stdio

--
resolution: fixed -> 
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40432] Pegen regenerate project for Windows not working

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40432] Pegen regenerate project for Windows not working

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 9b64ef3ac7b434065dbff0048b9103999e4b491a by Anthony Shaw in 
branch 'master':
bpo-40432 Fix MSBuild project for Pegen grammars (#GH-9785)
https://github.com/python/cpython/commit/9b64ef3ac7b434065dbff0048b9103999e4b491a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40432] Pegen regenerate project for Windows not working

[anthony shaw]

Change by anthony shaw :


--
keywords: +patch
pull_requests: +19108
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/19785

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40432] Pegen regenerate project for Windows not working

[anthony shaw]

New submission from anthony shaw :

The additional tasks in the MSBuild project for pegen regeneration are not 
functional:

- Setting PYTHONPATH= inline cannot be done in Windows using that method
- The task does not inherit environment variables that way
- The path to the peg_generator module is in Unix path format

PR to follow

--
assignee: anthonypjshaw
components: Build
messages: 367613
nosy: anthonypjshaw, pablogsal
priority: normal
severity: normal
status: open
title: Pegen regenerate project for Windows not working
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com