[issue40865] Remove unused insint() macro in SHA512 module

[Erlend Egeberg Aasland]

Erlend Egeberg Aasland  added the comment:

Indeed. I'll update the PR and the title of this issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40865] Remove unused insint() macro in SHA512 module

[Christian Heimes]

Christian Heimes  added the comment:

The other builtin hashes have the same unused macro.

$ grep -R insint Modules/*.c
Modules/md5module.c:#define insint(n,v) { PyModule_AddIntConstant(m,n,v); }
Modules/sha1module.c:#define insint(n,v) { PyModule_AddIntConstant(m,n,v); }
Modules/sha256module.c:#define insint(n,v) { PyModule_AddIntConstant(m,n,v); }
Modules/sha512module.c:#define insint(n,v) { PyModule_AddIntConstant(m,n,v); }

--
components: +Extension Modules -Library (Lib)
nosy: +christian.heimes
type:  -> behavior
versions:  -Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40865] Remove unused insint() macro in SHA512 module

[Erlend Egeberg Aasland]

Change by Erlend Egeberg Aasland :


--
keywords: +patch
pull_requests: +19852
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/20627

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue40865] Remove unused insint() macro in SHA512 module

[Erlend Egeberg Aasland]

New submission from Erlend Egeberg Aasland :

The insint() macro in line 741 is unused and can be removed.

--
components: Library (Lib)
messages: 370723
nosy: erlendaasland
priority: normal
severity: normal
status: open
title: Remove unused insint() macro in SHA512 module
versions: Python 3.10, Python 3.7, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com