[issue41086] Exception for uninstantiated interpolation (configparser)

[Łukasz Langa]

Change by Łukasz Langa :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41086] Exception for uninstantiated interpolation (configparser)

[Łukasz Langa]

Łukasz Langa  added the comment:

It's a behavioral change that tightens acceptable objects passed to 
`interpolation=`. In the past any object that provided the same interface as 
`Interpolation` instances would be accepted. No longer.

I think this is an acceptable compromise but it's definitely outside of the 
realm of backporting.

Thanks for your contribution, Brian! ✨  ✨

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41086] Exception for uninstantiated interpolation (configparser)

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset fc115c9bde52a58b4fb9be2b80c3d6be8a4d2454 by Brian Faherty in 
branch 'main':
bpo-41086: Add exception for uninstantiated interpolation (configparser) 
(GH-21062)
https://github.com/python/cpython/commit/fc115c9bde52a58b4fb9be2b80c3d6be8a4d2454


--
nosy: +lukasz.langa

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41086] Exception for uninstantiated interpolation (configparser)

[Irit Katriel]

Irit Katriel  added the comment:

This is not a bugfix so it should probably not be backported.

--
nosy: +iritkatriel
type: behavior -> enhancement
versions: +Python 3.11 -Python 3.10, Python 3.5, Python 3.6, Python 3.7, Python 
3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41086] Exception for uninstantiated interpolation (configparser)

[Roundup Robot]

Change by Roundup Robot :


--
keywords: +patch
nosy: +python-dev
nosy_count: 1.0 -> 2.0
pull_requests: +20233
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/21062

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue41086] Exception for uninstantiated interpolation (configparser)

[Brian Faherty]

New submission from Brian Faherty :

The ConfigParser in Lib has a parameter called `interpolation`, that expects an 
instance of a subclass of Interpolation. However, when ConfigParser is given an 
argument of an uninstantiated subclass of Interpolation, the __init__ function 
of ConfigParser accepts it and continues on. This results in a later receiving 
an error message along the lines of `TypeError: before_set()
missing 1 required positional argument: 'value'` when functions are later 
called on the ConfigParser instance. This delay between the feedback and the 
original mistake has led to a few bugs open on the issue tracker 
(https://bugs.python.org/issue26831 and https://bugs.python.org/issue26469. 
Both of which were closed after a quick and simple explanation, which can be 
easily implemented in the library itself. 

I've created a PR for this work and will attach it shortly. Please let me know 
if there is a better name for the exception other than 
`InterpolationIsNotInstantiatedError`. It seems long, but also in line with the 
other Errors already in configparser.

--
components: Library (Lib)
messages: 372137
nosy: Brian Faherty
priority: normal
severity: normal
status: open
title: Exception for uninstantiated interpolation (configparser)
type: behavior
versions: Python 3.10, Python 3.5, Python 3.6, Python 3.7, Python 3.8, Python 
3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com