[issue41371] test_zoneinfo fails when lzma module is unavailable

Karthikeyan Singaravelan added the comment: Thanks @doodspav for the report and Thanks nathan for the patch. This somehow missed 3.9.0 but will be available in 3.9.1. I am closing the issue. Feel free to reopen this or a new issue to implement suggestions by Paul in msg374822. --

[issue41371] test_zoneinfo fails when lzma module is unavailable

Karthikeyan Singaravelan added the comment: New changeset 20bdeedfb4ebd250dad9834c96cb858d83c896cb by Karthikeyan Singaravelan in branch '3.9': [3.9] bpo-41371: Handle lzma lib import error in test_zoneinfo.py (GH-21734) (GH-22039)

[issue41371] test_zoneinfo fails when lzma module is unavailable

Change by Karthikeyan Singaravelan : -- pull_requests: +21136 pull_request: https://github.com/python/cpython/pull/22039 ___ Python tracker ___

[issue41371] test_zoneinfo fails when lzma module is unavailable

miss-islington added the comment: New changeset 5f0769a7529fcbc28190864f098f192053a10747 by Nathan M in branch 'master': bpo-41371: Handle lzma lib import error in test_zoneinfo.py (GH-21734) https://github.com/python/cpython/commit/5f0769a7529fcbc28190864f098f192053a10747 -- nosy:

[issue41371] test_zoneinfo fails when lzma module is unavailable

Change by miss-islington : -- pull_requests: +20903 pull_request: https://github.com/python/cpython/pull/21758 ___ Python tracker ___

[issue41371] test_zoneinfo fails when lzma module is unavailable

Nathan Maynes added the comment: Im still trying to get the hang of the PR workflow so my apologies in advance. I closed the first PR by accident. I made the mistake of including a commit for another issue as well as the commit for this issue. When trying to clean up, I reverted back too

[issue41371] test_zoneinfo fails when lzma module is unavailable

Change by Nathan Maynes : -- pull_requests: +20879 pull_request: https://github.com/python/cpython/pull/21734 ___ Python tracker ___

[issue41371] test_zoneinfo fails when lzma module is unavailable

Paul Ganssle added the comment: I think for now skipping the tests when lzma is missing is the easiest thing, though another option would be to drop the compression on the input test data so that the tests don't depend on lzma. Taking a look at the data files, it looks like we get around

[issue41371] test_zoneinfo fails when lzma module is unavailable

Change by Nathan Maynes : -- keywords: +patch pull_requests: +20874 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21730 ___ Python tracker ___

[issue41371] test_zoneinfo fails when lzma module is unavailable

Nathan Maynes added the comment: I'm creating a pull request that implements the suggestion by xtreak. -- nosy: +nmaynes ___ Python tracker ___

[issue41371] test_zoneinfo fails when lzma module is unavailable

Change by Karthikeyan Singaravelan : -- title: test_zoneinfo fails -> test_zoneinfo fails when lzma module is unavailable ___ Python tracker ___