[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Steve Dower added the comment: I closed the PR. Jason's fix deals with it, so this is now resolved. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Paul Moore added the comment: That's specifically the ensurepip PR, which is now outdated since pip 21.0.1 is in master. But for this bug report, Steve said "I still consider the changes a release blocking regression, but if it's not blocking ensurepip then I guess the updated packages can

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Paul Moore added the comment: It can be closed. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Pablo Galindo Salgado added the comment: Do we need to wait for PR 22779 or can it be closed? -- ___ Python tracker ___ ___

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Paul Moore added the comment: I'm not sure why, but the PR to update the bundled pip to 21.0.1 (and setuptools to 52.0.0) merged cleanly, so this may be obsolete now. -- ___ Python tracker

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Pablo Galindo Salgado added the comment: Friendly reminder that this issue is currently blocking the 3.10a5 release. If you are ok with waiting for the next release to include the fix, please say so here or drop me an email/ -- ___ Python tracker

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Jason R. Coombs added the comment: > Why do we keep setuptools? I agree; would be good to remove it if possible. There are many packages that fail to build without Setuptools being present or --use-pep517 indicated. It would be nice if pip could make --use-pep517 the default, update that

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Julien Palard added the comment: Question: Why do we keep setuptools? According to PEP453: > Once pip is able to run pip install --upgrade pip without needing setuptools > installed first, then the private copy of setuptools will be removed from > ensurepip in subsequent CPython releases.

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Change by Brett Cannon : -- nosy: -brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Jason R. Coombs added the comment: New changeset df8d4c83a6e1727e766191896aeabde886979587 by Jason R. Coombs in branch 'master': bpo-41490: ``path`` and ``contents`` to aggressively close handles (#22915) https://github.com/python/cpython/commit/df8d4c83a6e1727e766191896aeabde886979587

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Change by Jason R. Coombs : -- pull_requests: +21845 pull_request: https://github.com/python/cpython/pull/22915 ___ Python tracker ___

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Steve Dower added the comment: I did some bad things in git and so I had to recreate the PR against master, but the importlib.resources tests still fail. Seems like the ensurepip/venv tests are fine though? Did something change in pip/certifi between 20.2.1 and 20.2.3? I still consider the

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Change by Steve Dower : -- pull_requests: +21738 pull_request: https://github.com/python/cpython/pull/22779 ___ Python tracker ___

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

STINNER Victor added the comment: setuptools is still more recent in 3.9 than in master. Look at PR 21748. Can someone try to update setuptools in master? -- ___ Python tracker

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Steve Dower added the comment: I have no objection to bumping it further, provided someone has fixed importlib.resources on 3.10 (i.e. my backported tests pass) -- ___ Python tracker

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Łukasz Langa added the comment: New changeset 168a8383c8358eea1b34df0e832f5d652faa6444 by Łukasz Langa (Pablo Galindo) in branch '3.9': [3.9] bpo-41490: Bump vendored pip to version 20.2.3 (GH-22527). (GH-22544) https://github.com/python/cpython/commit/168a8383c8358eea1b34df0e832f5d652faa6444

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Pablo Galindo Salgado added the comment: Yeah, there is some code in PR 21748 that should be merged (the new test). -- ___ Python tracker ___

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

STINNER Victor added the comment: Can this issue be closed? Are we waiting for manual checks? Or is there any remaining thing to do? -- ___ Python tracker ___

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Łukasz Langa added the comment: This change goes into 3.9.0 with Pablo's fix. -- ___ Python tracker ___ ___ Python-bugs-list

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Łukasz Langa added the comment: New changeset 4b4d60f9287e0e52c2569876456f40efc11529b4 by Pablo Galindo in branch '3.9': [3.9] bpo-41490: Bump vendored pip to version 20.2.3 (GH-22527). (GH-22544) https://github.com/python/cpython/commit/4b4d60f9287e0e52c2569876456f40efc11529b4 --

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Łukasz Langa added the comment: New changeset 28cd96f2e5cfb16566a75dca8473b71889746f10 by Pablo Galindo in branch '3.8': [3.8] bpo-41490: Bump vendored pip to version 20.2.3 (GH-22527). (GH-22545) https://github.com/python/cpython/commit/28cd96f2e5cfb16566a75dca8473b71889746f10 --

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Change by Pablo Galindo Salgado : -- pull_requests: +21546 pull_request: https://github.com/python/cpython/pull/22545 ___ Python tracker ___

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Change by Pablo Galindo Salgado : -- pull_requests: +21545 pull_request: https://github.com/python/cpython/pull/22544 ___ Python tracker ___

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Łukasz Langa added the comment: New changeset 2cc6dc9896771ef3615abbb5ba80939a2f644a08 by Pablo Galindo in branch 'master': bpo-41490: Bump vendored pip to version 20.2.3 (#22527) https://github.com/python/cpython/commit/2cc6dc9896771ef3615abbb5ba80939a2f644a08 --

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Change by Pablo Galindo Salgado : -- pull_requests: +21532 pull_request: https://github.com/python/cpython/pull/22527 ___ Python tracker ___

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Pradyun Gedam added the comment: +1 for bumping to 20.2.3, in case an upstream voice is helpful. :) On Fri, Oct 2, 2020 at 8:12 PM Pablo Galindo Salgado wrote: > > Pablo Galindo Salgado added the comment: > > I think that the backport to 3.8 may have some unintended consequences in > the

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Pablo Galindo Salgado added the comment: I think that the backport to 3.8 may have some unintended consequences in the last patch release as venv created with 3.8 now exhibit the pip regression (https://github.com/pypa/pip/issues/8695.). Steve, would you be ok if we bump all branches

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

László Kiss Kollár added the comment: pip 20.2.1 contains a regression which breaks `--system-site-package` integration: https://github.com/pypa/pip/issues/8695. It would be nice to include the latest patch version (20.2.3 at the moment) which fixes this and a few other issues. --

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Steve Dower added the comment: If you look at the PR into 3.9, it includes a test for this exact case. Start by copying that into 3.10 and then make it pass and everything should be good :) -- ___ Python tracker

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Paul Moore added the comment: I think this reproduces the underlying issue: >>> import zipfile >>> from pathlib import Path >>> p = zipfile.Path("tst.zip") >>> Path("tst.zip").unlink() Traceback (most recent call last): File "", line 1, in File

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Jason R. Coombs added the comment: > I haven't yet figured out whether there's a convenient way for the reader to > not keep the ZIP open for as long as it exists, but I think that's going to > be the safest fix. You may be right here. I don't fully understand the repro, but it seems to me

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

STINNER Victor added the comment: The CI failed on the PR on the master branch: https://github.com/python/cpython/pull/21748 First, the Travis CI job didn't start. I closed/opened the issue: Travis CI ran. New issue: bpo-41762. Once bpo-41762 will be fixed, it should be possible to attempt

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Change by Steve Dower : -- versions: -Python 3.9 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Steve Dower added the comment: New changeset 70e9243a55be9c32b41f2149cdfa3957f96f8471 by Steve Dower in branch '3.9': bpo-41490: Update ensurepip to install pip 20.2.1 and setuptools 49.2.1 (GH-21774) https://github.com/python/cpython/commit/70e9243a55be9c32b41f2149cdfa3957f96f8471

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Change by Steve Dower : -- versions: -Python 3.8 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Steve Dower added the comment: New changeset 135de08128a76f49752ac57c316129500275e828 by Steve Dower in branch '3.8': bpo-41490: Update ensurepip to install pip 20.2.1 and setuptools 49.2.1 (GH-21775) https://github.com/python/cpython/commit/135de08128a76f49752ac57c316129500275e828

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Steve Dower added the comment: GitHub Actions has decided not to run CI today, so you'll have to look at Azure Pipelines for the test failures:

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Change by Steve Dower : -- pull_requests: +20920 pull_request: https://github.com/python/cpython/pull/21775 ___ Python tracker ___

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Change by Steve Dower : -- pull_requests: +20919 pull_request: https://github.com/python/cpython/pull/21774 ___ Python tracker ___

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Steve Dower added the comment: Added some test cases to the PR that directly trigger the issue, specifically this one: def test_entered_path_does_not_keep_open(self): # This is what certifi does on import to make its bundle # available for the process duration. c

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Steve Dower added the comment: Okay, I've tracked it down to the new importlib.readers.ZipReader class keeping the zip file open, presumably until it gets GC'd. This is used by certifi to extract the CA certs from the whl when ensurepip is doing the self-install from the mounted wheel.

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Steve Dower added the comment: The issue above doesn't appear to repro on 3.9, so I guess master has started leaking a file handle, presumably in zipimport. I'll see what I can track down, but can't be sure I'll have enough time to get it done for RC, so if anyone else wants to help out

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Steve Dower added the comment: Test failure on Windows. I'll take a look tomorrow. == FAIL: test_with_pip (test.test_venv.EnsurePipTest) -- Traceback (most

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

Change by Steve Dower : -- keywords: +patch pull_requests: +20892 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/21748 ___ Python tracker

[issue41490] Update bundled pip to 20.2.1 and setuptools to 49.2.1

New submission from Steve Dower : I'm doing the PR now, based on the latest versions available today: https://pypi.org/project/pip/20.2.1/ https://pypi.org/project/setuptools/49.2.1/ If you're a maintainer and there's a reason to not update to to the latest, please let me know asap. All of