[issue42257] platform.libc_ver() doesn't consider in case of executable is empty string

[Marc-Andre Lemburg]

Marc-Andre Lemburg  added the comment:

Note: I did not request a backport, since this really is a new feature.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42257] platform.libc_ver() doesn't consider in case of executable is empty string

[Marc-Andre Lemburg]

Marc-Andre Lemburg  added the comment:

https://github.com/python/cpython/pull/23140 merged. Thanks for the patch, 
Kurochan.

--
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42257] platform.libc_ver() doesn't consider in case of executable is empty string

[Marc-Andre Lemburg]

Marc-Andre Lemburg  added the comment:

Thanks for the patch.

Merging is currently prevented by an unrelated test for nntplib failing. See 
e.g. 
https://github.com/python/cpython/pull/23140/checks?check_run_id=1630509357. 
This is being tracked in https://bugs.python.org/issue42794

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42257] platform.libc_ver() doesn't consider in case of executable is empty string

[Kurochan]

Kurochan  added the comment:

Also, PR comment processed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42257] platform.libc_ver() doesn't consider in case of executable is empty string

[Kurochan]

Kurochan  added the comment:

> If Python is embedded

Yes. It's embedded Python.
This issue caused in datadog-agent with embedded Python.
https://github.com/DataDog/datadog-agent/

>  would it be possible to share the code used to configure Python 
> initialization?
I'm not sure where the Python installation code is. Maybe it's around here.
https://github.com/DataDog/datadog-agent/blob/master/docs/dev/agent_omnibus.md

https://github.com/DataDog/datadog-agent/blob/master/omnibus/config/software/python3.rb

datadog-agent's official install script is here.
https://s3.amazonaws.com/dd-agent/scripts/install_script.sh

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42257] platform.libc_ver() doesn't consider in case of executable is empty string

[STINNER Victor]

STINNER Victor  added the comment:

> Currently, `platform.libc_ver()` doesn't consider in case of `executable` 
> variable is an empty string.

I'm curious. In which case sys.executable is an empty string? Do you embed 
Python in an application. If Python is embedded, would it be possible to share 
the code used to configure Python initialization?

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42257] platform.libc_ver() doesn't consider in case of executable is empty string

[Marc-Andre Lemburg]

Marc-Andre Lemburg  added the comment:

Reviewed. Please check on the PR for comments.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42257] platform.libc_ver() doesn't consider in case of executable is empty string

[Ned Deily]

Change by Ned Deily :


--
nosy: +lemburg

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42257] platform.libc_ver() doesn't consider in case of executable is empty string

[Kurochan]

Kurochan  added the comment:

Can anyone review this PR?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42257] platform.libc_ver() doesn't consider in case of executable is empty string

[Kurochan]

Change by Kurochan :


--
keywords: +patch
pull_requests: +22053
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/23140

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42257] platform.libc_ver() doesn't consider in case of executable is empty string

[Kurochan]

New submission from Kurochan :

Currently, `platform.libc_ver()` doesn't consider in case of `executable` 
variable is an empty string.
However, with Python 3.8, the following code could pass an empty string 
`executable` to the `platform.libc_ver()` function.

https://github.com/python/cpython/blob/efc782d29e229924076ffb6645a72f26242fb3ef/Lib/platform.py#L1205
https://docs.python.org/3/library/sys.html#sys.executable

Because the `sys.executable` could return an empty string, so I would like to 
add the empty string handler.

https://github.com/python/cpython/blob/efc782d29e229924076ffb6645a72f26242fb3ef/Lib/platform.py#L174

Or please also merge the following PR to Python 3.8.
https://github.com/python/cpython/pull/14418

--
components: Library (Lib)
messages: 380311
nosy: kurochan
priority: normal
severity: normal
status: open
title: platform.libc_ver() doesn't consider in case of executable is empty 
string
type: behavior
versions: Python 3.10, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com