[issue42328] ttk style.map function incorrectly handles the default state for element options.

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10, Python 3.9 ___ Python tracker ___

[issue42328] ttk style.map function incorrectly handles the default state for element options.

miss-islington added the comment: New changeset ae67db6b314e297a1b67ed15c0bb560b8ce5b856 by Miss Islington (bot) in branch '3.9': bpo-42328: Skip some tests with themes vista and xpnative on Windows 7 (GH-23612)

[issue42328] ttk style.map function incorrectly handles the default state for element options.

miss-islington added the comment: New changeset 12d2306a1db48f71b15ceaecf3d5ce06dbbe06c1 by Miss Islington (bot) in branch '3.8': bpo-42328: Skip some tests with themes vista and xpnative on Windows 7 (GH-23612)

[issue42328] ttk style.map function incorrectly handles the default state for element options.

Change by miss-islington : -- pull_requests: +22492 pull_request: https://github.com/python/cpython/pull/23624 ___ Python tracker ___

[issue42328] ttk style.map function incorrectly handles the default state for element options.

Change by miss-islington : -- pull_requests: +22493 pull_request: https://github.com/python/cpython/pull/23625 ___ Python tracker ___

[issue42328] ttk style.map function incorrectly handles the default state for element options.

Serhiy Storchaka added the comment: New changeset f3c3ea91a76526edff928c95b9c6767e077b7448 by Serhiy Storchaka in branch 'master': bpo-42328: Skip some tests with themes vista and xpnative on Windows 7 (GH-23612)

[issue42328] ttk style.map function incorrectly handles the default state for element options.

Serhiy Storchaka added the comment: Thank you for your report David. I have not Windows 7 and does not know how to reproduce this on Windows 10 so will just skip tests for specific themes on Windows 7. -- ___ Python tracker

[issue42328] ttk style.map function incorrectly handles the default state for element options.

Change by Serhiy Storchaka : -- pull_requests: +22479 pull_request: https://github.com/python/cpython/pull/23612 ___ Python tracker ___

[issue42328] ttk style.map function incorrectly handles the default state for element options.

David Bolen added the comment: This change to the 3.8 branch appears to be consistently failing on the Windows 7 buildbot (first failing build at https://buildbot.python.org/all/#/builders/270/builds/126). It's all failures in the new test_configure_custom_copy and test_map_custom_copy

[issue42328] ttk style.map function incorrectly handles the default state for element options.

miss-islington added the comment: New changeset 3e5330130810e485f1abbf192590b7109880a4da by Miss Islington (bot) in branch '3.9': bpo-42328: Fix tkinter.ttk.Style.map(). (GH-23300) https://github.com/python/cpython/commit/3e5330130810e485f1abbf192590b7109880a4da --

[issue42328] ttk style.map function incorrectly handles the default state for element options.

miss-islington added the comment: New changeset ad49526c80fedf7469bd65b44d8021bab5fb998b by Miss Islington (bot) in branch '3.8': bpo-42328: Fix tkinter.ttk.Style.map(). (GH-23300) https://github.com/python/cpython/commit/ad49526c80fedf7469bd65b44d8021bab5fb998b --

[issue42328] ttk style.map function incorrectly handles the default state for element options.

Change by miss-islington : -- pull_requests: +22361 pull_request: https://github.com/python/cpython/pull/23471 ___ Python tracker ___

[issue42328] ttk style.map function incorrectly handles the default state for element options.

Serhiy Storchaka added the comment: New changeset dd844a2916fb3a8f481ec7c732802c13c3375691 by Serhiy Storchaka in branch 'master': bpo-42328: Fix tkinter.ttk.Style.map(). (GH-23300) https://github.com/python/cpython/commit/dd844a2916fb3a8f481ec7c732802c13c3375691 --

[issue42328] ttk style.map function incorrectly handles the default state for element options.

Change by miss-islington : -- nosy: +miss-islington nosy_count: 4.0 -> 5.0 pull_requests: +22360 pull_request: https://github.com/python/cpython/pull/23470 ___ Python tracker

[issue42328] ttk style.map function incorrectly handles the default state for element options.

Change by Serhiy Storchaka : -- pull_requests: +22191 pull_request: https://github.com/python/cpython/pull/23300 ___ Python tracker ___

[issue42328] ttk style.map function incorrectly handles the default state for element options.

Serhiy Storchaka added the comment: Thank you for your examples Pat. Now it looks clearer to me. Semantically this data in Tk is a sequence of pairs: states (which can be a single word or several words or empty) and default value. >>> from tkinter import ttk >>> style = ttk.Style() >>>

[issue42328] ttk style.map function incorrectly handles the default state for element options.

Terry J. Reedy added the comment: Verified Traceback (most recent call last): File "F:\Python\a\tem4.py", line 5, in style.map('Custom.TNotebook.Tab', **style.map('TNotebook.Tab')) File "C:\Program Files\Python310\lib\tkinter\ttk.py", line 403, in map self.tk.call(self._name,

[issue42328] ttk style.map function incorrectly handles the default state for element options.

Pat Thoyts added the comment: So if you look at the clamTheme.tcl file you can see the definition of the map for the TNotebook.Tab style looks like the following: ttk::style map TNotebook.Tab \ -padding [list selected {6 4 6 2}] \ -background [list selected $colors(-frame) {}

[issue42328] ttk style.map function incorrectly handles the default state for element options.

Serhiy Storchaka added the comment: Sorry, I did not understand how did you get an empty state? Could you please provide complete reproducible example? -- ___ Python tracker

[issue42328] ttk style.map function incorrectly handles the default state for element options.

Terry J. Reedy added the comment: You have 2 user names, both nosy. You logged in with the lower-case name, hence the Author listing above. However, your CLA was registered with your uppercase (older?) login name. (If this is not what you intended, please write ewa at ython.org and

[issue42328] ttk style.map function incorrectly handles the default state for element options.

Change by Terry J. Reedy : -- nosy: +serhiy.storchaka, terry.reedy ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue42328] ttk style.map function incorrectly handles the default state for element options.

Change by Pat Thoyts : -- keywords: +patch nosy: +Pat Thoyts nosy_count: 1.0 -> 2.0 pull_requests: +22138 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23241 ___ Python tracker

[issue42328] ttk style.map function incorrectly handles the default state for element options.

New submission from Pat Thoyts : When cloning a ttk style it is useful to copy an existing style and make changes. We can copy the configuration and layout using: style.layout('Custom.TEntry', **style.layout('TEntry')) style.configure('Custom.TEntry', **style.configure('TEntry))