[issue42627] urllib.request.getproxies() misparses Windows registry proxy settings

狂男风 added the comment: Sorry I didn't see this comment before. Can it be merged now? -- ___ Python tracker ___ ___

[issue42627] urllib.request.getproxies() misparses Windows registry proxy settings

Steve Dower added the comment: I think the PR is basically ready, unfortunately it's stuck behind a CI issue we only just fixed, and needs to merge from main before it'll clear. Posting here once CI is green will get attention faster than on GitHub. -- versions: +Python 3.11 -Python

[issue42627] urllib.request.getproxies() misparses Windows registry proxy settings

Keuin added the comment: The fix is available as a pull request on GitHub for months (https://github.com/python/cpython/pull/26307). However, it seems that this pull request needs an approval from one maintainer before running any test. Could anyone help this out? -- nosy: +keuin

[issue42627] urllib.request.getproxies() misparses Windows registry proxy settings

狂男风 added the comment: We should have no problem with how to parse HTTP proxy and HTTPS proxy. But I recently discovered an additional problem when using `requests`, that is, how to parse the SOCKS proxy correctly. I investigated the parsing of some commonly used software: `curl` will try to

[issue42627] urllib.request.getproxies() misparses Windows registry proxy settings

狂男风 added the comment: I removed the multi-proxies-per-protocol support from the PR I submitted. The reason is that: 1. This code reads the proxy settings from the Windows registry. Multi-proxies-per-protocol cannot be resolved by Windows system. 2. Using a comma-separated string for the

[issue42627] urllib.request.getproxies() misparses Windows registry proxy settings

Change by 狂男风 : -- keywords: +patch pull_requests: +24906 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26307 ___ Python tracker ___

[issue42627] urllib.request.getproxies() misparses Windows registry proxy settings

Chris Xiao added the comment: I found this problem too. expecting for fixing -- nosy: +chrisxiao ___ Python tracker ___ ___

[issue42627] urllib.request.getproxies() misparses Windows registry proxy settings

狂男风 added the comment: I make some black box tests with the HTTPS proxy. Set system proxy `http=https://host:port` and start a HTTPS proxy, then IE, Edge (Chromium) and benrg's code (using `urllib3`) work fine while fetching `http://website`. Then I shutdown the HTTPS proxy and start a HTTP

[issue42627] urllib.request.getproxies() misparses Windows registry proxy settings

狂男风 added the comment: We know Windows reslove: `http=host:port;https=host:port;ftp=host:port;socks=host:port` as: `http=http://host:port;https=http://host:port;ftp=http://host:port;socks=socks://host:port` means: Using HTTP type proxy for HTTP, HTTPS and FTP requests, but Socks4/4a type

[issue42627] urllib.request.getproxies() misparses Windows registry proxy settings

Change by 狂男风 : -- nosy: +CrazyBoyFeng ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42627] urllib.request.getproxies() misparses Windows registry proxy settings

Change by NateScarlet : -- nosy: +NateScarlet ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42627] urllib.request.getproxies() misparses Windows registry proxy settings

Change by Dong-hee Na : -- nosy: +corona10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42627] urllib.request.getproxies() misparses Windows registry proxy settings

Change by 双草酸酯 : -- components: +Library (Lib) ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42627] urllib.request.getproxies() misparses Windows registry proxy settings

Change by 双草酸酯 : -- components: +Windows -Library (Lib) ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42627] urllib.request.getproxies() misparses Windows registry proxy settings

双草酸酯 added the comment: I came across this issue as well. I checked Microsoft documentations and it seems `InternetGetProxyInfo` in WinInet is deprecated, while `WinHttpGetIEProxyConfigForCurrentUser` in WinHTTP will return the exact same string as what it stored registery.

[issue42627] urllib.request.getproxies() misparses Windows registry proxy settings

New submission from benrg : If `HKCU\Software\Microsoft\Windows\CurrentVersion\Internet Settings\ProxyServer` contains the string `http=host:123;https=host:456;ftp=host:789`, then getproxies_registry() should return {'http': 'http://host:123', 'https': 'http://host:456', 'ftp':