[issue43974] Define Py_BUILD_CORE_MODULE in extensions instead of setup.py and Modules/Setup

Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue43974] Define Py_BUILD_CORE_MODULE in extensions instead of setup.py and Modules/Setup

Change by Eric Snow : -- nosy: +eric.snow ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue43974] Define Py_BUILD_CORE_MODULE in extensions instead of setup.py and Modules/Setup

Change by Christian Heimes : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue43974] Define Py_BUILD_CORE_MODULE in extensions instead of setup.py and Modules/Setup

Christian Heimes added the comment: New changeset 03e9f5dc751b8c441a85f428abc3f432ffe46345 by Christian Heimes in branch 'main': bpo-43974: Move Py_BUILD_CORE_MODULE into module code (GH-29157) https://github.com/python/cpython/commit/03e9f5dc751b8c441a85f428abc3f432ffe46345 --

[issue43974] Define Py_BUILD_CORE_MODULE in extensions instead of setup.py and Modules/Setup

Erlend E. Aasland added the comment: > I no longer think that we should define Py_BUILD_CORE_MODULE > unconditionally. Instead I propose to move the defines into each C module. +1. Explicit is nice. -- nosy: +erlendaasland ___ Python tracker

[issue43974] Define Py_BUILD_CORE_MODULE in extensions instead of setup.py and Modules/Setup

Change by Christian Heimes : -- pull_requests: +27432 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29157 ___ Python tracker ___

[issue43974] Define Py_BUILD_CORE_MODULE in extensions instead of setup.py and Modules/Setup

Christian Heimes added the comment: The proposal is related to Brett's ticket bpo-45548. I no longer think that we should define Py_BUILD_CORE_MODULE unconditionally. Instead I propose to move the defines into each C module. This avoids duplication of macros in setup.py and Modules/Setup.