[issue44108] [sqlite3] normalise SQL quoted literals in sqlite3 test suite

[Dong-hee Na]

Change by Dong-hee Na :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44108] [sqlite3] normalise SQL quoted literals in sqlite3 test suite

[Erlend E. Aasland]

Change by Erlend E. Aasland :


--
pull_requests: +24767
pull_request: https://github.com/python/cpython/pull/26128

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44108] [sqlite3] normalise SQL quoted literals in sqlite3 test suite

[Dong-hee Na]

Dong-hee Na  added the comment:


New changeset f28bac428d5fff23fe5e95aa02b903ee2dd5b3de by Miss Islington (bot) 
in branch '3.10':
bpo-44108: sqlite3 test suite now works with SQLITE_DQS=0 (GH-26032) (GH-26125)
https://github.com/python/cpython/commit/f28bac428d5fff23fe5e95aa02b903ee2dd5b3de


--
nosy: +corona10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44108] [sqlite3] normalise SQL quoted literals in sqlite3 test suite

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 2.0 -> 3.0
pull_requests: +24765
pull_request: https://github.com/python/cpython/pull/26125

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44108] [sqlite3] normalise SQL quoted literals in sqlite3 test suite

[Erlend E. Aasland]

Erlend E. Aasland  added the comment:

Digression: test_unicode_content should be named test_trace_unicode_content, in 
order to express the purpose of the test more clearly, should it fail.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44108] [sqlite3] normalise SQL quoted literals in sqlite3 test suite

[Erlend E. Aasland]

Change by Erlend E. Aasland :


--
keywords: +patch
pull_requests: +24680
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/26032

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44108] [sqlite3] normalise SQL quoted literals in sqlite3 test suite

[Erlend E. Aasland]

New submission from Erlend E. Aasland :

Most of the SQL statements in the sqlite3 test suite correctly uses single 
quote literals, except test_unicode_content in Lib/sqlite3/test/hooks.py, which 
uses double quote literals (not ANSI SQL compatible, IIRC). Adapting this test 
to also use single quote literals makes the sqlite3 test suite compatible with 
SQLite libraries compiled with SQLITE_DQS=0.


See also:
- https://sqlite.org/compile.html
- https://sqlite.org/quirks.html#dblquote

--
components: Tests
keywords: easy
messages: 393452
nosy: berker.peksag, erlendaasland
priority: low
severity: normal
status: open
title: [sqlite3] normalise SQL quoted literals in sqlite3 test suite
type: enhancement
versions: Python 3.11

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com