[issue44125] "make patchcheck" fails

[miss-islington]

miss-islington  added the comment:


New changeset 336dc523a4180f99955b0fdb65e86059a1abac32 by Miss Islington (bot) 
in branch '3.10':
bpo-44125: Fix "make patchcheck" on non-English locale (GH-26102)
https://github.com/python/cpython/commit/336dc523a4180f99955b0fdb65e86059a1abac32


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44125] "make patchcheck" fails

[Antoine Pitrou]

Change by Antoine Pitrou :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44125] "make patchcheck" fails

[miss-islington]

miss-islington  added the comment:


New changeset 04ce4c773667b0d9d05a89aea4720f8cf84e834e by Miss Islington (bot) 
in branch '3.9':
bpo-44125: Fix "make patchcheck" on non-English locale (GH-26102)
https://github.com/python/cpython/commit/04ce4c773667b0d9d05a89aea4720f8cf84e834e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44125] "make patchcheck" fails

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 1.0 -> 2.0
pull_requests: +24747
pull_request: https://github.com/python/cpython/pull/26105

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44125] "make patchcheck" fails

[miss-islington]

Change by miss-islington :


--
pull_requests: +24749
pull_request: https://github.com/python/cpython/pull/26106

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44125] "make patchcheck" fails

[Antoine Pitrou]

Change by Antoine Pitrou :


--
keywords: +patch
pull_requests: +24743
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/26102

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44125] "make patchcheck" fails

[Antoine Pitrou]

Antoine Pitrou  added the comment:

The patch from bpo-44074 does not account for a possibly non-English locale and 
blindly greps for "HEAD branch" in a possibly localized text.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44125] "make patchcheck" fails

[Antoine Pitrou]

New submission from Antoine Pitrou :

./python ./Tools/scripts/patchcheck.py
Getting base branch for PR ... Traceback (most recent call last):
  File "/home/antoine/cpython/default/./Tools/scripts/patchcheck.py", line 307, 
in 
main()
  File "/home/antoine/cpython/default/./Tools/scripts/patchcheck.py", line 267, 
in main
base_branch = get_base_branch()
  File "/home/antoine/cpython/default/./Tools/scripts/patchcheck.py", line 35, 
in call_fxn
result = fxn(*args, **kwargs)
  File "/home/antoine/cpython/default/./Tools/scripts/patchcheck.py", line 111, 
in get_base_branch
return upstream_remote + "/" + base_branch
TypeError: can only concatenate str (not "NoneType") to str
make: *** [Makefile:2006 : patchcheck] Erreur 1

--
assignee: pitrou
components: Demos and Tools
messages: 393591
nosy: pitrou
priority: normal
severity: normal
stage: needs patch
status: open
title: "make patchcheck" fails
type: behavior
versions: Python 3.10, Python 3.11, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com