[issue44399] log rotator cookbook example might waste disk space

Change by Vinay Sajip : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue44399] log rotator cookbook example might waste disk space

Vinay Sajip added the comment: New changeset 174fbd85f60d7877d3a4f58214a852209f8dfbea by Vinay Sajip in branch 'main': bpo-44399: Document another example of unexpected behavior. (GH-27407) https://github.com/python/cpython/commit/174fbd85f60d7877d3a4f58214a852209f8dfbea --

[issue44399] log rotator cookbook example might waste disk space

Change by Vinay Sajip : -- pull_requests: +25940 pull_request: https://github.com/python/cpython/pull/27407 ___ Python tracker ___

[issue44399] log rotator cookbook example might waste disk space

Vinay Sajip added the comment: New changeset 5a0c6abb569cadfc6b418a7d23ecffec01bd234d by Miss Islington (bot) in branch '3.9': [3.9] bpo-44399: Update logging cookbook to document patterns to be avoided. (GH-27348) (GH-27350)

[issue44399] log rotator cookbook example might waste disk space

Vinay Sajip added the comment: New changeset 628baf6fef4d633e756024cf813941a4075360c1 by Miss Islington (bot) in branch '3.10': [3.10] bpo-44399: Update logging cookbook to document patterns to be avoided. (GH-27348) (GH-27352)

[issue44399] log rotator cookbook example might waste disk space

Change by miss-islington : -- pull_requests: +25892 pull_request: https://github.com/python/cpython/pull/27351 ___ Python tracker ___

[issue44399] log rotator cookbook example might waste disk space

Change by miss-islington : -- pull_requests: +25893 pull_request: https://github.com/python/cpython/pull/27352 ___ Python tracker ___

[issue44399] log rotator cookbook example might waste disk space

Change by miss-islington : -- nosy: +miss-islington nosy_count: 3.0 -> 4.0 pull_requests: +25891 pull_request: https://github.com/python/cpython/pull/27350 ___ Python tracker

[issue44399] log rotator cookbook example might waste disk space

Vinay Sajip added the comment: New changeset 9751f85914e0ef3324671a91da34a635d48b17fb by Vinay Sajip in branch 'main': bpo-44399: Update logging cookbook to document patterns to be avoided. (GH-27348) https://github.com/python/cpython/commit/9751f85914e0ef3324671a91da34a635d48b17fb

[issue44399] log rotator cookbook example might waste disk space

Change by Vinay Sajip : -- keywords: +patch pull_requests: +25889 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27348 ___ Python tracker ___

[issue44399] log rotator cookbook example might waste disk space

Vinay Sajip added the comment: > But I understand if this is out of scope. I think it's out of scope here (as discussion of such issues will obscure the basic point about how to use the namer and rotator). However, it might be useful to have a "gotchas" section somewhere in the logging

[issue44399] log rotator cookbook example might waste disk space

mori-b added the comment: Indeed this situation would rise only under misusage of the log, where multiple processes inherit by mistake or by wrong design a file descriptor of a same log file (Regarding the threads case I unfortunately cannot reproduce). While this kind of misusage doesn't

[issue44399] log rotator cookbook example might waste disk space

Vinay Sajip added the comment: The cookbook example is (by design) limited in scope and doesn't especially discuss usage in multi-thread or multi-process scenarios - as with other examples in the cookbook which aren't specifically concerned with such scenarios. I don't think this is a

[issue44399] log rotator cookbook example might waste disk space

Change by Raymond Hettinger : -- assignee: docs@python -> vinay.sajip nosy: +vinay.sajip ___ Python tracker ___ ___

[issue44399] log rotator cookbook example might waste disk space

mori-b added the comment: Additional precision : this issue can happen when the log file is shared between multiple threads. And naturally also between different processes, which is not recommended but can happen by mistake. -- ___ Python tracker

[issue44399] log rotator cookbook example might waste disk space

mori-b added the comment: In https://docs.python.org/3/howto/logging-cookbook.html#using-a-rotator-and-namer-to-customize-log-rotation-processing, the log rotator example deletes the original log file after compressing it. However, running on Linux the command "lsof +L1" shows that the

[issue44399] log rotator cookbook example might waste disk space

New submission from mori-b : In https://docs.python.org/3/howto/logging-cookbook.html#using-a-rotator-and-namer-to-customize-log-rotation-processing, the log rotator example deletes the original log file after compressing it. However, running on Linux the command "lsof +S1" shows that the