[issue45126] [sqlite3] cleanup and harden connection init

Erlend E. Aasland added the comment: I'll save the cleanup till Python 3.13 dev is started. I've opened a PR for fixing the ref leak (should be backported), and a draft PR for deprecating Connection and Cursor reinitialisation. -- ___ Python

[issue45126] [sqlite3] cleanup and harden connection init

Change by Erlend E. Aasland : -- pull_requests: +26654 pull_request: https://github.com/python/cpython/pull/28234 ___ Python tracker ___

[issue45126] [sqlite3] cleanup and harden connection init

Change by Erlend E. Aasland : -- pull_requests: +26651 pull_request: https://github.com/python/cpython/pull/28231 ___ Python tracker ___

[issue45126] [sqlite3] cleanup and harden connection init

Erlend E. Aasland added the comment: > If we deprecate but keep the buggy behavior it as it is, (1) is not needed. > Less work for both us and the users. Indeed. There's still a ref leak I'd like to take care of, though: if the first audit fails, database_obj leaks. --

[issue45126] [sqlite3] cleanup and harden connection init

Petr Viktorin added the comment: As for the effort to fix this: If we deprecate this, there should be no new users of it in 3.11+. If we deprecate and also fix this, and we happen to introduce bugs or behavior changes, then people that use it now will need to: 1) adapt to the new behavior

[issue45126] [sqlite3] cleanup and harden connection init

Erlend E. Aasland added the comment: Great, thanks. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45126] [sqlite3] cleanup and harden connection init

Petr Viktorin added the comment: I think a deprecation should be discussed a bit more widely than on bpo, so I opened a thread here: https://discuss.python.org/t/deprecating-sqlite-object-reinitialization/10503 -- ___ Python tracker

[issue45126] [sqlite3] cleanup and harden connection init

Erlend E. Aasland added the comment: FYI, I've expanded the reinit tests and added a deprecation warning to the PR. -- ___ Python tracker ___

[issue45126] [sqlite3] cleanup and harden connection init

Erlend E. Aasland added the comment: Modifying the loops to also print the values: first fetch b'0' b'1' second fetch 2 3 -- ___ Python tracker ___

[issue45126] [sqlite3] cleanup and harden connection init

Erlend E. Aasland added the comment: Note: I ran that with PR 28227. OTOH: I do agree that there's a lot of pitfalls here, especially in the future. In the long run, it is probably best to deprecate reinit, and disable it in Python 3.13. -- ___

[issue45126] [sqlite3] cleanup and harden connection init

Erlend E. Aasland added the comment: I modified your second example slightly: ``` import sqlite3 conn = sqlite3.connect(":memory:") conn.text_factory=bytes conn.row_factory = sqlite3.Row cursor = conn.execute("CREATE TABLE foo (bar)") numbers = range(4) cursor.executemany("INSERT INTO foo

[issue45126] [sqlite3] cleanup and harden connection init

Petr Viktorin added the comment: This is a minefield. If anyone has a use case for it, I'd *love* to hear it, but to me it seems that proper reinit support will be a lot of work (now and in future maintenance) for no gain. You can always create a new connection object. Consider instead

[issue45126] [sqlite3] cleanup and harden connection init

Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +26648 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28227 ___ Python tracker

[issue45126] [sqlite3] cleanup and harden connection init

New submission from Erlend E. Aasland : Quoting Petr Viktorin in PR 27940, https://github.com/python/cpython/pull/27940#discussion_r703424148: - db is not set to NULL if init fails. - This segfaults for me: import sqlite3 conn = sqlite3.connect(':memory:') conn.execute('CREATE TABLE