[issue45183] Unexpected exception with zip importer

Brett Cannon added the comment: I decided that find_spec() saying something wasn't available in a finder made sense even though it was because a zip file no longer existed as the loader would still fail as appropriate. -- resolution: -> fixed stage: patch review -> resolved status:

[issue45183] Unexpected exception with zip importer

Brett Cannon added the comment: New changeset e1bdecb6dc7ac33256d5fa875d45634512d2a90e by Brett Cannon in branch '3.10': [3.10] bpo-45183: don't raise an exception when calling zipimport.zipimporter.find_spec() when the zip file is missing and the internal cache has been reset (GH-28435)

[issue45183] Unexpected exception with zip importer

Change by Brett Cannon : -- pull_requests: +26843 pull_request: https://github.com/python/cpython/pull/28438 ___ Python tracker ___

[issue45183] Unexpected exception with zip importer

Brett Cannon added the comment: New changeset 209b7035f714dcc41df054b0b023e0b955d7e1a2 by Brett Cannon in branch 'main': bpo-45183: don't raise an exception when calling zipimport.zipimporter.find_spec() when the zip file is missing and the internal cache has been reset (GH-28435)

[issue45183] Unexpected exception with zip importer

Change by miss-islington : -- keywords: +patch nosy: +miss-islington nosy_count: 4.0 -> 5.0 pull_requests: +26842 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28437 ___ Python tracker

[issue45183] Unexpected exception with zip importer

Brett Cannon added the comment: The proposed fix seems to be the right one based on my reading of the code. -- keywords: -patch stage: patch review -> ___ Python tracker

[issue45183] Unexpected exception with zip importer

Change by Brett Cannon : -- keywords: +patch pull_requests: +26840 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28435 ___ Python tracker ___

[issue45183] Unexpected exception with zip importer

Ronald Oussoren added the comment: I just noticed that I'm unnecessarily obtuse in my description of a possible fix, the diff (without test update): % git diff Lib/zipimport.py (main)cpython diff --git

[issue45183] Unexpected exception with zip importer

Change by Brett Cannon : -- assignee: -> brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45183] Unexpected exception with zip importer

Pablo Galindo Salgado added the comment: Brett, can you take a look when you have some time? -- ___ Python tracker ___ ___

[issue45183] Unexpected exception with zip importer

Pablo Galindo Salgado added the comment: I bisected this to: 3abf6f010243a91bf57cbf357dac33193f7b8407 is the first bad commit commit 3abf6f010243a91bf57cbf357dac33193f7b8407 Author: Desmond Cheong Date: Tue Mar 9 04:06:02 2021 +0800 bpo-14678: Update zipimport to support

[issue45183] Unexpected exception with zip importer

Change by Ronald Oussoren : -- type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45183] Unexpected exception with zip importer

Change by Ronald Oussoren : -- nosy: +pablogsal, twouters ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45183] Unexpected exception with zip importer

New submission from Ronald Oussoren : The attached file demonstrates the problem: If importlib.invalidate_caches() is called while the zipfile used by the zip importer is not available the import system breaks entirely. I found this in a testsuite that accedently did this (it should have