[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

Steve Dower added the comment: It was not backported to 3.8 because that's in security fix only mode. -- versions: -Python 3.8 ___ Python tracker ___

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

ntrischi added the comment: Compiling Python3.8.9 from source on Windows 10 with VS2019. Running PCBuild\build.bat, I'm getting the following issue: C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\um\winnt.h(253): error RC2188:

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

Steve Dower added the comment: > instead of manually defining RT_MANIFEST, try including "winresrc.h" in the > resource definition files I just wish it were documented... we can keep it in mind if another one of these pops up. -- ___ Python

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

Steve Dower added the comment: New changeset 32d14b262d6d914f63485f8d6e7859df58cd2089 by Miss Islington (bot) in branch '3.9': bpo-45220: Ensure RT_MANIFEST is defined when compiling Windows resource files (GH-29501)

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

Eryk Sun added the comment: Also, I suggest using CREATEPROCESS_MANIFEST_RESOURCE_ID (1) and ISOLATIONAWARE_MANIFEST_RESOURCE_ID (2) instead of hard-coded resource IDs. -- ___ Python tracker

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

Eryk Sun added the comment: Steve, instead of manually defining RT_MANIFEST, try including "winresrc.h" in the resource definition files. This SDK header includes "winuser.rh" (note the ".rh" extension), which, among other things, includes the following RC_INVOKED definitions from

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

miss-islington added the comment: New changeset d29f591dd6b1dcd4f36b5b49761cf8225be690bd by Miss Islington (bot) in branch '3.10': bpo-45220: Ensure RT_MANIFEST is defined when compiling Windows resource files (GH-29501)

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

Steve Dower added the comment: New changeset a56fbad85ea655631bce68d4c0f47f1a8b500abd by Steve Dower in branch 'main': bpo-45220: Ensure RT_MANIFEST is defined when compiling Windows resource files (GH-29501) https://github.com/python/cpython/commit/a56fbad85ea655631bce68d4c0f47f1a8b500abd

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

Change by miss-islington : -- pull_requests: +27754 pull_request: https://github.com/python/cpython/pull/29504 ___ Python tracker ___

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

Change by miss-islington : -- pull_requests: +27753 pull_request: https://github.com/python/cpython/pull/29503 ___ Python tracker ___

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

Change by Steve Dower : -- pull_requests: +27750 pull_request: https://github.com/python/cpython/pull/29501 ___ Python tracker ___

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

Łukasz Langa added the comment: New changeset c0f3281d6ca5c59d4a11698364463d968b9ddd3c by Miss Islington (bot) in branch '3.10': bpo-45220: Remove invalid include from resource definition files on Windows (GH-29396) (GH-29406)

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

miss-islington added the comment: New changeset 1a44d27e6f8a06cb7d56e39be48852f0c3f4502b by Miss Islington (bot) in branch '3.9': bpo-45220: Remove invalid include from resource definition files on Windows (GH-29396)

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

Change by miss-islington : -- pull_requests: +27662 pull_request: https://github.com/python/cpython/pull/29406 ___ Python tracker ___

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

Change by miss-islington : -- pull_requests: +27661 pull_request: https://github.com/python/cpython/pull/29405 ___ Python tracker ___

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

Steve Dower added the comment: New changeset fd0c84dc28d00d68e4f43034dc41786a682390fd by Steve Dower in branch 'main': bpo-45220: Remove invalid include from resource definition files on Windows (GH-29396) https://github.com/python/cpython/commit/fd0c84dc28d00d68e4f43034dc41786a682390fd

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

Change by Steve Dower : -- pull_requests: +27654 pull_request: https://github.com/python/cpython/pull/29396 ___ Python tracker ___

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

Łukasz Langa added the comment: New changeset 456d6d9fefac828c19fc1b562f6301f00965fe59 by Miss Islington (bot) in branch '3.8': bpo-45220: Avoid automatically selecting the Windows 11 SDK preview when building (GH-28393) (GH-28622)

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

Change by miss-islington : -- pull_requests: +26995 pull_request: https://github.com/python/cpython/pull/28622 ___ Python tracker ___

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

Serhiy Storchaka added the comment: New changeset f798cef87faeb428bdb9ebf73df1a6146304 by Miss Islington (bot) in branch '3.10': bpo-45220: Avoid automatically selecting the Windows 11 SDK preview when building (GH-28393) (GH-28394)

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

miss-islington added the comment: New changeset 7ad07eed885ae333d5dfc470b9c11ff2f7b229aa by Miss Islington (bot) in branch '3.9': bpo-45220: Avoid automatically selecting the Windows 11 SDK preview when building (GH-28393)

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

Steve Dower added the comment: New changeset f4b94b1f57827083990272b5f282aa1493ae2bf4 by Steve Dower in branch 'main': bpo-45220: Avoid automatically selecting the Windows 11 SDK preview when building (GH-28393)

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

Change by miss-islington : -- pull_requests: +26807 pull_request: https://github.com/python/cpython/pull/28395 ___ Python tracker ___

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

Change by miss-islington : -- nosy: +miss-islington nosy_count: 7.0 -> 8.0 pull_requests: +26806 pull_request: https://github.com/python/cpython/pull/28394 ___ Python tracker

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

Change by Steve Dower : -- keywords: +patch pull_requests: +26805 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28393 ___ Python tracker ___

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

Steve Dower added the comment: > C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\um\winnt.h This appears to be the Windows 11 preview SDK, so most likely it's a bug in that. We'll obviously need some logic to not automatically upgrade to this SDK on build. --

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

Steve Dower added the comment: The build order change was not backported (and should not be), so it's unrelated to the failures on 3.9 and 3.10. More likely this is either a problematic compiler update, or some additional data leaking into the build information (e.g. I could see this

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

STINNER Victor added the comment: This issue is serious: it prevents to merge many pull requests, it blocks the Python development workflow. -- ___ Python tracker ___

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

STINNER Victor added the comment: > bpo-45188: Windows now regenerates frozen modules at the start of build > instead of late (GH-28322) Maybe the resource compiler needs a header file which is not generated yet, and so the build fails. In msg401948 logs, I don't see when header files are

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

STINNER Victor added the comment: > C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\um\winnt.h(253): > error RC2188: > D:\a\cpython\cpython\PCbuild\obj\311win32_Release\pythoncore\RCa05056(47) : > fatal error RC1116: RC terminating after preprocessor errors >

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

Eric Snow added the comment: Of course, it might also be unrelated. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

Eric Snow added the comment: This is more likely to relate to bpo-45188, "De-couple the Windows builds from freezing modules.", for which the PR was merged yesterday: New changeset 09b4ad11f323f8702cde795e345b75e0fbb1a9a5 by Steve Dower in branch 'main': bpo-45188: Windows now regenerates

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

STINNER Victor added the comment: It may be related to bpo-45020 which recently got a change: New changeset 9fd87a5fe5c468cf94265365091267838b004b7f by Eric Snow in branch 'main': bpo-45020: Revert "Drop the frozen .h files from the repo." (gh-28380)

[issue45220] Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors

Change by STINNER Victor : -- title: Windows builds sometimes fail on main branch: fatal error RC1116: RC terminating after preprocessor errors -> Windows builds sometimes fail on Azure and GitHub Action: fatal error RC1116: RC terminating after preprocessor errors