[issue45416] "loop argument must agree with lock" instantiating asyncio.Condition

Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue45416] "loop argument must agree with lock" instantiating asyncio.Condition

Andrew Svetlov added the comment: Thanks, guys! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45416] "loop argument must agree with lock" instantiating asyncio.Condition

miss-islington added the comment: New changeset 164dddf5f8c9c6b93f32c9f79b4301fc804576e9 by Miss Islington (bot) in branch '3.10': bpo-45416: Fix use of asyncio.Condition() with explicit Lock objects (GH-28850) https://github.com/python/cpython/commit/164dddf5f8c9c6b93f32c9f79b4301fc804576e9

[issue45416] "loop argument must agree with lock" instantiating asyncio.Condition

Change by miss-islington : -- nosy: +miss-islington nosy_count: 7.0 -> 8.0 pull_requests: +27163 pull_request: https://github.com/python/cpython/pull/28856 ___ Python tracker

[issue45416] "loop argument must agree with lock" instantiating asyncio.Condition

Serhiy Storchaka added the comment: New changeset 1a7892414e654aa5c99efa31db767baba7f4a424 by Joongi Kim in branch 'main': bpo-45416: Fix use of asyncio.Condition() with explicit Lock objects (GH-28850) https://github.com/python/cpython/commit/1a7892414e654aa5c99efa31db767baba7f4a424

[issue45416] "loop argument must agree with lock" instantiating asyncio.Condition

Change by Joongi Kim : -- keywords: +patch nosy: +Joongi Kim nosy_count: 6.0 -> 7.0 pull_requests: +27160 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28850 ___ Python tracker

[issue45416] "loop argument must agree with lock" instantiating asyncio.Condition

Change by Dong-hee Na : -- versions: +Python 3.11 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45416] "loop argument must agree with lock" instantiating asyncio.Condition

Change by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45416] "loop argument must agree with lock" instantiating asyncio.Condition

Łukasz Langa added the comment: Issue confirmed. The problem is that `Condition.__init__` compares its own loop with Lock's internal `_loop` attribute. That attribute is set to None unless the lock waited to be acquired. uriyyo, Andrew, Yury, since it's pretty likely that Lock objects will

[issue45416] "loop argument must agree with lock" instantiating asyncio.Condition

Simon Willison added the comment: It looks like the relevant test is here: https://github.com/python/cpython/blob/a1092f62492a3fcd6195bea94eccf8d5a300acb1/Lib/test/test_asyncio/test_locks.py#L722-L727 def test_explicit_lock(self): lock = asyncio.Lock() cond =

[issue45416] "loop argument must agree with lock" instantiating asyncio.Condition

Simon Willison added the comment: I ran across this issue while trying to use the https://pypi.org/project/janus/ locking library with Python 3.10 - see my issue on their tracker here: https://github.com/aio-libs/janus/issues/358 -- ___ Python

[issue45416] "loop argument must agree with lock" instantiating asyncio.Condition

New submission from Simon Willison : In Python 3.10 it is not possible to instantiate an asyncio.Condition that wraps an asyncio.Lock without raising a "loop argument must agree with lock" exception. This code raises that exception: asyncio.Condition(asyncio.Lock()) This worked in