[issue4555] Smelly exports (global symbols in python not prefixed with Py or _Py)
Roundup Robot added the comment: New changeset 142c62a490ce by Antoine Pitrou in branch 'default': Issue #4555: All exported C symbols are now prefixed with either Py or _Py. http://hg.python.org/cpython/rev/142c62a490ce -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4555 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4555] Smelly exports (global symbols in python not prefixed with Py or _Py)
Changes by Antoine Pitrou pit...@free.fr: -- resolution: - fixed stage: commit review - committed/rejected status: open - closed versions: -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4555 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4555] Smelly exports (global symbols in python not prefixed with Py or _Py)
Antoine Pitrou added the comment: This very simple patch should certainly be applied. -- assignee: - dmalcolm stage: patch review - commit review versions: +Python 2.7 -Python 2.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4555 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4555] Smelly exports (global symbols in python not prefixed with Py or _Py)
Martin v. Löwis added the comment: I'd like to focus this issue; it has been open long enough, and deserves to get closed once the original issue is resolved - which was that make smelly reports symbols. I think dmalcolm's patch is quite a good start for that. It may well be that other modules need to be considered - but PLEASE not in this issue. For Unix with shared libraries, the extension modules certainly cause problems, in particular if Python gets embedded in a context (e.g. Apache) that also loads separate copies of the same libraries, and may cause problems if one of our functions collide with some library. However, I see *two* issues falling out of this: one to extend the make smelly target to include extension modules, and the other to then fix the extension modules - preferably with one issue per extension module. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4555 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4555] Smelly exports (global symbols in python not prefixed with Py or _Py)
Christian Heimes added the comment: For Python 3.3 and 3.4 make smelly still lists two exported symbols. asdl_int_seq_new asdl_seq_new Do we have to check the modules, too? Some of them like _ctypes and _decimal export a lot of symbols. Here is a small shell snippet for Makefile. for MOD in `find $(srcdir)/build -name '*.s[ol]' ` ; do \ EXPORT=`nm -p $$MOD | sed -n / [TDB] /s/.* //p | \ grep -E -v ^_*Py|^_init|^_fini | sort -u`; \ if [ -n $$EXPORT ]; then \ echo $$MOD; \ echo $$EXPORT; \ fi \ done -- versions: +Python 3.3, Python 3.4 -Python 2.7, Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4555 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4555] Smelly exports (global symbols in python not prefixed with Py or _Py)
Changes by Antoine Pitrou pit...@free.fr: -- stage: test needed - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4555 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4555] Smelly exports (global symbols in python not prefixed with Py or _Py)
Changes by Alexander Belopolsky belopol...@users.sourceforge.net: -- title: Smelly exports - Smelly exports (global symbols in python not prefixed with Py or _Py) ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4555 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4555] Smelly exports (global symbols in python not prefixed with Py or _Py)
Dave Malcolm dmalc...@redhat.com added the comment: Patch to py3k which adds the _Py prefix to the four listed symbols. With this, the output from make smelly is clean (odorless, perhaps?). However, adding _Py does seem to go against this comment in Include/asdl.h: /* It would be nice if the code generated by asdl_c.py was completely independent of Python, but it is a goal the requires too much work at this stage. So, for example, I'll represent identifiers as interned Python strings. */ -- Added file: http://bugs.python.org/file18094/py3k-add-_Py-prefix-to-avoid-smelliness.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4555 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
