[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Irit Katriel added the comment: We have agreed on python-dev [1] that the cpython changes will not be reverted, and the issue will be fixed in cython. So I am closing this again. [1] https://mail.python.org/archives/list/python-...@python.org/message/BHIQL4P6F7OPMCAP6U24XEZUPQKI62UT/

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

STINNER Victor added the comment: lxml does crash on the current Cython 0.29.x development branch. -- ___ Python tracker ___ ___

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

da-woods added the comment: Just a quick comment on Cython and these changes: Cython 0.29 can build itself on Python 3.11a4 with `CFLAGS="-DCYTHON_FAST_THREAD_STATE=0 -DCYTHON_USE_EXC_INFO_STACK=0" python3.11 setup.py build_ext`. I think there's some coroutine code left that isn't fixed by

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Irit Katriel added the comment: > GH-30531 proposes adding PyErr_GetActiveException() function which has no > parameter, but Cython __Pyx_PyErr_GetTopmostException() has a tstate > parameter. I've now updated it to follow the pattern of other functions, where the is a private function

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Irit Katriel added the comment: This is a backport of @scoder's patch to 0.29.x. (I don't know if this is helpful). https://github.com/cython/cython/compare/master...iritkatriel:exc_info?expand=1 -- ___ Python tracker

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

STINNER Victor added the comment: > __Pyx_PyErr_GetTopmostException(PyThreadState *tstate) Python provides a *private* _PyErr_GetTopmostException(tstate) function, but Cython reimplements its own function. I'm not sure why. GH-30531 proposes adding PyErr_GetActiveException() function which

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Guido van Rossum added the comment: Time to insist on directly communicating with the Cython team (esp. @scoder) and broker some kind of compromise. -- ___ Python tracker

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Irit Katriel added the comment: If this is still the position of cython maintainers: https://github.com/cython/cython/issues/4581#issuecomment-1016503683 then I will need to revert the change until 3.12. -- ___ Python tracker

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Irit Katriel added the comment: That commit has significant changes in ceval.c and compile.c. They don't need to be reverted to unbreak cython. I'm working on a PR for a simpler change. Have you tried with CYTHON_USE_EXC_INFO_STACK undefined? --

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

STINNER Victor added the comment: Irit Katriel: > Reverting the whole thing would include big changes in compile.c and ceval.c, > so I'd rather avoid that if we can. It was a good idea to split changes of this issue into multiple commits :-) I'm only proposing to revert the one which

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

STINNER Victor added the comment: I commented the Cython issue: https://github.com/cython/cython/issues/4500#issuecomment-1026949365 I also opened a discussion on python-dev: "Please update Cython before introcuding C API incompatible changes in Python".

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

STINNER Victor added the comment: > In Cython, the issue is tracked as: > https://github.com/cython/cython/issues/4500 I don't understand the Cython status. The code was updated in the master branch: * https://github.com/cython/cython/pull/4584 *

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Irit Katriel added the comment: Does unsetting CYTHON_USE_EXC_INFO_STACK still work? #if CYTHON_USE_EXC_INFO_STACK // See https://bugs.python.org/issue25612 #define __Pyx_ExcInfoStruct _PyErr_StackItem #else // Minimal replacement struct for Py<3.7, without the Py3.7 exception state

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Irit Katriel added the comment: I can probably just put back the two fields in _PyErr_StackItem and make sure they get updated when exc_value is set. Reverting the whole thing would include big changes in compile.c and ceval.c, so I'd rather avoid that if we can. --

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

STINNER Victor added the comment: Would it be possible to revert the change until Cython and numpy are ready for it? > bpo-45711: Remove type and traceback from exc_info (GH-30122) This change broke numpy which uses C code generated by Cython for coroutines in numpy/random/_mt19937.c (file

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Irit Katriel added the comment: New changeset 80e1def9ded2a1d017410394e50c88aa39135029 by Irit Katriel in branch 'main': bpo-45711: move whatsnew entries which are incorrectly listed under New Features (GH-30849)

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Change by Irit Katriel : -- pull_requests: +29031 pull_request: https://github.com/python/cpython/pull/30849 ___ Python tracker ___

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Change by Irit Katriel : -- pull_requests: +28539 pull_request: https://github.com/python/cpython/pull/30289 ___ Python tracker ___

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Change by Irit Katriel : -- pull_requests: -28217 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Change by Irit Katriel : -- pull_requests: -28193 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Irit Katriel added the comment: This is done, there will be more cleanups that this enables but they can have their own issues. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Change by Irit Katriel : -- pull_requests: -28503 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Change by Irit Katriel : -- pull_requests: +28503 pull_request: https://github.com/python/cpython/pull/30289 ___ Python tracker ___

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Mark Shannon added the comment: New changeset 396b58345f81d4c8c5a52546d2288e666a1b9b8b by Irit Katriel in branch 'main': bpo-45711: Remove type and traceback from exc_info (GH-30122) https://github.com/python/cpython/commit/396b58345f81d4c8c5a52546d2288e666a1b9b8b --

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Stefan Behnel added the comment: FYI, we track the Cython side of this in https://github.com/cython/cython/issues/4500 -- ___ Python tracker ___

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Change by Stefan Behnel : -- nosy: +scoder ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Change by Irit Katriel : -- pull_requests: +28341 pull_request: https://github.com/python/cpython/pull/30122 ___ Python tracker ___

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Change by Irit Katriel : -- pull_requests: +28217 pull_request: https://github.com/python/cpython/pull/29994 ___ Python tracker ___

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Irit Katriel added the comment: New changeset 2109f7880b65755329a877da3a7f8a362de07350 by Irit Katriel in branch 'main': bpo-45711: Remove unnecessary normalization of exc_info (GH-29922) https://github.com/python/cpython/commit/2109f7880b65755329a877da3a7f8a362de07350 --

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Change by Irit Katriel : -- pull_requests: +28193 pull_request: https://github.com/python/cpython/pull/29968 ___ Python tracker ___

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Change by Irit Katriel : -- pull_requests: +28146 pull_request: https://github.com/python/cpython/pull/29922 ___ Python tracker ___

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Irit Katriel added the comment: New changeset 2ff758bd1a144ee712e96ae1db91f476c3b252bb by Irit Katriel in branch 'main': bpo-45711: [asyncio] Normalize exceptions immediately after Fetch, before they are stored as StackItem, which should be normalized (GH-29890)

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Change by Irit Katriel : -- pull_requests: +28114 pull_request: https://github.com/python/cpython/pull/29890 ___ Python tracker ___

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Irit Katriel added the comment: New changeset 8a45ca542a65ea27e7acaa44a4c833a27830e796 by Irit Katriel in branch 'main': bpo-45711: Change exc_info related APIs to derive type and traceback from the exception instance (GH-29780)

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Change by Irit Katriel : -- pull_requests: +28017 pull_request: https://github.com/python/cpython/pull/29780 ___ Python tracker ___

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Irit Katriel added the comment: Following the analysis/discussion on https://github.com/faster-cpython/ideas/issues/106: * exc_info is always normalized, so we actually will never need to create a tuple of these three values (exc_curinfo, the exception raised but not yet caught can be

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Irit Katriel added the comment: New changeset c456dfafe9f9f6614fbcf2213a93707f0e101f4e by Irit Katriel in branch 'main': bpo-45711: use exc_value instead of exc_type to determine if exc_info is valid. Add more assertions. (GH-29627)

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Change by Irit Katriel : -- pull_requests: +27859 pull_request: https://github.com/python/cpython/pull/29627 ___ Python tracker ___

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Irit Katriel added the comment: New changeset de3db1448b1b983eeb9f4498d07e3d2f1fb6d29d by Irit Katriel in branch 'main': bpo-45711: assert that the type of exc_info is redundant (GH-29518) https://github.com/python/cpython/commit/de3db1448b1b983eeb9f4498d07e3d2f1fb6d29d --

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Irit Katriel added the comment: New changeset 8f1b71de731dda668aede7c9b34d0ad7afb8f6a8 by Brandt Bucher in branch 'main': bpo-45711: Re-bump the magic number and update doc (GH-29528) https://github.com/python/cpython/commit/8f1b71de731dda668aede7c9b34d0ad7afb8f6a8 --

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Change by Brandt Bucher : -- nosy: +brandtbucher nosy_count: 4.0 -> 5.0 pull_requests: +27778 pull_request: https://github.com/python/cpython/pull/29528 ___ Python tracker ___

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Change by Irit Katriel : -- pull_requests: +27770 pull_request: https://github.com/python/cpython/pull/29518 ___ Python tracker ___

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Mark Shannon added the comment: New changeset 4cdeee5978ee3f8ea7fe95172ae04d866cd88177 by Irit Katriel in branch 'main': bpo-45711: remove unnecessary DUP_TOP and POP in exception handling (GH-29495) https://github.com/python/cpython/commit/4cdeee5978ee3f8ea7fe95172ae04d866cd88177

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Irit Katriel added the comment: New changeset 05fbd60147456d77a7aecf2986c5bde5872f by Irit Katriel in branch 'main': bpo-45711: Use _PyErr_ClearExcState instead of setting only exc_value to NULL (GH-29404) https://github.com/python/cpython/commit/05fbd60147456d77a7aecf2986c5bde5872f

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Change by Irit Katriel : -- pull_requests: +27745 pull_request: https://github.com/python/cpython/pull/29495 ___ Python tracker ___

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Irit Katriel added the comment: Initially not, neither in python nor in the c api. It would be nice to replace PyErr_Fetch/Restore by a version that takes just an exception but that’s a long deprecation. -- ___ Python tracker

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Terry J. Reedy added the comment: Would there be any change at the Python level? -- nosy: +terry.reedy type: -> performance ___ Python tracker ___

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

Change by Irit Katriel : -- keywords: +patch pull_requests: +27660 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29404 ___ Python tracker ___

[issue45711] Simplify the interpreter's (type, val, tb) exception representation

New submission from Irit Katriel : Exceptions are represented in the interpreter as (type, val, tb) triplets which most of the time contain redundant information (the type is the type of val and the tb is also on the exception). This complicates the code and is inefficient as opcodes that