[issue45853] Misspelled _IGNORED_ERROS in Lib/pathlib.py

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue45853] Misspelled _IGNORED_ERROS in Lib/pathlib.py

Serhiy Storchaka added the comment: New changeset 8d7644fa64213207b8dc6f555cb8a02bfabeced2 by andrei kulakov in branch 'main': bpo-45853: Fix misspelling and unused import in pathlib (GH-30292) https://github.com/python/cpython/commit/8d7644fa64213207b8dc6f555cb8a02bfabeced2 --

[issue45853] Misspelled _IGNORED_ERROS in Lib/pathlib.py

Change by Andrei Kulakov : -- pull_requests: +28506 pull_request: https://github.com/python/cpython/pull/30292 ___ Python tracker ___

[issue45853] Misspelled _IGNORED_ERROS in Lib/pathlib.py

Serhiy Storchaka added the comment: It was assigned to a variable initially because it was used in multiple places. Now it is only used in one place, but I agree with keeping the variable for readability. But it should be named _IGNORED_ERRNOS. --

[issue45853] Misspelled _IGNORED_ERROS in Lib/pathlib.py

Andrei Kulakov added the comment: Serhiy: I think you're right, it was likely meant to be _IGNORED_ERRNOS; for inlining it, it looks like it wasn't inlined to be more readable, but if we inline it, we should also inline _IGNORED_WINERRORS. I don't mind inlining both. --

[issue45853] Misspelled _IGNORED_ERROS in Lib/pathlib.py

Badal Sahani added the comment: Corrected Misspelled _IGNORED_ERROS in Lib/pathlib.py to _IGNORED_ERRORS -- hgrepos: +411 keywords: +patch message_count: 3.0 -> 4.0 nosy: +badalsahani nosy_count: 2.0 -> 3.0 pull_requests: +27925 stage: needs patch -> patch review pull_request:

[issue45853] Misspelled _IGNORED_ERROS in Lib/pathlib.py

Serhiy Storchaka added the comment: BTW, is not the correct name _IGNORED_ERRNOS? -- ___ Python tracker ___ ___ Python-bugs-list

[issue45853] Misspelled _IGNORED_ERROS in Lib/pathlib.py

Serhiy Storchaka added the comment: If it is only used in a single place in the module would not be better to inline it? -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue45853] Misspelled _IGNORED_ERROS in Lib/pathlib.py

Change by Andrei Kulakov : -- components: +Library (Lib) priority: normal -> low stage: -> needs patch type: -> enhancement versions: +Python 3.11 ___ Python tracker ___

[issue45853] Misspelled _IGNORED_ERROS in Lib/pathlib.py

New submission from Andrei Kulakov : Should be _IGNORED_ERRORS This name was added 3 years ago: https://github.com/python/cpython/commit/216b745eafa7cd4a683a8405dcfbd7f5567f504c It's only used in a single place in the module. But I'm not sure if it's worth fixing. It is an internal,