[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Eric Snow added the comment: New changeset 21412d037b07c08266e96dfd0c0e44a1b7693bc1 by Eric Snow in branch 'main': bpo-46541: Add a Comment About When to Use _Py_DECLARE_STR(). (gh-32063) https://github.com/python/cpython/commit/21412d037b07c08266e96dfd0c0e44a1b7693bc1 --

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Change by Eric Snow : -- pull_requests: +30154 pull_request: https://github.com/python/cpython/pull/32063 ___ Python tracker ___

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Dong-hee Na added the comment: New changeset d168c728f7114959e8fc147538ea1d24f2f5af79 by Dong-hee Na in branch 'main': bpo-46541: Remove usage of _Py_IDENTIFIER from lzma module (GH-31683) https://github.com/python/cpython/commit/d168c728f7114959e8fc147538ea1d24f2f5af79 --

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Change by Dong-hee Na : -- pull_requests: +29804 pull_request: https://github.com/python/cpython/pull/31683 ___ Python tracker ___

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Dong-hee Na added the comment: New changeset e91b0a7139d4a4cbd2351ccb5cd021a100cf42d2 by Kumar Aditya in branch 'main': bpo-46541: remove usage of _Py_IDENTIFIER from _ssl module (GH-31599) https://github.com/python/cpython/commit/e91b0a7139d4a4cbd2351ccb5cd021a100cf42d2 --

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Dong-hee Na added the comment: New changeset 0cc63641859b2f60ea65bb7c0b6d1cfcec1e2f1a by Dong-hee Na in branch 'main': bpo-46541: Remove usage of _Py_IDENTIFIER from multibytecodec (GH-31475) https://github.com/python/cpython/commit/0cc63641859b2f60ea65bb7c0b6d1cfcec1e2f1a --

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Dong-hee Na added the comment: New changeset c32aef48533769161e1247927a5b418322e0860c by Erlend Egeberg Aasland in branch 'main': bpo-46541: Remove unneeded visits from sqlite3 (GH-31609) https://github.com/python/cpython/commit/c32aef48533769161e1247927a5b418322e0860c --

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Change by Erlend E. Aasland : -- pull_requests: +29732 pull_request: https://github.com/python/cpython/pull/31609 ___ Python tracker ___

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Christian Heimes added the comment: New changeset 088dd76dba68c2538776d9920607f81e54544cbd by Dong-hee Na in branch 'main': bpo-46541: Remove unnecessary Py_VISIT (GH-31608) https://github.com/python/cpython/commit/088dd76dba68c2538776d9920607f81e54544cbd -- nosy: +christian.heimes

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Change by Dong-hee Na : -- pull_requests: +29731 pull_request: https://github.com/python/cpython/pull/31608 ___ Python tracker ___

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Change by Kumar Aditya : -- pull_requests: +29722 pull_request: https://github.com/python/cpython/pull/31599 ___ Python tracker ___

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Change by Dong-hee Na : -- pull_requests: +29611 pull_request: https://github.com/python/cpython/pull/31475 ___ Python tracker ___

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Dong-hee Na added the comment: New changeset 2b86616456629e11de33629da1bb732f033c436e by Dong-hee Na in branch 'main': bpo-46541: Remove usage of _Py_IDENTIFIER from pyexpat (GH-31468) https://github.com/python/cpython/commit/2b86616456629e11de33629da1bb732f033c436e --

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Change by Dong-hee Na : -- pull_requests: +29598 pull_request: https://github.com/python/cpython/pull/31468 ___ Python tracker ___

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Change by Christoph Reiter : -- nosy: -lazka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Dong-hee Na added the comment: New changeset 8cb5f707a841832aeac4b01c8b6a0e72dced52ae by Dong-hee Na in branch 'main': bpo-46541: Remove usage of _Py_IDENTIFIER from array module (GH-31376) https://github.com/python/cpython/commit/8cb5f707a841832aeac4b01c8b6a0e72dced52ae --

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Change by Jason Wilkes : -- nosy: +notarealdeveloper nosy_count: 7.0 -> 8.0 pull_requests: +29528 pull_request: https://github.com/python/cpython/pull/30310 ___ Python tracker

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Dong-hee Na added the comment: > I think it's fine to use the one issue. Great! and thank you for all your efforts :) -- ___ Python tracker ___

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Eric Snow added the comment: (from https://github.com/python/cpython/pull/31376#issuecomment-1041836106) [corona10] > Should we create the separate bpo issue if module changes are too noisy? I think it's fine to use the one issue. There are only 26 modules with `NEEDS_PY_IDENTIFIER` and

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Change by Dong-hee Na : -- pull_requests: +29525 pull_request: https://github.com/python/cpython/pull/31376 ___ Python tracker ___

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Dong-hee Na added the comment: New changeset e8a19b092fc0551581e10d6f310dd5feabac7609 by Dong-hee Na in branch 'main': bpo-46541: Remove usage of _Py_IDENTIFIER from mmap module (GH-31375) https://github.com/python/cpython/commit/e8a19b092fc0551581e10d6f310dd5feabac7609 --

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Change by Dong-hee Na : -- pull_requests: +29524 pull_request: https://github.com/python/cpython/pull/31375 ___ Python tracker ___

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Dong-hee Na added the comment: New changeset b2077117d125925210148294eefee28797b7ff4c by Erlend Egeberg Aasland in branch 'main': bpo-46541: Replace _Py_IDENTIFIER with _Py_ID in sqlite3 (GH-31351) https://github.com/python/cpython/commit/b2077117d125925210148294eefee28797b7ff4c --

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Dong-hee Na added the comment: New changeset d64f3caebe8f8e31ecd193e0bd25105400153ece by Dong-hee Na in branch 'main': bpo-46541: Remove usage of _Py_IDENTIFIER from csv module (GH-31372) https://github.com/python/cpython/commit/d64f3caebe8f8e31ecd193e0bd25105400153ece --

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Change by Dong-hee Na : -- pull_requests: +29522 pull_request: https://github.com/python/cpython/pull/31372 ___ Python tracker ___

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Dong-hee Na added the comment: New changeset e59309b9d0969d5c8f493cb8df28afa6f38d6273 by Dong-hee Na in branch 'main': bpo-46541: Remove usage of _Py_IDENTIFIER from dbms modules (GH-31358) https://github.com/python/cpython/commit/e59309b9d0969d5c8f493cb8df28afa6f38d6273 --

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Eric Snow added the comment: New changeset 4d8a515d193a4c9f3844704f974ddb870d7ee383 by Eric Snow in branch 'main': bpo-46541: Scan Fewer Files in generate_global_objects.py (gh-31364) https://github.com/python/cpython/commit/4d8a515d193a4c9f3844704f974ddb870d7ee383 --

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Eric Snow added the comment: New changeset 6c8958948666403f2370ca7b4c0a52b2010ec16d by Eric Snow in branch 'main': bpo-46541: Drop the check for orphaned global strings. (gh-31363) https://github.com/python/cpython/commit/6c8958948666403f2370ca7b4c0a52b2010ec16d --

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Change by Eric Snow : -- pull_requests: +29514 pull_request: https://github.com/python/cpython/pull/31364 ___ Python tracker ___

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Change by Eric Snow : -- pull_requests: +29513 pull_request: https://github.com/python/cpython/pull/31363 ___ Python tracker ___

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Change by Dong-hee Na : -- pull_requests: +29508 pull_request: https://github.com/python/cpython/pull/31358 ___ Python tracker ___

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Change by Dong-hee Na : -- nosy: +corona10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Change by Erlend E. Aasland : -- nosy: +erlendaasland nosy_count: 5.0 -> 6.0 pull_requests: +29500 pull_request: https://github.com/python/cpython/pull/31351 ___ Python tracker

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Eric Snow added the comment: New changeset 12360aa159c42c7798fd14225d271e6fd84db7eb by Eric Snow in branch 'main': bpo-46541: Discover the global strings. (gh-31346) https://github.com/python/cpython/commit/12360aa159c42c7798fd14225d271e6fd84db7eb --

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Change by Eric Snow : -- pull_requests: +29496 pull_request: https://github.com/python/cpython/pull/31346 ___ Python tracker ___

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Change by Eric Snow : -- pull_requests: +29494 pull_request: https://github.com/python/cpython/pull/31344 ___ Python tracker ___

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Eric Snow added the comment: With core code sorted out, stdlib and 3rd party extension modules are left to sort out. I see the following possibilities: 1. leave `_Py_IDENTIFIER()` alone (it is already disallowed in core code) 2. change `_Py_IDENTIFIER()` to create static string objects

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Change by Eric Snow : -- Removed message: https://bugs.python.org/msg413241 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Eric Snow added the comment: With core code sorted out, stdlib and 3rd party extension modules are left to sort out. I see the following possibilities: * leave `_Py_IDENTIFIER()` alone (it is already disallowed in core code) * change `_Py_IDENTIFIER()` to create static string objects (then

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Eric Snow added the comment: On Fri, Feb 11, 2022 at 1:36 AM Christoph Reiter wrote: > Sorry if off topic, but I noticed that CPython doesn't deprecate macros in > code, while with gcc/clang it's possible to show compiler warnings for them > using some pragma magic: > [snip] > Maybe that

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Christoph Reiter added the comment: Sorry if off topic, but I noticed that CPython doesn't deprecate macros in code, while with gcc/clang it's possible to show compiler warnings for them using some pragma magic: $ gcc a.c a.c: In function 'main': a.c:29:13: warning: Deprecated pre-processor

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Change by Kumar Aditya : -- pull_requests: +29428 pull_request: https://github.com/python/cpython/pull/31261 ___ Python tracker ___

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Eric Snow added the comment: New changeset 81c72044a181dbbfbf689d7a977d0d99090f26a8 by Eric Snow in branch 'main': bpo-46541: Replace core use of _Py_IDENTIFIER() with statically initialized global objects. (gh-30928)

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Eric Snow added the comment: (thanks Victor: https://mail.python.org/archives/list/python-...@python.org/message/7RMLIJHUWVBZFV747TFEHOE6LNBVQSMM/) 3rd party use of _Py_IDENTIFIER(): * blender +

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Eric Snow added the comment: FYI, I've posted to python-dev for feedback before proceeding: https://mail.python.org/archives/list/python-...@python.org/thread/DNMZAMB4M6RVR76RDZMUK2WRLI6KAAYS/ -- ___ Python tracker

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Eric Snow added the comment: If necessary, we can keep _Py_IDENTIFIER() (and the functions). Regardless, we can stop using it internally. -- ___ Python tracker ___

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

STINNER Victor added the comment: > `_Py_Identifier` has been useful but at this point there is a faster and > simpler approach we could take as a replacement: statically initialize the > objects as fields on `_PyRuntimeState` and reference them directly through a > macro. This change is

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Eric Snow added the comment: New changeset 247480a21cb165efdacc346a2d589dfc27e18283 by Eric Snow in branch 'main': bpo-46541: Generate the global objects initializer. (gh-30941) https://github.com/python/cpython/commit/247480a21cb165efdacc346a2d589dfc27e18283 --

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Change by Kumar Aditya : -- nosy: +kumaraditya303 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Change by Eric Snow : -- keywords: +patch pull_requests: +29120 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/30941 ___ Python tracker

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

Eric Snow added the comment: ## Background ## `_Py_Identifier` (and `_Py_IDENTIFIER()`, etc.) was added in 2011 [1][2] for several reasons: * provide a consistent approach for a common optimization: caching C-string based string objects * facilitate freeing those objects during runtime

[issue46541] Replace _Py_IDENTIFIER() with statically initialized objects.

New submission from Eric Snow : `_Py_Identifier` has been useful but at this point there is a faster and simpler approach we could take as a replacement: statically initialize the objects as fields on `_PyRuntimeState` and reference them directly through a macro. This would involve the