[issue46850] [C API] Move _PyEval_EvalFrameDefault() to the internal C API

[STINNER Victor]

STINNER Victor  added the comment:

The change was rejected by the Steering Council:
https://mail.python.org/archives/list/python-...@python.org/message/GFOMU7LP63JUVFMWNJNZJLUMZDRPTUYJ/

--
resolution:  -> rejected
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46850] [C API] Move _PyEval_EvalFrameDefault() to the internal C API

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 2b4f2f5fa4d1123c19bf0643cfa5a4fe8df4175c by Victor Stinner in 
branch 'main':
Revert "bpo-46850: Move _PyEval_EvalFrameDefault() to internal C API 
(GH-32052)" (GH-32343)
https://github.com/python/cpython/commit/2b4f2f5fa4d1123c19bf0643cfa5a4fe8df4175c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46850] [C API] Move _PyEval_EvalFrameDefault() to the internal C API

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +30397
pull_request: https://github.com/python/cpython/pull/32343

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46850] [C API] Move _PyEval_EvalFrameDefault() to the internal C API

[Gregory P. Smith]

Gregory P. Smith  added the comment:

per 
https://mail.python.org/archives/list/python-...@python.org/message/GFOMU7LP63JUVFMWNJNZJLUMZDRPTUYJ/
 lets roll some of those PRs back and reshape where we move these APIs as 
despite the PEP they were not as private as other privates.

(deferred blocker meaning: block 3.11beta1 - though Pablo could decide to have 
the rollbacks block 3.11alpha7)

--
nosy: +gregory.p.smith, pablogsal
priority: normal -> deferred blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46850] [C API] Move _PyEval_EvalFrameDefault() to the internal C API

[STINNER Victor]

STINNER Victor  added the comment:


New changeset f877b40e3f7e0d97878884d80fbec879a85ab7e8 by Victor Stinner in 
branch 'main':
bpo-46850: Move _PyInterpreterState_SetEvalFrameFunc() to internal C API 
(GH-32054)
https://github.com/python/cpython/commit/f877b40e3f7e0d97878884d80fbec879a85ab7e8


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46850] [C API] Move _PyEval_EvalFrameDefault() to the internal C API

[STINNER Victor]

STINNER Victor  added the comment:


New changeset b9a5522dd952125a99ff554f01f311cae25f5a91 by Victor Stinner in 
branch 'main':
bpo-46850: Move _PyEval_EvalFrameDefault() to internal C API (GH-32052)
https://github.com/python/cpython/commit/b9a5522dd952125a99ff554f01f311cae25f5a91


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46850] [C API] Move _PyEval_EvalFrameDefault() to the internal C API

[Itamar Ostricher]

Change by Itamar Ostricher :


--
nosy: +itamaro

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46850] [C API] Move _PyEval_EvalFrameDefault() to the internal C API

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +30144
pull_request: https://github.com/python/cpython/pull/32054

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46850] [C API] Move _PyEval_EvalFrameDefault() to the internal C API

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +30141
pull_request: https://github.com/python/cpython/pull/32052

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46850] [C API] Move _PyEval_EvalFrameDefault() to the internal C API

[STINNER Victor]

STINNER Victor  added the comment:


New changeset e63894b3eed8ad2dd7690695f7f07bfbff59c05a by Victor Stinner in 
branch 'main':
bpo-46850: Remove _PyEval_CallTracing() function (GH-32019)
https://github.com/python/cpython/commit/e63894b3eed8ad2dd7690695f7f07bfbff59c05a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46850] [C API] Move _PyEval_EvalFrameDefault() to the internal C API

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +30107
pull_request: https://github.com/python/cpython/pull/32019

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46850] [C API] Move _PyEval_EvalFrameDefault() to the internal C API

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 9087243e2c167e38570e819b228efc3492c38c9c by Victor Stinner in 
branch 'main':
bpo-46850: Remove _PyEval_GetCoroutineOriginTrackingDepth() (GH-32018)
https://github.com/python/cpython/commit/9087243e2c167e38570e819b228efc3492c38c9c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46850] [C API] Move _PyEval_EvalFrameDefault() to the internal C API

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +30106
pull_request: https://github.com/python/cpython/pull/32018

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46850] [C API] Move _PyEval_EvalFrameDefault() to the internal C API

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 332b04bac35cd7305c60da2d5733940dc089949a by Victor Stinner in 
branch 'main':
bpo-46850: Remove _PyEval_SetAsyncGenFinalizer() (GH-32017)
https://github.com/python/cpython/commit/332b04bac35cd7305c60da2d5733940dc089949a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46850] [C API] Move _PyEval_EvalFrameDefault() to the internal C API

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +30105
pull_request: https://github.com/python/cpython/pull/32017

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46850] [C API] Move _PyEval_EvalFrameDefault() to the internal C API

[Brandt Bucher]

Change by Brandt Bucher :


--
nosy: +brandtbucher

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46850] [C API] Move _PyEval_EvalFrameDefault() to the internal C API

[STINNER Victor]

STINNER Victor  added the comment:

See also bpo-46836: "[C API] Move PyFrameObject to the internal C API".

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46850] [C API] Move _PyEval_EvalFrameDefault() to the internal C API

[STINNER Victor]

Change by STINNER Victor :


--
keywords: +patch
pull_requests: +29676
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/31532

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46850] [C API] Move _PyEval_EvalFrameDefault() to the internal C API

[STINNER Victor]

STINNER Victor  added the comment:

typo: "I propose to move most _PyEval private functions to the internal C API 
to clarify that they must *NOT* be used." :-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue46850] [C API] Move _PyEval_EvalFrameDefault() to the internal C API

[STINNER Victor]

New submission from STINNER Victor :

In Python 3.10, _PyEval_EvalFrameDefault() has the API:

PyObject* _PyEval_EvalFrameDefault(PyThreadState *tstate, PyFrameObject *f, int 
throwflag);

In Python 3.11, bpo-44590 (commit ae0a2b756255629140efcbe57fc2e714f0267aa3 
"Lazily allocate frame objects (GH-27077)") changed it to:

PyObject* _PyEval_EvalFrameDefault(PyThreadState *tstate, InterpreterFrame 
*frame, int throwflag);

Problem: InterpreterFrame is part of the internal C API.

By the way, PyInterpreterState.eval_frame type (_PyFrameEvalFunction) also 
changed. This field type already changed in Python 3.9:

* ``PyInterpreterState.eval_frame`` (:pep:`523`) now requires a new mandatory
  *tstate* parameter (``PyThreadState*``).
  (Contributed by Victor Stinner in :issue:`38500`.)

Maybe the Python 3.11 change should be documented in What's New in Python 3.11, 
as it was in What's New in Python 3.9.


I propose to move most _PyEval private functions to the internal C API to 
clarify that they must be used.

--
components: C API
messages: 413918
nosy: vstinner
priority: normal
severity: normal
status: open
title: [C API] Move _PyEval_EvalFrameDefault() to the internal C API
versions: Python 3.11

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com