[issue46920] Remove code made dead long ago with #if 0

STINNER Victor added the comment: Thanks Oleg Iarygin for the cleanup! -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue46920] Remove code made dead long ago with #if 0

Change by Oleg Iarygin : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue46920] Remove code made dead long ago with #if 0

STINNER Victor added the comment: Can this issue be closed? Or is there remaining dead code that you want to remove? -- ___ Python tracker ___

[issue46920] Remove code made dead long ago with #if 0

STINNER Victor added the comment: New changeset 13b041222399152acb555337572bd1d571734984 by Oleg Iarygin in branch 'main': bpo-46920: Remove code that has explainers why it was disabled (GH-31813) https://github.com/python/cpython/commit/13b041222399152acb555337572bd1d571734984 --

[issue46920] Remove code made dead long ago with #if 0

STINNER Victor added the comment: New changeset a52f82baf246e2fbbc58fe03ef7a51f3cc9514e1 by Oleg Iarygin in branch 'main': bpo-46920: Remove disabled debug code added decades ago and likely unnecessary (GH-31812)

[issue46920] Remove code made dead long ago with #if 0

STINNER Victor added the comment: New changeset e885ac3d5f2fd83617ab75a098aab269b7a446c3 by Oleg Iarygin in branch 'main': bpo-46920: Remove code that has no explainer why it was disabled (GH-31814) https://github.com/python/cpython/commit/e885ac3d5f2fd83617ab75a098aab269b7a446c3

[issue46920] Remove code made dead long ago with #if 0

Change by Oleg Iarygin : -- pull_requests: +29912 pull_request: https://github.com/python/cpython/pull/31814 ___ Python tracker ___

[issue46920] Remove code made dead long ago with #if 0

Change by Oleg Iarygin : -- pull_requests: +29911 pull_request: https://github.com/python/cpython/pull/31813 ___ Python tracker ___

[issue46920] Remove code made dead long ago with #if 0

Change by Oleg Iarygin : -- pull_requests: +29910 pull_request: https://github.com/python/cpython/pull/31812 ___ Python tracker ___

[issue46920] Remove code made dead long ago with #if 0

Change by Oleg Iarygin : -- pull_requests: +29909 pull_request: https://github.com/python/cpython/pull/31811 ___ Python tracker ___

[issue46920] Remove code made dead long ago with #if 0

Oleg Iarygin added the comment: I reverted my changes in Modules/_ctypes/libffi_osx/x86/x86-ffi64.c and Modules/_decimal/libmpdec/*step.c to not disturb third-party vendored libraries. As a result, macOS component is no longer affected along with the corresponding experts in a nosy list.

[issue46920] Remove code made dead long ago with #if 0

Change by Mark Dickinson : -- nosy: +mark.dickinson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue46920] Remove code made dead long ago with #if 0

Oleg Iarygin added the comment: Also forgot to add that git grep "#if 1" gives the following: - added on 20 Nov 2014 by d600951: cpython/Python/pylifecycle.c:2427. "/* Disable this if you have trouble debugging bootstrap stuff */" - after seven years, no trouble was found so this

[issue46920] Remove code made dead long ago with #if 0

Change by Oleg Iarygin : -- keywords: +patch pull_requests: +29800 stage: -> patch review pull_request: https://github.com/python/cpython/pull/31681 ___ Python tracker ___

[issue46920] Remove code made dead long ago with #if 0

New submission from Oleg Iarygin : `git grep "#if 0"` gives the following occurences of dead code (analyzed with `git blame`, removed by a linked pull request): - added on 27 Apr 2020 by 2b74c83: Parser/pegen.h:9, Parser/pegen.h:15. Since these constants aren't mentioned anywhere else, I