[issue4885] mmap enhancement request
Antoine Pitrou added the comment: Your patch is now committed. Thanks for contributing! -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4885 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4885] mmap enhancement request
Roundup Robot added the comment: New changeset 1754b7900da1 by Antoine Pitrou in branch 'default': Issue #4885: Add weakref support to mmap objects. Patch by Valerie Lambert. http://hg.python.org/cpython/rev/1754b7900da1 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4885 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4885] mmap enhancement request
Changes by Antoine Pitrou pit...@free.fr: -- stage: needs patch - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4885 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4885] mmap enhancement request
Antoine Pitrou added the comment: Thanks Valerie. I've tested your patch and it looks good to me. Have you signed and sent a contributor's agreement? http://www.python.org/psf/contrib/ -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4885 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4885] mmap enhancement request
Valerie Lambert added the comment: I just signed and sent the agreement electronically. Let me know if there is anything else I need to do. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4885 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4885] mmap enhancement request
Valerie Lambert added the comment: I've uploaded a patch to make mmap_obj support weakref. A test is included in the patch. -- keywords: +patch nosy: +lambertv Added file: http://bugs.python.org/file31115/issue-4885.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4885 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4885] mmap enhancement request
Christian Heimes added the comment: 1) and 2) have been fixed in Python 3.x. mmap supports writable memory views and slice assignment from any object that supports the buffer protocol. 3) is still an issue as mmap objects are not weakref-able yet. It should be easy to add __weakref__ to mmap objects. -- components: +Extension Modules -Library (Lib) nosy: +christian.heimes priority: normal - low stage: test needed - needs patch versions: +Python 3.4 -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4885 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4885] mmap enhancement request
Christian Heimes added the comment: It's a trivial task for any Python developer with some C experience. -- keywords: +easy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4885 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4885] mmap enhancement request
Changes by Terry J. Reedy tjre...@udel.edu: -- stage: - unit test needed versions: +Python 3.2 -Python 2.7, Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4885 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4885] mmap enhancement request
New submission from ndbecker ndbeck...@gmail.com: I'd like to suggest some improvements from mmap 1) mmap assign to slice only accepts a string. This is unfortunate, because AFAIK a string can only be created by copying data, and this is wasteful for large data transfers. mmap should accept any object supporting buffer protocol as well as string. 2) buffer (mmap_obj) gives a read_only buffer. There should be a way to make this read_write. I suggest 'as_buffer' member. 3) mmap_obj does not support weak ref. This is needed for proper lifetime management using boost::python -- components: Library (Lib) messages: 79433 nosy: ndbecker severity: normal status: open title: mmap enhancement request type: feature request versions: Python 2.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4885 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4885] mmap enhancement request
Antoine Pitrou pit...@free.fr added the comment: As for 2), the buffer() function is deprecated and is replaced in 3.0 by new object called memoryview() (together with a revamped internal API for taking and releasing buffers). -- nosy: +pitrou priority: - normal versions: +Python 2.7, Python 3.1 -Python 2.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4885 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
