[issue4945] json checks True/False by identity, not boolean value

Serhiy Storchaka added the comment: Thanks Raymond. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue4945] json checks True/False by identity, not boolean value

Roundup Robot added the comment: New changeset 8f1d3ebdbc56 by Serhiy Storchaka in branch '2.7': Issue #4945: Improved the documenting of boolean arguments in the json module. https://hg.python.org/cpython/rev/8f1d3ebdbc56 New changeset 324b061ce220 by Serhiy Storchaka in branch '3.5': Issue

[issue4945] json checks True/False by identity, not boolean value

Raymond Hettinger added the comment: These latest two patches look fine. Go ahead with them. -- ___ Python tracker ___

[issue4945] json checks True/False by identity, not boolean value

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file43512/json_doc_truefalse-2.7_2.patch ___ Python tracker ___

[issue4945] json checks True/False by identity, not boolean value

Serhiy Storchaka added the comment: Updated patches are synchronized with current sources and address Ezio's comments (sorry for the delay Ezio, I missed your comments). -- versions: +Python 3.6 -Python 3.4 Added file: http://bugs.python.org/file43511/json_doc_truefalse_3.patch

[issue4945] json checks True/False by identity, not boolean value

Serhiy Storchaka added the comment: This issue is about boolean parameters, not boolean serialized values. Please open new issue for your problem Mark. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4945

[issue4945] json checks True/False by identity, not boolean value

Mark Mikofski added the comment: This is effecting IronPython as well, because .NET objects return copies not references. If a .NET assembly method is called from IronPython, its return is a copy, not a reference. Therefore the reference of a boolean return is not the same as the internal

[issue4945] json checks True/False by identity, not boolean value

Changes by Serhiy Storchaka storch...@gmail.com: -- versions: +Python 3.5 -Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4945 ___ ___

[issue4945] json checks True/False by identity, not boolean value

Changes by Mark Lawrence breamore...@yahoo.co.uk: -- nosy: -BreamoreBoy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4945 ___ ___

[issue4945] json checks True/False by identity, not boolean value

Serhiy Storchaka added the comment: See also issue19795 which contains much larger patch for other modules. -- versions: -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4945 ___

[issue4945] json checks True/False by identity, not boolean value

Serhiy Storchaka added the comment: Updated to tip. -- nosy: +georg.brandl Added file: http://bugs.python.org/file33063/json_doc_truefalse_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4945

[issue4945] json checks True/False by identity, not boolean value

Mark Dickinson added the comment: According to the experts index, Bob is no longer actively maintaining the module. -- assignee: bob.ippolito - ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4945

[issue4945] json checks True/False by identity, not boolean value

Zearin added the comment: Note: Javascript has something analogous to Python’s ``==`` and ``is``. In JS: 0 == false true 0 === false false 1 == true true 1 === true false Perhaps this discrepancy could be fixed in the JSON processing? -- nosy: +zearin

[issue4945] json checks True/False by identity, not boolean value

R. David Murray added the comment: I would be very careful trying to reason by analogy there. ==, is, and javascripts === are rather different in detail, from what I understand. Nor do I see what javascript has to do with this issue :) As far as the remaining documentation issue here, IMO

[issue4945] json checks True/False by identity, not boolean value

Chris Jerdonek added the comment: Ezio told me my previous comment was hard to understand. For the record, what I meant was that if you have a statement like, If *allow_nan* is ``True``, then Otherwise, ..., then this can be read to mean that something like 1 for *allow_nan* would be

[issue4945] json checks True/False by identity, not boolean value

Mark Dickinson added the comment: Changing If *allow_nan* is ``True`` to equals ``True`` I don't think that's any more accurate. Many Python objects are 'true' but not equal to 'True' (e.g., nonempty collections). -- ___ Python tracker

[issue4945] json checks True/False by identity, not boolean value

Chris Jerdonek added the comment: You're right. My mistake. :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4945 ___ ___ Python-bugs-list

[issue4945] json checks True/False by identity, not boolean value

anatoly techtonik added the comment: On Tue, Nov 27, 2012 at 12:15 AM, Ezio Melotti rep...@bugs.python.orgwrote: I'm not sure the documentation should be changed. While boolean values are accepted, user should prefer True/False, so the fact that you can pass other things shouldn't be

[issue4945] json checks True/False by identity, not boolean value

Mark Dickinson added the comment: user should prefer True/False I disagree: I don't see any reason why the normal duck-typing rules shouldn't hold here. So +1 for the documentation changes from me. -- nosy: +mark.dickinson ___ Python tracker

[issue4945] json checks True/False by identity, not boolean value

Ezio Melotti added the comment: I don't see any reason why the normal duck-typing rules shouldn't hold here. The rules should apply, the only problem is in the documentation. The documentation here could answer two questions: 1) what should I pass to these args to make them work? 2) can I

[issue4945] json checks True/False by identity, not boolean value

Changes by Serhiy Storchaka storch...@gmail.com: -- nosy: +chris.jerdonek ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4945 ___ ___

[issue4945] json checks True/False by identity, not boolean value

Chris Jerdonek added the comment: On the whole, the patch looks okay to me. I think we should strive for correctness in the documentation where possible. While keeping True would keep the forward implications correct and document the preferred value, there is often an implied assumption

[issue4945] json checks True/False by identity, not boolean value

Ezio Melotti added the comment: I'm not sure the documentation should be changed. While boolean values are accepted, user should prefer True/False, so the fact that you can pass other things shouldn't be documented/advertized IMHO. The patch has a couple of other changes that could be

[issue4945] json checks True/False by identity, not boolean value

Serhiy Storchaka added the comment: Docstrings already changed to true/false instead True/False. Almost, some places were forgotten. The patch mainly changes the ReST documentation to conform docstrings. -- ___ Python tracker rep...@bugs.python.org

[issue4945] json checks True/False by identity, not boolean value

anatoly techtonik added the comment: +1 for all branches. Is that handling of booleans PEPified somewhere? -- nosy: +techtonik ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4945 ___

[issue4945] json checks True/False by identity, not boolean value

Serhiy Storchaka added the comment: Actually most proposed changes were already committed, only the documentation left. Here is an updated and fixed patch for 3.x. -- components: +Documentation -Library (Lib) nosy: +serhiy.storchaka versions: +Python 3.4 Added file:

[issue4945] json checks True/False by identity, not boolean value

Changes by Serhiy Storchaka storch...@gmail.com: Added file: http://bugs.python.org/file28120/json_doc_truefalse-2.7.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4945 ___

[issue4945] json checks True/False by identity, not boolean value

Éric Araujo mer...@netwok.org added the comment: I agree with the request. I don’t know if this behavior change can go into stable versions; Raymond will decide, as Bob seems to have retired from the maintenance of stdlib json. -- nosy: +eric.araujo, ezio.melotti, rhettinger

[issue4945] json checks True/False by identity, not boolean value

Changes by Amirouche Boubekki amirouche.boube...@gmail.com: -- nosy: +abki ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4945 ___ ___

[issue4945] json checks True/False by identity, not boolean value

Changes by Florent Xicluna florent.xicl...@gmail.com: -- nosy: +flox versions: +Python 3.3 -Python 2.6, Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4945 ___

[issue4945] json checks True/False by identity, not boolean value

Mark Lawrence breamore...@yahoo.co.uk added the comment: Successfully ran test_json for Python 2.6.5 on Windows Vista. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4945 ___

[issue4945] json checks True/False by identity, not boolean value

Mark Lawrence breamore...@yahoo.co.uk added the comment: Successfully ran test_json for Python 2.6.5 on Windows Vista. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4945 ___

[issue4945] json checks True/False by identity, not boolean value

Mark Lawrence breamore...@yahoo.co.uk added the comment: As a patch has been provided can't this be moved forward? The Python versions also need updating. -- nosy: +BreamoreBoy ___ Python tracker rep...@bugs.python.org

[issue4945] json checks True/False by identity, not boolean value

R. David Murray rdmur...@bitdance.com added the comment: Most likely we are waiting for Bob's review. Have you tested the patch? -- nosy: +r.david.murray stage: - patch review versions: +Python 3.2 -Python 3.0 ___ Python tracker

[issue4945] json checks True/False by identity, not boolean value

New submission from Gabriel Genellina gagsl-...@yahoo.com.ar: json compares arguments against True/False by identity, not by boolean value; by example: if (skipkeys is False and ensure_ascii is True and check_circular is True and allow_nan is True ... Using `ensure_ascii=1` won't

[issue4945] json checks True/False by identity, not boolean value

Changes by Gabriel Genellina gagsl-...@yahoo.com.ar: -- keywords: +patch Added file: http://bugs.python.org/file12736/json.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4945 ___