[issue5306] Python 3.1 won't compile under Visual Studio 2005

2009-02-19 Thread Kristján Valur Jónsson

Kristján Valur Jónsson krist...@ccpgames.com added the comment:

Ah, I just saw this.  Yes, looks like a missing file during porting.  
That should affect VS2008 as well.  Cheers!

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5306
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5306] Python 3.1 won't compile under Visual Studio 2005

2009-02-19 Thread Benjamin Peterson

Benjamin Peterson benja...@python.org added the comment:

Could one of the Windows experts do the port? I can't properly resolve
the conflicts or test the changes here.

--
assignee: benjamin.peterson - 

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5306
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5306] Python 3.1 won't compile under Visual Studio 2005

2009-02-19 Thread Amaury Forgeot d'Arc

Changes by Amaury Forgeot d'Arc amaur...@gmail.com:


--
assignee:  - amaury.forgeotdarc
nosy: +amaury.forgeotdarc

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5306
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5306] Python 3.1 won't compile under Visual Studio 2005

2009-02-19 Thread Amaury Forgeot d'Arc

Amaury Forgeot d'Arc amaur...@gmail.com added the comment:

I merged the change manually, and came to the same patch as ocean-city;

Then I noticed that os.device_encoding() (new in python 3.0) needs the 
same check as well.

--
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5306
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5306] Python 3.1 won't compile under Visual Studio 2005

2009-02-18 Thread Raymond Hettinger

New submission from Raymond Hettinger rhettin...@users.sourceforge.net:

This started happening a few days ago, about when Benjamin forward
ported r69560 .  There is an #ifdef in fileobject.h that makes a header
for int _PyVerify_fd(int fd) but does not define it.  It is likely
related to r69495 .

_fileio.obj : error LNK2019: unresolved external symbol __PyVerify_fd
referenced in function _check_fd
C:\py31\PC\VS8.0\\python31_d.dll : fatal error LNK1120: 1 unresolved
externals

--
assignee: loewis
components: Interpreter Core
messages: 82435
nosy: loewis, rhettinger
priority: high
severity: normal
status: open
title: Python 3.1 won't compile under Visual Studio 2005
type: compile error
versions: Python 3.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5306
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5306] Python 3.1 won't compile under Visual Studio 2005

2009-02-18 Thread Martin v. Löwis

Martin v. Löwis mar...@v.loewis.de added the comment:

I don't feel responsible for VS2005 support. Unassigning myself.

--
assignee: loewis - 

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5306
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5306] Python 3.1 won't compile under Visual Studio 2005

2009-02-18 Thread Raymond Hettinger

Raymond Hettinger rhettin...@users.sourceforge.net added the comment:

Kristan, I think this is yours.

--
assignee:  - krisvale
nosy: +krisvale

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5306
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5306] Python 3.1 won't compile under Visual Studio 2005

2009-02-18 Thread Hirokazu Yamamoto

Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment:

I think change for posixmodule.c is missing from r69495. (I confirmed
other merges don't include posixmodule.c modification)

Attached patch will fix this. (I don't have VS2005 or later, so I cannot
test this on my machine)

--
keywords: +patch
nosy: +ocean-city
Added file: http://bugs.python.org/file13134/fix_posixmodule.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5306
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5306] Python 3.1 won't compile under Visual Studio 2005

2009-02-18 Thread Hirokazu Yamamoto

Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment:

And I think r69268 should be merged too.

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5306
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5306] Python 3.1 won't compile under Visual Studio 2005

2009-02-18 Thread Raymond Hettinger

Raymond Hettinger rhettin...@users.sourceforge.net added the comment:

Benjamin, please use this patch to complete the merge.

--
assignee: krisvale - benjamin.peterson
nosy: +benjamin.peterson

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5306
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5306] Python 3.1 won't compile under Visual Studio 2005

2009-02-18 Thread Raymond Hettinger

Changes by Raymond Hettinger rhettin...@users.sourceforge.net:


--
priority: high - critical

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5306
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com