[issue5588] Add --randseed to regrtest
Mark Dickinson dicki...@gmail.com added the comment: Should this get a Misc/NEWS entry? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5588 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5588] Add --randseed to regrtest
New submission from Collin Winter coll...@gmail.com: Add the ability to control the random seed used by regrtest.py -r. This patch adds a --randseed option, and makes regrtest.py -r indicate what random seed it's using so that that value can later be fed back to --randseed. This option is useful for tracking down test order-related issues found by make buildbottest, for example. -- components: Tests files: randseed.patch keywords: needs review, patch messages: 84322 nosy: collinwinter severity: normal stage: patch review status: open title: Add --randseed to regrtest type: feature request versions: Python 2.7 Added file: http://bugs.python.org/file13446/randseed.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5588 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5588] Add --randseed to regrtest
Mark Dickinson dicki...@gmail.com added the comment: +1 on the idea. I'm not sure I understand the patch, though. If the line: random_seed = int(100 * random.random()) produces a random_seed of 0 (or if randseed=0 is supplied as an option), it looks as though random.seed is never called; is this intentional? Also, not that it really matters, but why do you use the expression above instead of the simpler random.randrange(100)? -- nosy: +marketdickinson ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5588 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5588] Add --randseed to regrtest
Antoine Pitrou pit...@free.fr added the comment: +1 here too. -- nosy: +pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5588 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5588] Add --randseed to regrtest
Changes by Collin Winter coll...@gmail.com: Removed file: http://bugs.python.org/file13446/randseed.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5588 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5588] Add --randseed to regrtest
Collin Winter coll...@gmail.com added the comment: The if rand_seed: bit was a relic from a previous iteration; fixed. The only reason I didn't use randrange() is that I didn't see it; fixed. -- Added file: http://bugs.python.org/file13448/randseed.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5588 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5588] Add --randseed to regrtest
Mark Dickinson dicki...@gmail.com added the comment: Updated patch looks good to me. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5588 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5588] Add --randseed to regrtest
Collin Winter coll...@gmail.com added the comment: Committed as r70672 (trunk) and r70673 (py3k). Thanks for the quick review. -- resolution: - accepted status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5588 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
