[issue7291] urllib2 cannot handle https with proxy requiring auth

Alexey Namyotkin added the comment: It has been 5 years, now the urllib3 is actively used, but it also inherited this problem: if no authentication data has been received, then the method _tunnel raises an exception OSError that does not contain response headers. Accordingly, this exception

[issue7291] urllib2 cannot handle https with proxy requiring auth

Change by Jessica Ridgley : -- nosy: +Jessica Ridgley versions: +Python 3.10, Python 3.8, Python 3.9 ___ Python tracker ___ ___

[issue7291] urllib2 cannot handle https with proxy requiring auth

Change by Alexey Namyotkin : -- nosy: +alexey.namyotkin ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue7291] urllib2 cannot handle https with proxy requiring auth

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue7291] urllib2 cannot handle https with proxy requiring auth

Chi Hsuan Yen added the comment: Modify target versions to bugfix and feature branches -- versions: +Python 3.7 -Python 2.6, Python 3.4 ___ Python tracker

[issue7291] urllib2 cannot handle https with proxy requiring auth

Changes by Chi Hsuan Yen : -- nosy: +Chi Hsuan Yen ___ Python tracker ___ ___

[issue7291] urllib2 cannot handle https with proxy requiring auth

Martin Panter added the comment: For the record, a while ago I think I made a patch implementing my HTTPConnection.detach() proposal. I can probably dig it up if anyone is interested. However I gave up on fixing this bug in “urllib.request”. As far as I understand it, the framework does not

[issue7291] urllib2 cannot handle https with proxy requiring auth

Martin Panter added the comment: I believe this also affects Python 3; see Issue 24333. I think making the CONNECT response object available to the caller is the right general approach. But I really dislike raising an exception that holds a socket connection to be closed. (I know this is

[issue7291] urllib2 cannot handle https with proxy requiring auth

Mark Lawrence added the comment: Is there any work still needed here? Surely the 2.6.x patches can't be applied unless there are security issues? -- nosy: +BreamoreBoy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7291

[issue7291] urllib2 cannot handle https with proxy requiring auth

Vackar Afzal added the comment: I've found that for the Python2.6.x patch to play nicely with the popular rquests library, I've had to set some defaults on the modified __init__ function so that it reads as follows: def __init__(self, *args, **kwargs): _orig_init(self, *args,

[issue7291] urllib2 cannot handle https with proxy requiring auth

Vackar Afzal added the comment: Also needed to make another minor update to the monkey patch. Have uploaded the new files as new_http_proxy_patch.py for use with python 2.6.x -- Added file: http://bugs.python.org/file34174/new_http_proxy_patch.py ___

[issue7291] urllib2 cannot handle https with proxy requiring auth

Barry Scott barry.sc...@onelan.co.uk added the comment: The attached patch builds on Mike's work. The core of the problem is that the Request object did not know what was going on. This means that it was not possible for get_authorization() to work for proxy-auth and www-auth. I change Request

[issue7291] urllib2 cannot handle https with proxy requiring auth

Barry Scott barry.sc...@onelan.co.uk added the comment: Attached is the code I used to test these changes. See the README.txt file for details include the results of a test run. -- Added file: http://bugs.python.org/file20822/urllib2_tests.tar.gz ___

[issue7291] urllib2 cannot handle https with proxy requiring auth

Barry Scott barry.sc...@onelan.co.uk added the comment: I left out some white space changes to match the style of the std lib code. Re posting with white space cleanup. -- Added file: http://bugs.python.org/file20824/http_proxy_https.patch ___ Python

[issue7291] urllib2 cannot handle https with proxy requiring auth

Changes by Barry Scott barry.sc...@onelan.co.uk: Removed file: http://bugs.python.org/file20821/http_proxy_https.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7291 ___

[issue7291] urllib2 cannot handle https with proxy requiring auth

Mike Beachy mbea...@gmail.com added the comment: I've been in contact w/ Barry Scott offline re: the monkey patch previously mentioned. I'm attaching a 2.7 maintenance branch patch that he has needed to extend, and plans to follow up on. -- Added file:

[issue7291] urllib2 cannot handle https with proxy requiring auth

Mike Beachy mbea...@gmail.com added the comment: Attached to this comment (can you attach multiple files at once?) is the somewhat moldy 2.6.4 monkey patch, mercilessly ripped from my own code and probably not good for much. -- Added file:

[issue7291] urllib2 cannot handle https with proxy requiring auth

Mike Beachy mbea...@gmail.com added the comment: I have worked up a monkey patch for urllib2/httplib for the issue of setting the authentication using a Proxy(Basic|Digest)AuthHandler. The basic approach was to create a new httplib exception (ProxyTunnelError) and raise that with the http

[issue7291] urllib2 cannot handle https with proxy requiring auth

Senthil Kumaran orsent...@gmail.com added the comment: In this ticket, setting the authentication using a ProxyBasicAuthHandler is not yet addressed yet. (this was informed in the last note). Reopening this one to track it. -- resolution: fixed - accepted status: closed - open

[issue7291] urllib2 cannot handle https with proxy requiring auth

Manuel Muradás mmura...@dieresys.com.ar added the comment: Hi! 2.6 backport is missing an argument in _set_tunnel definition. It should be: def _set_tunnel(self, host, port=None, headers=None): -- nosy: +dieresys ___ Python tracker

[issue7291] urllib2 cannot handle https with proxy requiring auth

Manuel Muradás mmura...@dieresys.com.ar added the comment: The patch fixes only when you pass the authentication info in the proxy handler's URL. Like: proxy_handler = urllib2.ProxyHandler({'https': 'http://user:p...@proxy-example.com:3128/'}) But setting the authentication using a

[issue7291] urllib2 cannot handle https with proxy requiring auth

Senthil Kumaran orsent...@gmail.com added the comment: Thanks for the note, Manuel. Fixed it in revision 77013. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7291 ___

[issue7291] urllib2 cannot handle https with proxy requiring auth

Senthil Kumaran orsent...@gmail.com added the comment: Fixed and Committed revision 76908 in the trunk. -- keywords: -needs review resolution: accepted - fixed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7291

[issue7291] urllib2 cannot handle https with proxy requiring auth

Senthil Kumaran orsent...@gmail.com added the comment: Fixed through reversions r76908, r76909, r76910, r76911 Thanks for the patch, Tatsuhiro Tsujikawa. -- status: open - closed ___ Python tracker rep...@bugs.python.org

[issue7291] urllib2 cannot handle https with proxy requiring auth

Ronald Oussoren ronaldousso...@mac.com added the comment: The patch looks good to me. IMHO this should be backported to 2.6 as well. -- keywords: +needs review nosy: +ronaldoussoren ___ Python tracker rep...@bugs.python.org

[issue7291] urllib2 cannot handle https with proxy requiring auth

Ronald Oussoren ronaldousso...@mac.com added the comment: I've tested a backport of the patch to 2.6 (just replace set_proxy by _set_proxy in the patch) and the resulting version of urllib2 can login to the proxy (as expected). Thanks for the patch. --

[issue7291] urllib2 cannot handle https with proxy requiring auth

Changes by Senthil Kumaran orsent...@gmail.com: -- assignee: - orsenthil nosy: +orsenthil resolution: - accepted ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7291 ___

[issue7291] urllib2 cannot handle https with proxy requiring auth

Changes by Tatsuhiro Tsujikawa tsujik...@gp.hitachi.co.jp: -- versions: +Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7291 ___ ___

[issue7291] urllib2 cannot handle https with proxy requiring auth

New submission from Tatsuhiro Tsujikawa tsujik...@gp.hitachi.co.jp: urllib2 cannot handle https with proxy requiring authorization. After https_proxy is set correctly, Python 2.6.4 (r264:75706, Oct 29 2009, 15:38:25) [GCC 4.4.1] on linux2 Type help, copyright, credits or license for more

[issue7291] urllib2 cannot handle https with proxy requiring auth

Tatsuhiro Tsujikawa tsujik...@gp.hitachi.co.jp added the comment: I created a patch. I added additional argument 'headers' to HTTPConnection::set_tunnel() method, which is a mapping of HTTP headers to sent with CONNECT method. Since authorization credential is already set to Request object, in