[issue809163] Can't add files with spaces under bdist_rpm

2021-02-03 Thread Steve Dower
Steve Dower added the comment: Distutils is now deprecated (see PEP 632) and all tagged issues are being closed. From now until removal, only release blocking issues will be considered for distutils. If this issue does not relate to distutils, please remove the component and reopen it. If

[issue809163] Can't add files with spaces under bdist_rpm

2014-04-05 Thread Jason R. Coombs
Jason R. Coombs added the comment: In issue21153, I explored this problem as well, before being aware of this issue. I had searched for bdist_rpm. I've since confirmed that the sed approach is viable. For example, the following works around the issue by overriding the install_script with the

[issue809163] Can't add files with spaces under bdist_rpm

2014-04-05 Thread Jason R. Coombs
Jason R. Coombs added the comment: I decided to test my proposition. It seems that simply specifying / for %files leads to the RPM including parent directories. Here's the output I get when running my test with the sed workaround: $ rpm -q -filesbypkg -p

[issue809163] Can't add files with spaces

2014-03-12 Thread Éric Araujo
Éric Araujo added the comment: Previous comment: “If there is a way to make rpm read one line at a time, we should use it.” If there isn’t such an option, and if sed is guaranteed to be installed on rpm-based systems, we can try the sed script. --

[issue809163] Can't add files with spaces

2014-03-08 Thread Matheus Vieira Portela
Matheus Vieira Portela added the comment: As far as I noticed, in bdist_rpm.py, the _make_spec_file() method generates an .spec file for RPM build and attaches the install script to setup.py install -O1 --root=$RPM_BUILD_ROOT --record=INSTALLED_FILES. Later, the .spec refers to the record

[issue809163] Can't add files with spaces

2014-03-07 Thread Éric Araujo
Éric Araujo added the comment: Yes, this issue is not addressed. A test is added by the latest patch and reproduces the issue; now bdist_rpm should be changed to make the test pass. See also my previous comment. -- components: -Distutils2 stage: patch review - needs patch versions:

[issue809163] Can't add files with spaces

2014-03-07 Thread Matheus Vieira Portela
Matheus Vieira Portela added the comment: I tried to apply the last patch but it returned me and error of failing hunk. I think it was based on an old version of the test_bdist_rpm.py file. Hence, I made this updated version of the patch and could get the expected failure during the tests. I

[issue809163] Can't add files with spaces

2014-03-06 Thread Matheus Vieira Portela
Matheus Vieira Portela added the comment: Is this issue still going on? -- nosy: +matheus.v.portela ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue809163 ___

[issue809163] Can't add files with spaces

2011-01-07 Thread xiscu
xiscu xi...@email.de added the comment: This is also my first contribution. The attached file is a diff against : - http://code.python.org/hg/branches/py3k/ The actual tip was: - 9489:4db13b4e76aa The patch adds only a test that triggers the issue. Please feel free to comment on that commit

[issue809163] Can't add files with spaces

2010-11-21 Thread John Keyes
John Keyes johnke...@gmail.com added the comment: Gah! Silly mistake with the assert. What filelist.py patch are you referring to? I've tested this on py3k with no changes to filelist.py. Thanks for your patience. -- Added file: http://bugs.python.org/file19730/issue809163v3.diff

[issue809163] Can't add files with spaces

2010-11-21 Thread Éric Araujo
Éric Araujo mer...@netwok.org added the comment: assertEquals is deprecated, I’ll change to assertEqual. What filelist.py patch are you referring to? I've tested this on py3k with no changes to filelist.py. The goal of a test is to show an error so that it can be fixed. In this case, the

[issue809163] Can't add files with spaces

2010-11-20 Thread John Keyes
John Keyes johnke...@gmail.com added the comment: I'll change the test to use TESTFN later today. Thanks for the feedback. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue809163 ___

[issue809163] Can't add files with spaces

2010-11-20 Thread Éric Araujo
Éric Araujo mer...@netwok.org added the comment: Thanks for the patch John. Instead of low-level use of TESTFN, you can use distutils.tests.support.TempdirManager to create a temporary directory and write files to it in a few lines. -- assignee: tarek - eric.araujo stage: needs patch

[issue809163] Can't add files with spaces

2010-11-20 Thread John Keyes
John Keyes johnke...@gmail.com added the comment: I see that distutils.tests.support.TempdirManager uses tempfile for directory creation. What's the best course of action here? 1. Use TESTFN or 2. Use TempdirManager or 3. Change the test to use TempdirManager and change TempdirManager to use

[issue809163] Can't add files with spaces

2010-11-20 Thread Éric Araujo
Éric Araujo mer...@netwok.org added the comment: TempdirManager hasn’t caused buildbots failures so far, so there is no need to change it. You can use it, it’s convenient and works :) -- ___ Python tracker rep...@bugs.python.org

[issue809163] Can't add files with spaces

2010-11-20 Thread John Keyes
John Keyes johnke...@gmail.com added the comment: This patch uses TempdirManager to handle the temporary directory and file creation. -- Added file: http://bugs.python.org/file19718/issue809163v2.diff ___ Python tracker rep...@bugs.python.org

[issue809163] Can't add files with spaces

2010-11-20 Thread R. David Murray
R. David Murray rdmur...@bitdance.com added the comment: TempdirManager is new, which is why I forgot about it. It works with the buildbots because it is a context manager, so if things go badly the cleanup code is still going to run and delete the cruft. Since the distutils tests are

[issue809163] Can't add files with spaces

2010-11-20 Thread Éric Araujo
Éric Araujo mer...@netwok.org added the comment: Looks good. You’ll want to use assertEqual here: self.assertTrue(1, len(file_list.files)) Do you want to patch filelist.py now? -- ___ Python tracker rep...@bugs.python.org

[issue809163] Can't add files with spaces

2010-11-19 Thread John Keyes
John Keyes johnke...@gmail.com added the comment: This is my first contribution as part of the Bug Weekend (and possibly my first to Python). I tested this by writing a MANIFEST.in and a very small setup.py but after looking at distutils I narrowed the area down to the FileList. I wrote a

[issue809163] Can't add files with spaces

2010-11-19 Thread R. David Murray
R. David Murray rdmur...@bitdance.com added the comment: Thanks for diagnosis and the test patch, and welcome to the bug weekend. Some comments: test.support has a symbol, TESTFN, which is guaranteed to be unique for the test run and located in an appropriate writeable location. Many tests

[issue809163] Can't add files with spaces

2010-10-07 Thread Anders Sandvig
Changes by Anders Sandvig anders.sand...@gmail.com: -- nosy: +asandvig ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue809163 ___ ___

[issue809163] Can't add files with spaces

2010-09-29 Thread Éric Araujo
Éric Araujo mer...@netwok.org added the comment: Adding the “easy” keyword so that a beginner or sprinter can find this and write a test. Hint: Forget the part about RPM, write a test about inclusion of file with spaces in their name. -- keywords: +easy versions: +3rd party, Python

[issue809163] Can't add files with spaces

2010-07-21 Thread Éric Araujo
Éric Araujo mer...@netwok.org added the comment: Thanks for the report Antonio. I’m sorry noone replied before; bugs are triaged by volunteers and distutils had no dedicated maintainer in the previous years. This needs a test to make sure the bug still exists, and if confirmed a patch to fix

[issue809163] Can't add files with spaces

2009-02-04 Thread Akira Kitada
Changes by Akira Kitada akit...@gmail.com: -- type: - behavior versions: +Python 2.6, Python 2.7, Python 3.0, Python 3.1 -Python 2.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue809163 ___