[issue8138] wsgiref.simple_server.SimpleServer claims to be multithreaded

[Berker Peksag]

Change by Berker Peksag :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions:  -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8138] wsgiref.simple_server.SimpleServer claims to be multithreaded

[Berker Peksag]

Berker Peksag  added the comment:


New changeset 14738ff83d852c95a0cf33e5c90a85860a9c5620 by Berker Peksag in 
branch 'master':
bpo-8138: Initialize wsgiref's SimpleServer as single-threaded (GH-12977)
https://github.com/python/cpython/commit/14738ff83d852c95a0cf33e5c90a85860a9c5620


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8138] wsgiref.simple_server.SimpleServer claims to be multithreaded

[Berker Peksag]

Change by Berker Peksag :


--
pull_requests: +12903

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8138] wsgiref.simple_server.SimpleServer claims to be multithreaded

[Berker Peksag]

Berker Peksag  added the comment:

It's not easy to write a test for this, so I might merge PR 12977 without a 
test.

--
versions: +Python 3.7, Python 3.8 -Python 2.7, Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8138] wsgiref.simple_server.SimpleServer claims to be multithreaded

[Mark Lawrence]

Change by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8138] wsgiref.simple_server.SimpleServer claims to be multithreaded

[Berker Peksag]

Changes by Berker Peksag berker.pek...@gmail.com:


--
nosy: +berker.peksag
stage:  - patch review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8138
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8138] wsgiref.simple_server.SimpleServer claims to be multithreaded

[Berker Peksag]

Berker Peksag added the comment:

Looks like Werkzeug had a workaround for this bug:


https://github.com/mitsuhiko/werkzeug/commit/f9e2fad30d34a6b0737539434c03c07c2bc658d4

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8138
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8138] wsgiref.simple_server.SimpleServer claims to be multithreaded

[Santiago Gala]

Santiago Gala added the comment:

Something like this should do it:

$ diff -u /usr/lib/python2.7/wsgiref/simple_server.py{~,}
--- /usr/lib/python2.7/wsgiref/simple_server.py~2014-10-02 
23:32:47.718382895 +0200
+++ /usr/lib/python2.7/wsgiref/simple_server.py 2014-10-02 14:36:10.662220865 
+0200
@@ -118,7 +118,8 @@
 return
 
 handler = ServerHandler(
-self.rfile, self.wfile, self.get_stderr(), self.get_environ()
+self.rfile, self.wfile, self.get_stderr(), self.get_environ(),
+multithread = False
 )
 handler.request_handler = self  # backpointer for logging
 handler.run(self.server.get_app())

--
keywords: +patch
Added file: http://bugs.python.org/file36787/multithread.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8138
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8138] wsgiref.simple_server.SimpleServer claims to be multithreaded

[Mark Lawrence]

Mark Lawrence added the comment:

@Santiago can you provide a patch for this issue?

--
nosy: +BreamoreBoy
versions: +Python 2.7, Python 3.4, Python 3.5 -Python 2.6

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8138
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8138] wsgiref.simple_server.SimpleServer claims to be multithreaded

[Dirkjan Ochtman]

Changes by Dirkjan Ochtman dirk...@ochtman.nl:


--
nosy: +djc

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8138
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8138] wsgiref.simple_server.SimpleServer claims to be multithreaded

[Mark Lawrence]

Changes by Mark Lawrence breamore...@yahoo.co.uk:


--
nosy: +pje

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8138
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8138] wsgiref.simple_server.SimpleServer claims to be multithreaded

[Santiago Gala]

New submission from Santiago Gala sg...@apache.org:

In python 2.6, a server created with wsgiref.simple_server.make_server will
claim to be multithreaded and multiprocess through it wsgi environ. See  
wsgi.multithread in the browser page after launching

  $ python /usr/lib/python2.6/wsgiref/simple_server.py

The bug is due to the default value in the constructor 
wsgiref.handlers.SimpleHandler, and it is misleading, as the servier is 
singlethreaded. It gives problems for any app that wants to change behavior or 
error on singlethreaded.

The problem can be fixed very simply by patching a multithreaded=False 
argument into the ServerHandler constructor in simple_server.

--
messages: 101058
nosy: sgala
severity: normal
status: open
title: wsgiref.simple_server.SimpleServer claims to be multithreaded
versions: Python 2.6

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8138
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8138] wsgiref.simple_server.SimpleServer claims to be multithreaded

[Santiago Gala]

Changes by Santiago Gala sg...@apache.org:


--
components: +Library (Lib)
type:  - behavior

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8138
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com