Roundup Robot added the comment:
New changeset ef5c5a2bbd48 by Robert Collins in branch 'default':
Issue #8585: improved tests for zipimporter2. Patch from Mark Lawrence.
https://hg.python.org/cpython/rev/ef5c5a2bbd48
--
nosy: +python-dev
___
Python
Robert Collins added the comment:
Applied to 3.6 only.
--
nosy: +rbcollins
resolution: - fixed
stage: commit review - resolved
status: open - closed
versions: +Python 3.6 -Python 3.5
___
Python tracker rep...@bugs.python.org
Changes by Berker Peksag berker.pek...@gmail.com:
--
versions: -Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8585
___
___
Mark Lawrence added the comment:
I've just reworked Berker's patch as it no longer applied. On Windows 7 before
and after applying the patch both test runs gave me 49 tests, 2 skipped. Can
we have a commit review please.
--
nosy: +BreamoreBoy
Added file:
Changes by Claudiu Popa pcmantic...@gmail.com:
--
stage: needs patch - commit review
versions: +Python 3.5 -Python 3.2, Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8585
___
Changes by Brett Cannon br...@python.org:
--
assignee: - berker.peksag
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8585
___
___
Berker Peksag added the comment:
I've attached a patch that adds tests for the zipimporter.find_module().
--
keywords: +patch
nosy: +berker.peksag
versions: +Python 3.2, Python 3.3
Added file: http://bugs.python.org/file28033/issue8585.diff
___
Brett Cannon added the comment:
Been longer than a weekend. =)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8585
___
___
Python-bugs-list
Changes by Terry J. Reedy tjre...@udel.edu:
--
versions: +Python 3.3, Python 3.4 -Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8585
___
Changes by Brett Cannon br...@python.org:
--
versions: -Python 2.7, Python 3.2, Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8585
___
Terry J. Reedy tjre...@udel.edu added the comment:
Since devs are trying to improve tests, I expect a patch will get looked at.
--
nosy: +terry.reedy
versions: -Python 2.6
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8585
Alex alex.gay...@gmail.com added the comment:
Gah, I lost track of this one after I realized the bug I was chasing after
(originally thought to be in PyPy's zipimpoter) was actually in Django. I'll
try to get to this over the weekend.
--
___
New submission from Alex alex.gay...@gmail.com:
There are no tests for zipimporter.find_module in the success case, only tests
that it handles invalid inputs ok. I'll work up some tests for this tomorrow
probably.
--
components: Extension Modules
messages: 104684
nosy: alex
priority:
Changes by Antoine Pitrou pit...@free.fr:
--
components: +Tests -Extension Modules
nosy: +brett.cannon, ncoghlan
stage: - needs patch
type: - behavior
versions: +Python 2.6, Python 2.7, Python 3.1, Python 3.2
___
Python tracker
14 matches
Mail list logo