[issue8585] zipimporter.find_module is untested

[Robert Collins]

Robert Collins added the comment:

Applied to 3.6 only.

--
nosy: +rbcollins
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed
versions: +Python 3.6 -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8585] zipimporter.find_module is untested

[Roundup Robot]

Roundup Robot added the comment:

New changeset ef5c5a2bbd48 by Robert Collins in branch 'default':
Issue #8585: improved tests for zipimporter2. Patch from Mark Lawrence.
https://hg.python.org/cpython/rev/ef5c5a2bbd48

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8585] zipimporter.find_module is untested

[Berker Peksag]

Changes by Berker Peksag :


--
versions:  -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8585] zipimporter.find_module is untested

[Brett Cannon]

Changes by Brett Cannon :


--
assignee:  -> berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8585] zipimporter.find_module is untested

[Claudiu Popa]

Changes by Claudiu Popa :


--
stage: needs patch -> commit review
versions: +Python 3.5 -Python 3.2, Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8585] zipimporter.find_module is untested

[Mark Lawrence]

Mark Lawrence added the comment:

I've just reworked Berker's patch as it no longer applied.  On Windows 7 before 
and after applying the patch both test runs gave me 49 tests, 2 skipped.  Can 
we have a commit review please.

--
nosy: +BreamoreBoy
Added file: http://bugs.python.org/file35826/Issue8585.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8585] zipimporter.find_module is untested

[Berker Peksag]

Berker Peksag added the comment:

I've attached a patch that adds tests for the zipimporter.find_module().

--
keywords: +patch
nosy: +berker.peksag
versions: +Python 3.2, Python 3.3
Added file: http://bugs.python.org/file28033/issue8585.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8585] zipimporter.find_module is untested

[Brett Cannon]

Changes by Brett Cannon :


--
versions:  -Python 2.7, Python 3.2, Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8585] zipimporter.find_module is untested

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
versions: +Python 3.3, Python 3.4 -Python 3.1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8585] zipimporter.find_module is untested

[Brett Cannon]

Brett Cannon added the comment:

Been longer than a weekend. =)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8585] zipimporter.find_module is untested

[Alex]

Alex  added the comment:

Gah, I lost track of this one after I realized the bug I was chasing after 
(originally thought to be in PyPy's zipimpoter) was actually in Django.  I'll 
try to get to this over the weekend.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8585] zipimporter.find_module is untested

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Since devs are trying to improve tests, I expect a patch will get looked at.

--
nosy: +terry.reedy
versions:  -Python 2.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8585] zipimporter.find_module is untested

[Antoine Pitrou]

Changes by Antoine Pitrou :


--
components: +Tests -Extension Modules
nosy: +brett.cannon, ncoghlan
stage:  -> needs patch
type:  -> behavior
versions: +Python 2.6, Python 2.7, Python 3.1, Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8585] zipimporter.find_module is untested

[Alex]

New submission from Alex :

There are no tests for zipimporter.find_module in the success case, only tests 
that it handles invalid inputs ok.  I'll work up some tests for this tomorrow 
probably.

--
components: Extension Modules
messages: 104684
nosy: alex
priority: normal
severity: normal
status: open
title: zipimporter.find_module is untested

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com