[issue9372] pulldom.DOMEventStream.__getitem__ is broken

[Berker Peksag]

Change by Berker Peksag :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9372] pulldom.DOMEventStream.__getitem__ is broken

[Berker Peksag]

Berker Peksag  added the comment:


New changeset 84a13fbda0d79789e3c9efcc9f64752261ce1e8d by Berker Peksag in 
branch 'master':
bpo-9372: Deprecate several __getitem__ methods (GH-8609)
https://github.com/python/cpython/commit/84a13fbda0d79789e3c9efcc9f64752261ce1e8d


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9372] pulldom.DOMEventStream.__getitem__ is broken

[Berker Peksag]

Berker Peksag  added the comment:

I've fixed a bug that uses DOMEventStream.__getitem__ at work today. I've 
opened PR 8609 to deprecate __getitem__ methods of DOMEventStream, FileInput 
and FileWrapper classes.

--
components: +Library (Lib)
nosy: +berker.peksag
versions: +Python 3.8 -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9372] pulldom.DOMEventStream.__getitem__ is broken

[Berker Peksag]

Change by Berker Peksag :


--
pull_requests: +8115

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9372] pulldom.DOMEventStream.__getitem__ is broken

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Similar outdated __getitem__ left in wsgiref.util.FileWrapper and 
fileinput.FileInput.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9372] pulldom.DOMEventStream.__getitem__ is broken

[Thomas Fenzl]

Thomas Fenzl added the comment:

I added a depreciation warning to __getitem__.
Also added a testcase checking for it. As item access to DOMEventStream was 
never documented, no changes were made to the documentation.

--
keywords: +patch
nosy: +Thomas Fenzl
Added file: http://bugs.python.org/file29506/pulldom_deprecation.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9372
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9372] pulldom.DOMEventStream.__getitem__ is broken

[Mark Smith]

New submission from Mark Smith mark.sm...@practicalpoetry.co.uk:

DOMEventStream implements __getitem__, but ignores the index/key that is passed 
in and simply returns the next item from the stream. This is seriously 
unexpected behaviour.

I don't believe this functionality can be sensibly implemented in this class, 
and plan to submit a patch deprecating this method.

--
components: XML
messages: 111475
nosy: mark.smith
priority: normal
severity: normal
status: open
title: pulldom.DOMEventStream.__getitem__ is broken
versions: Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9372
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9372] pulldom.DOMEventStream.__getitem__ is broken

[Éric Araujo]

Éric Araujo mer...@netwok.org added the comment:

You may want to keep existing functionality, this time in the proper method 
(__iter__).

--
nosy: +merwok
stage:  - unit test needed
type:  - behavior

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9372
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9372] pulldom.DOMEventStream.__getitem__ is broken

[Mark Smith]

Mark Smith mark.sm...@practicalpoetry.co.uk added the comment:

I should have mentioned: __iter__ is already implemented, and works as expected.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9372
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com