[issue9784] _msi.c warnings under 64-bit Windows

2019-09-11 Thread Steve Dower
Change by Steve Dower : -- resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue9784] _msi.c warnings under 64-bit Windows

2019-03-15 Thread Mark Lawrence
Change by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue9784] _msi.c warnings under 64-bit Windows

2015-03-02 Thread Steve Dower
Steve Dower added the comment: We'd need a contributor agreement from Jon anyway, so unless he rejoins this thread and is willing to sign that, there's little point looking at the patch. -- ___ Python tracker rep...@bugs.python.org

[issue9784] _msi.c warnings under 64-bit Windows

2015-03-01 Thread Mark Lawrence
Changes by Mark Lawrence breamore...@yahoo.co.uk: -- components: +Windows nosy: +steve.dower, tim.golden, zach.ware ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9784 ___

[issue9784] _msi.c warnings under 64-bit Windows

2014-06-20 Thread Mark Lawrence
Mark Lawrence added the comment: Could somebody review the patch please as it's well over my head. -- nosy: +BreamoreBoy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9784 ___

[issue9784] _msi.c warnings under 64-bit Windows

2010-09-29 Thread Jon Anglin
Jon Anglin jang...@fortresgrand.com added the comment: I have uploaded another patch that replaces CRT API calls with Win32 API calls. It compiles cleanly under 32 and 64 bit Windows. Is there a unit test for msilib? I was not able to find one, thus the patch is not fully tested. --

[issue9784] _msi.c warnings under 64-bit Windows

2010-09-25 Thread Martin v . Löwis
Martin v. Löwis mar...@v.loewis.de added the comment: Martin Lowis do you mean API when you type SDK? When I said SDK examples, then I really meant examples as published in the SDK, not examples as published in the API (and the SDK documentation, in turn, is published on msdn). But yes, the

[issue9784] _msi.c warnings under 64-bit Windows

2010-09-25 Thread Jon Anglin
Jon Anglin jang...@fortresgrand.com added the comment: I have the long-term plan to eliminate all CRT usage from Python on Windows. In this case, there is a straight-forward opportunity to do so. Oh, OK. If that is the plan then I am on board. I will re-code the patch using the Win32 API

[issue9784] _msi.c warnings under 64-bit Windows

2010-09-24 Thread Ned Deily
Changes by Ned Deily n...@acm.org: -- stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9784 ___ ___ Python-bugs-list mailing

[issue9784] _msi.c warnings under 64-bit Windows

2010-09-24 Thread Martin v . Löwis
Martin v. Löwis mar...@v.loewis.de added the comment: -1 for the patch. I still maintain that it is better to follow the current SDK. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9784

[issue9784] _msi.c warnings under 64-bit Windows

2010-09-24 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc amaur...@gmail.com added the comment: Which SDK Example are you referring to? I could not find any example. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9784 ___

[issue9784] _msi.c warnings under 64-bit Windows

2010-09-24 Thread Martin v . Löwis
Martin v. Löwis mar...@v.loewis.de added the comment: See, for example, the link you gave in msg115750. It has this sample code in it (listed in the Examples section): FNFCIREAD(fnFileRead) { DWORD dwBytesRead = 0; UNREFERENCED_PARAMETER(pv); if( ReadFile((HANDLE)hf, memory, cb,

[issue9784] _msi.c warnings under 64-bit Windows

2010-09-24 Thread Jon Anglin
Jon Anglin jang...@fortresgrand.com added the comment: Martin Lowis do you mean API when you type SDK? If I understand what you are saying, you would rather use the Win32 API instead of the CRT API? It may interest you to know that _open calls CreateFile internally, _read calls ReadFile,

[issue9784] _msi.c warnings under 64-bit Windows

2010-09-23 Thread Jon Anglin
Jon Anglin jang...@fortresgrand.com added the comment: issue9784.diff contains a patch that compiles clean on 32 and 64 bit Windows. This patch is exactly what Amaury Forgeot d'Arc recommended in msg115750. -- keywords: +patch Added file: http://bugs.python.org/file18989/issue9784.diff

[issue9784] _msi.c warnings under 64-bit Windows

2010-09-13 Thread Jon Anglin
Changes by Jon Anglin jang...@fortresgrand.com: -- nosy: +janglin ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9784 ___ ___ Python-bugs-list

[issue9784] _msi.c warnings under 64-bit Windows

2010-09-12 Thread Martin v . Löwis
Martin v. Löwis mar...@v.loewis.de added the comment: It's probably best to rewrite these functions in the way the SDK Example section works (i.e. CreateFile/ReadFile) instead of _open/_read (*). As Amaury says, the warnings are harmless: the file numbers will always be in range, as _open

[issue9784] _msi.c warnings under 64-bit Windows

2010-09-07 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc amaur...@gmail.com added the comment: FNFCIREAD co are macros to help the definition of callback functions: http://msdn.microsoft.com/en-us/library/ff797940.aspx hf is defined as INT_PTR, but the value it receives is the result of FNFCIOPEN(), which fits in int. It is safe

[issue9784] _msi.c warnings under 64-bit Windows

2010-09-06 Thread Antoine Pitrou
New submission from Antoine Pitrou pit...@free.fr: I'm posting this in case it is a sign of a problem. Apparently some variable named hf is an INT_PTR used as an int (according to Visual Studio), but hf doesn't seem to be defined or declared in _msi.c at all. 12..\PC\_msi.c(66) : warning