Zachary Ware added the comment:
Fixed by #21907.
--
assignee: - zach.ware
resolution: - fixed
stage: - resolved
status: open - closed
superseder: - Update Windows build batch scripts
versions: +Python 3.5 -Python 3.4
___
Python tracker
Zachary Ware added the comment:
I just stumbled across this issue in looking for another issue, and this turns
out to be of interest to me as well. As such, I've updated sorin's patch to
apply to the current default branch, added the same kind of change to the
new-since-then clean-amd64.bat,
Zachary Ware added the comment:
Here's the patch that moves external*.bat into PCbuild. I also took the
opportunity to give the three files more descriptive names: external.bat -
get_externals.bat, external-common.bat - get_common_externals.bat, and
external-amd64.bat -
Martin v. Löwis mar...@v.loewis.de added the comment:
I did not realize the build instructions recommended using the
buildbot tool. It is clearly past time I got around to doing windows
build myself.
I'd rather prefer a different setup, also: it would
be better if the batch files to get the
New submission from sorin sorin.sbar...@gmail.com:
Currently most batch files from Tools\buildbot do fail to run if you do not
call them from the python source root directory.
I already have patched files, but the question is against which branch should I
make them, considering that this bug
Changes by sorin sorin.sbar...@gmail.com:
--
keywords: +patch
Added file: http://bugs.python.org/file18828/buildbot_curdir.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9822
___
R. David Murray rdmur...@bitdance.com added the comment:
The general rule for submitting patches is to make them against development
trunk (which is currently the py3k branch). Unified diffs from the top level
of the checkout are preferred; whole files are not useful.
However, it is not
sorin sorin.sbar...@gmail.com added the comment:
In this case I made the patch on the right branch (py3k).
These scripts could be called manually and it doesn't make any sense not to
make them work in all cases.
Not every Windows developer is using Visual Studio to build things, 'some' of
R. David Murray rdmur...@bitdance.com added the comment:
I did not realize the build instructions recommended using the buildbot tool.
It is clearly past time I got around to doing windows build myself.
Please regenerate the diffs from the top level of the checkout, and we'll see
if one of
Brian Curtin cur...@acm.org added the comment:
This is just a guess, but it might have to do with how buildbot works, so I'd
be careful of changing this. A lot of things (everything?) in that
Tools\buildbot folder depend on being run from the top-level directory in order
to work correctly.
sorin sorin.sbar...@gmail.com added the comment:
This is true, that this can impact the build process but the changes are
assuring that it will always chdir to the right directory.
BTW, %~dp0 is the directory when the batch file is located.
--
Added file:
Changes by sorin sorin.sbar...@gmail.com:
Removed file: http://bugs.python.org/file18829/readme.txt.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9822
___
Changes by sorin sorin.sbar...@gmail.com:
Removed file: http://bugs.python.org/file18828/buildbot_curdir.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9822
___
13 matches
Mail list logo
