Re: [python-committers] New Roundup notifications on Git commits?

2017-02-13 Thread Eric Snow
On Mon, Feb 13, 2017 at 11:16 AM, Brett Cannon wrote: > if the webhook event for your merge > got rejected due to the bad cert then it would have been dropped. A repo admin should be able to manually request that a failed webhook be retried. The webhook's page on GH has a list of all associated

Re: [python-committers] Discussions on PRs

2017-02-13 Thread Ezio Melotti
On Mon, Feb 13, 2017 at 11:33 AM, M.-A. Lemburg wrote: > With the move to Github, I'm seeing a move away from > discussions on the issue tracker towards discussions on > pull requests. > > Example: https://github.com/python/cpython/pull/4 > > Is this something we should encourage or better ask the

Re: [python-committers] New Roundup notifications on Git commits?

2017-02-13 Thread Ezio Melotti
I've been keeping an eye on the tracker logs and saw no errors. If you are still having problems after the SSL fix let me know. On Mon, Feb 13, 2017 at 8:16 PM, Brett Cannon wrote: > There was an issue up until sometime on Sunday where the SSL cert for > bugs.python.org was being rejected (it wa

Re: [python-committers] Discussions on PRs

2017-02-13 Thread Victor Stinner
2017-02-13 19:30 GMT+01:00 Serhiy Storchaka : > I'm going to > unsubscribe from getting emails for all pull requests and subscribe to only > selected ones. I did exactly that, very early :-) https://github.com/python/cpython/ : "Watch: *not watching*. Be notified when participating or @mention".

Re: [python-committers] Discussions on PRs

2017-02-13 Thread Serhiy Storchaka
понеділок, 13 лютого 2017 р. 10:33:58 EET M.-A. Lemburg написано: > With the move to Github, I'm seeing a move away from > discussions on the issue tracker towards discussions on > pull requests. > > Example: https://github.com/python/cpython/pull/4 > > Is this something we should encourage or be

Re: [python-committers] Disable Codecov on GitHub pull requests?

2017-02-13 Thread Berker Peksağ
On Mon, Feb 13, 2017 at 6:25 PM, Victor Stinner wrote: > 2017-02-13 16:04 GMT+01:00 Donald Stufft : >> I’ve also never see the random -0.01% >> coverage of code in another project, and my guess is that there is some sort >> of non-determinism in the CPython test suite that would be a good idea to

Re: [python-committers] Disable Codecov on GitHub pull requests?

2017-02-13 Thread Brian Curtin
On Mon, Feb 13, 2017 at 1:11 PM, Brett Cannon wrote: > > > On Mon, 13 Feb 2017 at 07:26 Victor Stinner > wrote: >> >> 2017-02-13 16:04 GMT+01:00 Donald Stufft : >> > I’ve also never see the random -0.01% >> > coverage of code in another project, and my guess is that there is some >> > sort >> > o

Re: [python-committers] New Roundup notifications on Git commits?

2017-02-13 Thread Brett Cannon
There was an issue up until sometime on Sunday where the SSL cert for bugs.python.org was being rejected (it was issued by StartCom who is being distrusted). The cert got replaced but if the webhook event for your merge got rejected due to the bad cert then it would have been dropped. So if should

Re: [python-committers] Disable Codecov on GitHub pull requests?

2017-02-13 Thread Brett Cannon
On Mon, 13 Feb 2017 at 07:26 Victor Stinner wrote: > 2017-02-13 16:04 GMT+01:00 Donald Stufft : > > I’ve also never see the random -0.01% > > coverage of code in another project, and my guess is that there is some > sort > > of non-determinism in the CPython test suite that would be a good idea t

Re: [python-committers] Disable Codecov on GitHub pull requests?

2017-02-13 Thread Victor Stinner
2017-02-13 16:04 GMT+01:00 Donald Stufft : > I’ve also never see the random -0.01% > coverage of code in another project, and my guess is that there is some sort > of non-determinism in the CPython test suite that would be a good idea to > make deterministic anyways. Can we hide/disable Codecov no

Re: [python-committers] Discussions on PRs

2017-02-13 Thread Barry Warsaw
On Feb 13, 2017, at 10:33 AM, M.-A. Lemburg wrote: >Discussion on the PRs would then only be for code review >aspects. +1 On Feb 13, 2017, at 11:49 AM, Stefan Krah wrote: >Realistically, my workload tripled for this one particular issue >compared to our previous workflow. Not to mention the si

Re: [python-committers] Disable Codecov on GitHub pull requests?

2017-02-13 Thread Barry Warsaw
On Feb 13, 2017, at 09:51 AM, Alex Gaynor wrote: >actively tracking the impact of each PR on coverage has been extremely >useful in every other project I've worked on. Agreed. >FWIW, on projects I've worked on we have turned off the codecov "comments", >and instead just rely on the status checke

Re: [python-committers] Disable Codecov on GitHub pull requests?

2017-02-13 Thread Donald Stufft
> On Feb 13, 2017, at 9:49 AM, Victor Stinner wrote: > > Hi, > > I don't get the value of code coverage on a CI. I *like* running code > coverage sometimes, but I don't like being annoying by "test failed: > coverage -0,01%" by a change completely unrelated to code (note: this > issue has been

Re: [python-committers] Disable Codecov on GitHub pull requests?

2017-02-13 Thread Alex Gaynor
I'm obviously not very active in CPython development these days, but actively tracking the impact of each PR on coverage has been extremely useful in every other project I've worked on. It's the best way to automatically ensure PRs are not regressing coverage too much, and doesn't require much man

[python-committers] Disable Codecov on GitHub pull requests?

2017-02-13 Thread Victor Stinner
Hi, I don't get the value of code coverage on a CI. I *like* running code coverage sometimes, but I don't like being annoying by "test failed: coverage -0,01%" by a change completely unrelated to code (note: this issue has been fixed be using a threshold of 1%). I'm annoyed by all these Codecov me

Re: [python-committers] Discussions on PRs

2017-02-13 Thread Stefan Krah
On Mon, Feb 13, 2017 at 08:48:08AM -0500, Donald Stufft wrote: > It looks like the person in question is commenting on the issue tracker. Is *now* commenting on the issue tracker as opposed to when I wrote the mail. But hey, it sounds much more impressive the way you phrased it ... Stefan

Re: [python-committers] Discussions on PRs

2017-02-13 Thread Donald Stufft
> On Feb 13, 2017, at 5:49 AM, Stefan Krah wrote: > > What I > see now is that patches without comments emerge really fast: > >https://github.com/python/cpython/pull/65 > It looks like the person in question is commenting on the issue tracker.

Re: [python-committers] Discussions on PRs

2017-02-13 Thread Stefan Krah
On Mon, Feb 13, 2017 at 10:33:58AM +0100, M.-A. Lemburg wrote: > With the move to Github, I'm seeing a move away from > discussions on the issue tracker towards discussions on > pull requests. > > Example: https://github.com/python/cpython/pull/4 > > Is this something we should encourage or bett

Re: [python-committers] Discussions on PRs

2017-02-13 Thread Victor Stinner
I prefer to discuss on the review rather than on the bug tracker. In the extreme case, if we had to choose, I had rather prefer to drop the bug tracker. It is not going to appear since people still have to report bugs without patch :-) Victor 2017-02-13 10:33 GMT+01:00 M.-A. Lemburg : > With the

[python-committers] Discussions on PRs

2017-02-13 Thread M.-A. Lemburg
With the move to Github, I'm seeing a move away from discussions on the issue tracker towards discussions on pull requests. Example: https://github.com/python/cpython/pull/4 Is this something we should encourage or better ask the OPs to open a ticket on the tracker first and reference the PR ther