On 7/10/2017 10:49 AM, Berker Peksağ wrote:
On Mon, Jul 10, 2017 at 4:14 PM, Serhiy Storchaka wrote:
When a PR is consistent on several commits, the final commit message
composed by GitHub contains messages of all these commits: "fix typo",
"address yyy comments", "revert
Often the committer has more context to write a proper commit message, and
asking the contributor to do the squash is just wasting time (plus in
general we *don't* want contributors to squash, since that loses the
context for the review). So I'm with Sergey. This is how we do it in the
On Jul 10, 2017, at 04:57 PM, Victor Stinner wrote:
>I would prefer to ask the author to squash and/or rebase his/her
>commits rather than having to edit the commit message myself. I prefer
>that the commit message is part of the review, and not only done by
>the one who clicks on the Merge
I would prefer to ask the author to squash and/or rebase his/her
commits rather than having to edit the commit message myself. I prefer
that the commit message is part of the review, and not only done by
the one who clicks on the Merge button.
It would prefer mistakes in the commit message.
On Mon, Jul 10, 2017 at 4:14 PM, Serhiy Storchaka wrote:
> When a PR is consistent on several commits, the final commit message
> composed by GitHub contains messages of all these commits: "fix typo",
> "address yyy comments", "revert zzz". If the initial commit message
>
When a PR is consistent on several commits, the final commit message
composed by GitHub contains messages of all these commits: "fix typo",
"address yyy comments", "revert zzz". If the initial commit message
contained errors (e.g. absent issue number), it is easy to edit the
title and text of