Re: [python-committers] Travis-CI compiles twice

2017-07-24 Thread Zachary Ware
On Mon, Jul 24, 2017 at 3:55 AM, Victor Stinner wrote: > Zachary Ware explained me once that "make regen-all" should be run > after "make", but I don't recall why :-) The real kicker is `make clinic`, which fails unless done after `make all`. I'd be all in favor of fixing that (and adding `clini

Re: [python-committers] Travis-CI compiles twice

2017-07-24 Thread Victor Stinner
Technically, "make regen-all" doesn't use the freshly built Python. It uses PYTHON_FOR_REGEN which is usually "python3". Victor 2017-07-24 15:48 GMT+02:00 Nick Coghlan : > On 24 July 2017 at 18:55, Victor Stinner wrote: >> 2017-07-24 9:37 GMT+02:00 Serhiy Storchaka : >>> `make regen-all` touches

Re: [python-committers] Travis-CI compiles twice

2017-07-24 Thread Nick Coghlan
On 24 July 2017 at 18:55, Victor Stinner wrote: > 2017-07-24 9:37 GMT+02:00 Serhiy Storchaka : >> `make regen-all` touches header files which are dependencies for all >> binaries. I suggest to run `make regen-all` before `make`. > > Zachary Ware explained me once that "make regen-all" should be ru

Re: [python-committers] Travis-CI compiles twice

2017-07-24 Thread Victor Stinner
I read again the read and I misunderstood it. I didn't notice that "make buildbottest" recompiles Python. Ok, I confirm the bug. I see two options: * move the "make regen-all" check *before* "make" * move the "make regen-all" check in a different Travis CI. If we move the test in a GCC job, it wo

Re: [python-committers] Travis-CI compiles twice

2017-07-24 Thread Antoine Pitrou
Le 24/07/2017 à 10:55, Victor Stinner a écrit : > IMHO everything is fine and we don't have to do anything ;-) What do you mean? The fact that all the CPython source code (including C extensions) is compiled twice looks suboptimal to me. We could probably win a minute or two on Travis-CI build

Re: [python-committers] Travis-CI compiles twice

2017-07-24 Thread Victor Stinner
IMHO everything is fine and we don't have to do anything ;-) Antoine: >I've noticed that Travis-CI (sometimes?) compiles CPython twice. "make regen-all" doesn't compiles Python: * it compiles Parser/pgen * it compiles Programs/_freeze_importlib * it runs many commands to regenerate generated fil

Re: [python-committers] My (positive) feedback on the new CPython workflow

2017-07-24 Thread Larry Hastings
On 07/18/2017 02:36 AM, Antoine Pitrou wrote: Can I take the opportunity to say thank you again (both you and Larry) for the "blurb" tool? It really makes an important difference when contributing. On 07/18/2017 03:24 AM, Victor Stinner wrote: Thank you Larry Hastings, Brett Cannon and othe

Re: [python-committers] Travis-CI compiles twice

2017-07-24 Thread Serhiy Storchaka
23.07.17 19:04, Brett Cannon пише: If you look at the exact commands it's configure, make, and then make regen-all clinic. My guess is that last command is touching files in such a way that the make bulidbottest is causing make to rebuild some files. `make regen-all` touches header files which

[python-committers] Python 3.5.4rc1 and 3.4.7rc1 slipping by a day, to July 24 2017

2017-07-24 Thread Larry Hastings
Release engineering for 3.5.4rc1 and 3.4.7rc1 took a lot longer than expected, because this is the first release using "blurb", and it turned out there was a lot of work left to do and a couple dark corners yet to stumble over. 3.5.4rc1 and 3.4.7rc1 will be released Monday, July 24, 2017.