Re: [python-committers] Py_UNREACHABLE

2017-09-15 Thread Barry Warsaw
On Sep 15, 2017, at 12:36, Victor Stinner wrote: > > The good news is that other C macros are now documented as well! > > https://docs.python.org/dev/c-api/intro.html#useful-macros > > If you look at Include/pymacro.h there are even more crazy macros > which are not documented yet, like Py_BUIL

Re: [python-committers] Py_UNREACHABLE

2017-09-15 Thread Victor Stinner
The good news is that other C macros are now documented as well! https://docs.python.org/dev/c-api/intro.html#useful-macros If you look at Include/pymacro.h there are even more crazy macros which are not documented yet, like Py_BUILD_ASSERT(). I like Py_ARRAY_LENGTH() which gives the length of a

[python-committers] Py_UNREACHABLE

2017-09-15 Thread Barry Warsaw
I landed bpo-31338 / PR #3374 which adds a Py_UNREACHABLE() macro to master, along with some additional documentation in the C API describing this and a few other common macros. If you’re writing or reviewing C changes that include unreachable code paths, please use this macro for consistency,