[python-committers] trivial tag on GitHub?

2018-01-25 Thread Ethan Furman
I created a new pull request to add a forgotten news entry, and now it's going through all the pre-checks, etc. I seem to recall we could add a "trivial" tag to an issue to skip those. Is that still true, and if so, how? -- ~Ethan~ ___ python-commit

Re: [python-committers] AppVeyor is now required to pass on PRs

2018-01-25 Thread Terry Reedy
On 1/25/2018 4:31 PM, Victor Stinner wrote: Hi, The best would be able to have a bot merging a pull request once tests pass and a core developer asked a merge. I'm not talking about the current approval using review, but something new, like adding a special comment like "Merge". Such comment wou

Re: [python-committers] AppVeyor is now required to pass on PRs

2018-01-25 Thread Mariatta Wijaya
> > Is it possible to write a bot which merges a PR? Yes it is possible, and we sort of discussing the same thing in python-dev [1] :) Each time I approve a backport PR created by miss-ilington with "LGTM, > good bot", I hope secretly that the PR will be merged automatically > once CI tests pass

Re: [python-committers] AppVeyor is now required to pass on PRs

2018-01-25 Thread Victor Stinner
Hi, The best would be able to have a bot merging a pull request once tests pass and a core developer asked a merge. I'm not talking about the current approval using review, but something new, like adding a special comment like "Merge". Such comment would only merge if it's written by a core develo

Re: [python-committers] AppVeyor is now required to pass on PRs

2018-01-25 Thread Terry Reedy
On 1/25/2018 1:52 PM, Brett Cannon wrote: On Wed, 24 Jan 2018 at 10:12 Victor Stinner > wrote: AppVeyor usually takes between 30 min and 1 hour to check a PR, Yesterday, AppVeyor surprised me by finishing in about 6 minutes, handily beating Travis. I

Re: [python-committers] AppVeyor is now required to pass on PRs

2018-01-25 Thread Mariatta Wijaya
I'm fine with the delay. I've been thinking to implement the bot that will remind us when all the CI has been completed. So we don't have to wait, and won't forget about it. Currently miss-islington does this only for the backport PRs made by miss-islington. I think it'll be useful to do that on o

Re: [python-committers] AppVeyor is now required to pass on PRs

2018-01-25 Thread Brett Cannon
On Wed, 24 Jan 2018 at 10:12 Victor Stinner wrote: > Hi, > > AppVeyor usually takes between 30 min and 1 hour to check a PR, > whereas Travis CI takes between 10 and 20 minutes (in average, > ignoring rare cases when it's broken). AppVeyor queue is regulary > busy. > > Sometimes, I know that my P

Re: [python-committers] core developer status

2018-01-25 Thread Zachary Ware
On Thu, Jan 25, 2018 at 11:59 AM, Brett Cannon wrote: > I have removed your access on GitHub and unsubscribed you from > python-committers. Also flipped the 'is_committer' bit to off on the bug tracker. > Sorry to see you go, Xavier, but look forward to > continuing to work with you on PRs! Com

Re: [python-committers] core developer status

2018-01-25 Thread Brett Cannon
I have removed your access on GitHub and unsubscribed you from python-committers. Sorry to see you go, Xavier, but look forward to continuing to work with you on PRs! On Thu, 25 Jan 2018 at 04:29 Xavier de Gaye wrote: > I have decided for personal reasons to stop contributing to CPython as a > c

Re: [python-committers] Let's give commit privileges to Nathaniel J. Smith

2018-01-25 Thread Brett Cannon
Done, making Nathaniel the 90th member of the current core team! He also needs to send a subscription request for python-committers. On Thu, 25 Jan 2018 at 09:24 Yury Selivanov wrote: > Alright, it's decided! I now envy Nathaniel a bit, so many people +1-ed! > > I've added Nathaniel to devguide

Re: [python-committers] Let's give commit privileges to Nathaniel J. Smith

2018-01-25 Thread Yury Selivanov
Alright, it's decided! I now envy Nathaniel a bit, so many people +1-ed! I've added Nathaniel to devguide/developers.rst, and I believe Victor has already elevated his permissions on the bug tracker. Can someone with admin permissions on github.com/python invite Nathaniel to the Core Developers

Re: [python-committers] Let's give commit privileges to Nathaniel J. Smith

2018-01-25 Thread Ezio Melotti
+1 On Thu, Jan 25, 2018 at 12:23 AM, Yury Selivanov wrote: > Hi, > > I want to propose granting commit privileges to Nathaniel J. Smith. > He's interested in the idea of becoming a core developer, and given > the quality of his contributionsI think he won't need any extensive > mentoring (althoug

Re: [python-committers] Requirements to get the "bug triage" permission?

2018-01-25 Thread Victor Stinner
2018-01-25 15:18 GMT+01:00 Jesus Cea : > On 06/12/17 23:17, Victor Stinner wrote: >> My problem is that we don't have a long list of "awards" in Python: >> the triage bit and the commit bit... >> >> I had some ideas to create badges, but before I come with something >> concrete, I'm trying to build

Re: [python-committers] Requirements to get the "bug triage" permission?

2018-01-25 Thread Jesus Cea
On 06/12/17 23:17, Victor Stinner wrote: > My problem is that we don't have a long list of "awards" in Python: > the triage bit and the commit bit... > > I had some ideas to create badges, but before I come with something > concrete, I'm trying to build something with what we already have ;-) I h

[python-committers] core developer status

2018-01-25 Thread Xavier de Gaye
I have decided for personal reasons to stop contributing to CPython as a core developer, that does not mean I will stop contributing to CPython. So please remove me from the list of core developers and revoke all my access rights. Thank you. Xavier ___

Re: [python-committers] Let's give commit privileges to Nathaniel J. Smith

2018-01-25 Thread Paul Moore
+1 from me also. He's been involved in a lot of distutils-sig stuff as well, and his contributions have always been well thought out and useful. Paul On 24 January 2018 at 23:23, Yury Selivanov wrote: > Hi, > > I want to propose granting commit privileges to Nathaniel J. Smith. > He's interested

[python-committers] Mentoring and promoting contributors (was: Let's give commit privileges to Nathaniel J. Smith)

2018-01-25 Thread Victor Stinner
Hi, 2018-01-25 0:29 GMT+01:00 Eric V. Smith : > +1. I actually thought [Nathaniel Smith] was a committer already. By the way, if you notice an active contributor is good candidate to become a core dev in the long term, you may start the process that I described here: https://github.com/vstinner/m

Re: [python-committers] Let's give commit privileges to Nathaniel J. Smith

2018-01-25 Thread INADA Naoki
+1 -- INADA Naoki ___ python-committers mailing list python-committers@python.org https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Let's give commit privileges to Nathaniel J. Smith

2018-01-25 Thread M.-A. Lemburg
+1 On 25.01.2018 01:00, Victor Stinner wrote: > +1 > > Impressive list of contributions! > > Victor > > 2018-01-25 0:23 GMT+01:00 Yury Selivanov : >> Hi, >> >> I want to propose granting commit privileges to Nathaniel J. Smith. >> He's interested in the idea of becoming a core developer, and gi