Re: [python-committers] [core-workflow] Adding "Co-authored-by" in commit message.

2018-01-29 Thread Mariatta Wijaya
No prob :) I've also updated cherry_picker and miss-islington, so now `Co-authored-by` is added automatically in backport PRs. Mariatta Wijaya On Mon, Jan 29, 2018 at 5:37 PM, Eric Snow wrote: > On Mon, Jan 29, 2018 at 4:32 PM, Mariatta Wijaya > wrote: > > I suggest we start adding this where

Re: [python-committers] [core-workflow] Adding "Co-authored-by" in commit message.

2018-01-29 Thread Eric Snow
On Mon, Jan 29, 2018 at 4:32 PM, Mariatta Wijaya wrote: > I suggest we start adding this where it makes sense, to give proper credit > to PR authors. +1 Thanks for noticing this. I've bumped into this several times and look forward to (more clearly) giving credit where credit is due. -eric ___

[python-committers] Adding "Co-authored-by" in commit message.

2018-01-29 Thread Mariatta Wijaya
I learned today that GitHub now supports multiple author info in a commit. https://help.github.com/articles/creating-a-commit-with-multiple-authors/ and https://github.com/blog/2496-commit-together-with-co-authors It can be done by adding: Co-authored-by: name as the footer of the commit mess