Re: [python-committers] [Python-Dev] Farewell, Python 3.4

2019-05-08 Thread Benjamin Peterson
Thank you for your service! On Wed, May 8, 2019, at 08:37, Larry Hastings wrote: > > > It's with a note of sadness that I announce the final retirement of > Python 3.4. The final release was back in March, but I didn't get > around to actually closing and deleting the 3.4 branch until this >

Re: [python-committers] [Python-Dev] Farewell, Python 3.4

2019-05-08 Thread Terry Reedy
On 5/8/2019 11:46 AM, M.-A. Lemburg wrote: Thank you for having been 3.4 release manager, Larry ! I especially appreciate being able to have proper signatures for builtin functions. ___ python-committers mailing list python-committers@python.org ht

Re: [python-committers] miss-islington backport pipeline is stalled?

2019-05-08 Thread Brett Cannon
On Wed, May 8, 2019 at 1:04 PM Alex Gaynor wrote: > Would it make sense to work with the PSF infra staff so that > miss-isslington is hooked up to the PSF Sentry account so folks can get > email notifications and similar on unhandled exceptions? > Yes it would. :) -Brett > > Alex > > On Wed,

Re: [python-committers] miss-islington backport pipeline is stalled?

2019-05-08 Thread Mariatta
We don't have sentry (I will ask Ernest about it), but such errors are already sent to Zulip ( https://python.zulipchat.com/#narrow/stream/142203-workflow.2Fbot-api.20rate.20limit/topic/alerts/near/165174773) and core-workflow https://github.com/python/core-workflow/issues/257#issuecomment-49054183

Re: [python-committers] Merge with spurious CI failures?

2019-05-08 Thread Gregory P. Smith
fwiw a future way to avoid this mess is in https://bugs.python.org/issue36855: have the tests support multiple certificates so we can stage the new ones into our repo before updating the server. -gps On Wed, May 8, 2019 at 11:15 AM Gregory P. Smith wrote: > If this cert change is impacting CI c

Re: [python-committers] miss-islington backport pipeline is stalled?

2019-05-08 Thread Alex Gaynor
Would it make sense to work with the PSF infra staff so that miss-isslington is hooked up to the PSF Sentry account so folks can get email notifications and similar on unhandled exceptions? Alex On Wed, May 8, 2019 at 1:02 PM Mariatta wrote: > There was an error from Redis. I think this is the

Re: [python-committers] miss-islington backport pipeline is stalled?

2019-05-08 Thread Mariatta
There was an error from Redis. I think this is the first time I've seen it, so I don't have any resolution on how to fix it right now. 😟 I will look into handling the error and have miss-islington leave a comment in the PR when there is such error. log: at=info method=POST path="/" host=miss-isl

[python-committers] miss-islington backport pipeline is stalled?

2019-05-08 Thread Gregory P. Smith
Yesterday it failed to produce a backport or tell me that it couldn't (after the "i'm now working on ..." message was left on the master PR). I waited a couple hours just in case and ran cherry_picker myself instead. Same thing today apparently on https://github.com/python/cpython/pull/13192 assum

Re: [python-committers] Merge with spurious CI failures?

2019-05-08 Thread Gregory P. Smith
If this cert change is impacting CI checks for everyone's PRs, I suspect all PRs will need to merge this change into their branch before they can pass CI. Having CI depend on external network resources does not seem like a good idea. -gps On Wed, May 8, 2019 at 11:04 AM Antoine Pitrou wrote: >

Re: [python-committers] Merge with spurious CI failures?

2019-05-08 Thread Gregory P. Smith
Our pythontestdotnet repo is different than the cpython repo and the certificate gets pushed to the server after being committed by hand so it's a synchronization problem,. https://github.com/python/cpython/pull/13192 should clear it up. It's awaiting the slow CI queuing gods. It is marked autom

Re: [python-committers] Merge with spurious CI failures?

2019-05-08 Thread Antoine Pitrou
Ah, there's already a PR at https://github.com/python/cpython/pull/13192, thanks to Gregory. Regards Antoine. Le 08/05/2019 à 17:58, Antoine Pitrou a écrit : > > Ok, apparently the SSL cert on self-signed.pythontest.net was changed > but it wasn't updated in our source tree, hence the failure

Re: [python-committers] Merge with spurious CI failures?

2019-05-08 Thread Alex Gaynor
https://github.com/python/cpython/pull/13192 Thanks gps! Alex On Wed, May 8, 2019 at 11:58 AM Antoine Pitrou wrote: > > Ok, apparently the SSL cert on self-signed.pythontest.net was changed > but it wasn't updated in our source tree, hence the failure. > > Regards > > Antoine. > > > Le 08/05/2

Re: [python-committers] Merge with spurious CI failures?

2019-05-08 Thread Antoine Pitrou
Ok, apparently the SSL cert on self-signed.pythontest.net was changed but it wasn't updated in our source tree, hence the failure. Regards Antoine. Le 08/05/2019 à 17:49, Mariatta a écrit : > If you can't merge from GitHub UI then you won't be able to do it from > GitHub command line (it respe

Re: [python-committers] Merge with spurious CI failures?

2019-05-08 Thread Eric V. Smith
D’oh! Good point! Eric > On May 8, 2019, at 11:52 AM, Alex Gaynor wrote: > > Tests for that PR would presumably be green :-) > > Alex > >> On Wed, May 8, 2019 at 11:51 AM Eric V. Smith wrote: >> Surely there must be some way around it. After all, how would you merge a PR >> to fix this test

Re: [python-committers] Merge with spurious CI failures?

2019-05-08 Thread Alex Gaynor
Tests for that PR would presumably be green :-) Alex On Wed, May 8, 2019 at 11:51 AM Eric V. Smith wrote: > Surely there must be some way around it. After all, how would you merge a > PR to fix this test? > > -- > Eric V. Smith > True Blade Systems, Inc > (301) 859-4544 > > On May 8, 2019, at 1

Re: [python-committers] Merge with spurious CI failures?

2019-05-08 Thread Alex Gaynor
I don't know if CPython has a specific policy about this -- other projects I work on generally have a "we need to get master's tests passing again before anything can merge" policy. Alex On Wed, May 8, 2019 at 11:44 AM Antoine Pitrou wrote: > > They're deterministic. Apparently the test which

Re: [python-committers] [Python-Dev] Farewell, Python 3.4

2019-05-08 Thread M.-A. Lemburg
Thank you for having been 3.4 release manager, Larry ! On 08.05.2019 17:36, Larry Hastings wrote: > > It's with a note of sadness that I announce the final retirement of > Python 3.4.  The final release was back in March, but I didn't get > around to actually closing and deleting the 3.4 branch u

Re: [python-committers] Merge with spurious CI failures?

2019-05-08 Thread Eric V. Smith
Surely there must be some way around it. After all, how would you merge a PR to fix this test? -- Eric V. Smith True Blade Systems, Inc (301) 859-4544 > On May 8, 2019, at 11:49 AM, Mariatta wrote: > > If you can't merge from GitHub UI then you won't be able to do it from GitHub > command lin

Re: [python-committers] Merge with spurious CI failures?

2019-05-08 Thread Mariatta
If you can't merge from GitHub UI then you won't be able to do it from GitHub command line (it respects the same branch protection policy) I don't think we should merge if tests are still failing. Perhaps the test should be adjusted to handle this spurious errors? Can it be marked as "allowed fail

Re: [python-committers] Merge with spurious CI failures?

2019-05-08 Thread Antoine Pitrou
They're deterministic. Apparently the test which connects to "self-signed.pythontest.net" always fails now with a "self-signed certificate" error... Le 08/05/2019 à 17:37, Alex Gaynor a écrit : > Are these intermittent failures, or is there bustage on master right now? > > My usual habit on oth

Re: [python-committers] Merge with spurious CI failures?

2019-05-08 Thread Alex Gaynor
Are these intermittent failures, or is there bustage on master right now? My usual habit on other projects (I'm not very active on CPython these days) is to restart the build on travis so that is a nice green checkmark. Alex On Wed, May 8, 2019 at 11:32 AM Antoine Pitrou wrote: > > Hello, > >

[python-committers] Farewell, Python 3.4

2019-05-08 Thread Larry Hastings
It's with a note of sadness that I announce the final retirement of Python 3.4.  The final release was back in March, but I didn't get around to actually closing and deleting the 3.4 branch until this morning. Python 3.4 introduced many features we all enjoy in modern Python--the asyncio, en

[python-committers] Merge with spurious CI failures?

2019-05-08 Thread Antoine Pitrou
Hello, There are spurious CI failures (SSL certificate issue in test_httplib). Therefore the "Squash and merge" button is greyed out. How should I merge? Using the command-line instructions from Github? Regards Antoine. ___ python-committers mailing