[python-committers] Re: What is CodeCov on pull request? Does anyone use it?

2020-03-02 Thread Brett Cannon
FYI we have codecov configured to turn off the comment (and have since I think we started using codecov). See the issue for more details about a potential bug on codecov's side. ___ python-committers mailing list -- python-committers@python.org To

[python-committers] Re: What is CodeCov on pull request? Does anyone use it?

2020-03-02 Thread Paul Ganssle
I find codecov useful, but I almost always turn that comment off, as you can see here: https://github.com/pganssle/zoneinfo/blob/1bdc68b447fa84faf41cb86d7816ab06fa7a73c1/codecov.yml#L2 I think it defaults to on and has a way of occasionally failing in such a way that it fires anyway, but this is

[python-committers] Re: What is CodeCov on pull request? Does anyone use it?

2020-03-02 Thread Karthikeyan
This is being discussed at https://bugs.python.org/issue39704 On Mon, Mar 2, 2020 at 9:44 PM Victor Stinner wrote: > Hi, > > There is a new "CodeCov" thing on Python pull requests which adds a > giant comment with many numbers and statistics and then mark my pull > request as "failed" (red). >

[python-committers] What is CodeCov on pull request? Does anyone use it?

2020-03-02 Thread Victor Stinner
Hi, There is a new "CodeCov" thing on Python pull requests which adds a giant comment with many numbers and statistics and then mark my pull request as "failed" (red). I know the concept of code coverage, ok. But who uses this service? Does it *have to* send emails to say: "Merging #18743 into

[python-committers] Re: Policy around compile-time flags in bugfix releases

2020-03-02 Thread Stefan Krah
On Sun, Mar 01, 2020 at 12:17:30PM -0800, Gregory P. Smith wrote: > FWIW that is a configure flag, not a flag to the compiler, so I see no > problem with this. The default build has not changed, it just exposes > another way to build the interpreter. We've done this in the past with > things