On 7/9/2020 3:29 PM, Mariatta wrote:
If you want the associated bpo ticket to be closed when the PR is
merged, you have to add the commit message saying
"closes "
(Note that we should document this:
https://github.com/python/devguide/issues/502)
If there are backports, which is nearly always
On 7/9/2020 3:24 PM, Mariatta wrote:
is it closed automatically ?
What is "it"? The PR itself? yes the PR becomes closed if it is merged.
The branch in your github fork is not automatically deleted. There is a
button on the PR to do so. I don't know if the devguide mentions this.
The
On 7/9/2020 4:01 PM, Mariatta wrote:
Is there a way to do this if you have automerge set? I don't see a
way to control the commit message in that case, but I could easily
be missing something.
Yes, you need to edit the PR description. Automerge will take the PR
description as the
>
> Is there a way to do this if you have automerge set? I don't see a way to
> control the commit message in that case, but I could easily be missing
> something.
Yes, you need to edit the PR description. Automerge will take the PR
description as the commit message.
_
On 7/9/2020 3:29 PM, Mariatta wrote:
If you want the associated bpo ticket to be closed when the PR is
merged, you have to add the commit message saying
"closes "
(Note that we should document this:
https://github.com/python/devguide/issues/502)
Is there a way to do this if you have automerge
If you want the associated bpo ticket to be closed when the PR is merged,
you have to add the commit message saying
"closes "
(Note that we should document this:
https://github.com/python/devguide/issues/502)
If you want the the associated GitHub Issue to be closed, it is similar,
you have to add
>
> is it closed automatically ?
What is "it"? The PR itself? yes the PR becomes closed if it is merged.
___
python-committers mailing list -- python-committers@python.org
To unsubscribe send an email to python-committers-le...@python.org
https://mail.p
When a PR is merged, is it closed automatically or do we need to do something
to close it?
--
~Ethan~
___
python-committers mailing list -- python-committers@python.org
To unsubscribe send an email to python-committers-le...@python.org
https://mail.pyt