Re: [python-committers] AppVeyor is now required to pass on PRs

On 26 January 2018 at 07:31, Victor Stinner wrote: > Each time I approve a backport PR created by miss-ilington with "LGTM, > good bot", I hope secretly that the PR will be merged automatically > once CI tests pass ;-) > > Is it possible to write a bot which merges a PR? > The last time we looke

Re: [python-committers] AppVeyor is now required to pass on PRs

On 1/25/2018 4:31 PM, Victor Stinner wrote: Hi, The best would be able to have a bot merging a pull request once tests pass and a core developer asked a merge. I'm not talking about the current approval using review, but something new, like adding a special comment like "Merge". Such comment wou

Re: [python-committers] AppVeyor is now required to pass on PRs

> > Is it possible to write a bot which merges a PR? Yes it is possible, and we sort of discussing the same thing in python-dev [1] :) Each time I approve a backport PR created by miss-ilington with "LGTM, > good bot", I hope secretly that the PR will be merged automatically > once CI tests pass

Re: [python-committers] AppVeyor is now required to pass on PRs

Hi, The best would be able to have a bot merging a pull request once tests pass and a core developer asked a merge. I'm not talking about the current approval using review, but something new, like adding a special comment like "Merge". Such comment would only merge if it's written by a core develo

Re: [python-committers] AppVeyor is now required to pass on PRs

On 1/25/2018 1:52 PM, Brett Cannon wrote: On Wed, 24 Jan 2018 at 10:12 Victor Stinner > wrote: AppVeyor usually takes between 30 min and 1 hour to check a PR, Yesterday, AppVeyor surprised me by finishing in about 6 minutes, handily beating Travis. I

Re: [python-committers] AppVeyor is now required to pass on PRs

I'm fine with the delay. I've been thinking to implement the bot that will remind us when all the CI has been completed. So we don't have to wait, and won't forget about it. Currently miss-islington does this only for the backport PRs made by miss-islington. I think it'll be useful to do that on o

Re: [python-committers] AppVeyor is now required to pass on PRs

On Wed, 24 Jan 2018 at 10:12 Victor Stinner wrote: > Hi, > > AppVeyor usually takes between 30 min and 1 hour to check a PR, > whereas Travis CI takes between 10 and 20 minutes (in average, > ignoring rare cases when it's broken). AppVeyor queue is regulary > busy. > > Sometimes, I know that my P

Re: [python-committers] AppVeyor is now required to pass on PRs

Hi, AppVeyor usually takes between 30 min and 1 hour to check a PR, whereas Travis CI takes between 10 and 20 minutes (in average, ignoring rare cases when it's broken). AppVeyor queue is regulary busy. Sometimes, I know that my PR is right, because the fix is obvious. Sometimes, the PR has no im

Re: [python-committers] AppVeyor is now required to pass on PRs

FWIW two Appveyor Python builds recently failed (network errors while fetching external libraries): https://ci.appveyor.com/project/python/cpython/build/3.7build10631 https://ci.appveyor.com/project/python/cpython/build/3.7build10636 Xavier ___ python

Re: [python-committers] AppVeyor is now required to pass on PRs

/compiler support and we may break people who don’t want to upgrade if we use it.) Top-posted from my Windows phone From: Brett Cannon Sent: Tuesday, January 16, 2018 11:49 To: Antoine Pitrou Cc: python-committers Subject: Re: [python-committers] AppVeyor is now required to pass on PRs On Mon, 15

Re: [python-committers] AppVeyor is now required to pass on PRs

On Mon, 15 Jan 2018 at 14:42 Antoine Pitrou wrote: > > Hi Brett, > > Stability doesn't appear to be a problem, but we have much less > parallelism on AppVeyor than we do on Travis-CI. This may make waiting > times longer than they used to be. > > Apparently 3.6 builds (and perhaps 2.7) trigger t

Re: [python-committers] AppVeyor is now required to pass on PRs

Hi Brett, Stability doesn't appear to be a problem, but we have much less parallelism on AppVeyor than we do on Travis-CI. This may make waiting times longer than they used to be. Apparently 3.6 builds (and perhaps 2.7) trigger two sequential AppVeyor jobs: https://ci.appveyor.com/project/pytho

[python-committers] AppVeyor is now required to pass on PRs

I just switched it on to help make sure we don't break on Windows just before hitting beta. If it turns out AppVeyor isn't stable enough I will switch it back off. ___ python-committers mailing list python-committers@python.org https://mail.python.org/mai